mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
![]() This fixes a serious bug affecting all hash types with a net element - specifically, if a CIDR value is deleted such that none of the same size exist any more, all larger (less-specific) values will then fail to match. Adding back any prefix with a CIDR equal to or more specific than the one deleted will fix it. Steps to reproduce: ipset -N test hash:net ipset -A test 1.1.0.0/16 ipset -A test 2.2.2.0/24 ipset -T test 1.1.1.1 #1.1.1.1 IS in set ipset -D test 2.2.2.0/24 ipset -T test 1.1.1.1 #1.1.1.1 IS NOT in set This is due to the fact that the nets counter was unconditionally decremented prior to the iteration that shifts up the entries. Now, we first check if there is a proceeding entry and if not, decrement it and return. Otherwise, we proceed to iterate and then zero the last element, which, in most cases, will already be zero. Signed-off-by: Oliver Smith <oliver@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa> Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> |
||
---|---|---|
.. | ||
ip_set_bitmap_gen.h | ||
ip_set_bitmap_ip.c | ||
ip_set_bitmap_ipmac.c | ||
ip_set_bitmap_port.c | ||
ip_set_core.c | ||
ip_set_getport.c | ||
ip_set_hash_gen.h | ||
ip_set_hash_ip.c | ||
ip_set_hash_ipport.c | ||
ip_set_hash_ipportip.c | ||
ip_set_hash_ipportnet.c | ||
ip_set_hash_net.c | ||
ip_set_hash_netiface.c | ||
ip_set_hash_netport.c | ||
ip_set_list_set.c | ||
Kconfig | ||
Makefile | ||
pfxlen.c |