linux-stable/drivers/dma/idxd
Fenghua Yu c956be5641 dmaengine: idxd: Register dsa_bus_type before registering idxd sub-drivers
[ Upstream commit 88928addee ]

idxd sub-drivers belong to bus dsa_bus_type. Thus, dsa_bus_type must be
registered in dsa bus init before idxd drivers can be registered.

But the order is wrong when both idxd and idxd_bus are builtin drivers.
In this case, idxd driver is compiled and linked before idxd_bus driver.
Since the initcall order is determined by the link order, idxd sub-drivers
are registered in idxd initcall before dsa_bus_type is registered
in idxd_bus initcall. idxd initcall fails:

[   21.562803] calling  idxd_init_module+0x0/0x110 @ 1
[   21.570761] Driver 'idxd' was unable to register with bus_type 'dsa' because the bus was not initialized.
[   21.586475] initcall idxd_init_module+0x0/0x110 returned -22 after 15717 usecs
[   21.597178] calling  dsa_bus_init+0x0/0x20 @ 1

To fix the issue, compile and link idxd_bus driver before idxd driver
to ensure the right registration order.

Fixes: d9e5481fca ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")
Reported-by: Michael Prinke <michael.prinke@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Lijun Pan <lijun.pan@intel.com>
Tested-by: Lijun Pan <lijun.pan@intel.com>
Link: https://lore.kernel.org/r/20230924162232.1409454-1-fenghua.yu@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-20 11:08:25 +01:00
..
bus.c
cdev.c dmaengine: idxd: Fix the error handling path in idxd_cdev_register() 2022-06-09 10:23:14 +02:00
compat.c
device.c dmaengine: idxd: use spin_lock_irqsave before wait_event_lock_irq 2023-10-19 23:05:37 +02:00
dma.c dmaengine: idxd: add missing callback function to support DMA_INTERRUPT 2022-06-14 18:36:28 +02:00
idxd.h dmaengine: idxd: change bandwidth token to read buffers 2022-04-08 14:23:45 +02:00
init.c dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0 2023-03-10 09:39:34 +01:00
irq.c dmaengine: idxd: fix calling wq quiesce inside spinlock 2021-12-22 09:32:38 +01:00
Makefile dmaengine: idxd: Register dsa_bus_type before registering idxd sub-drivers 2023-11-20 11:08:25 +01:00
perfmon.c
perfmon.h
registers.h dmaengine: idxd: change bandwidth token to read buffers 2022-04-08 14:23:45 +02:00
submit.c dmaengine: idxd: fix missed completion on abort path 2021-12-22 09:32:41 +01:00
sysfs.c dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0 2023-03-10 09:39:34 +01:00