Dmitry Torokhov 9eadcebe8c tty: vt: keyboard: reject invalid keycodes ... commit b2b2dd71e0 upstream. Do not try to handle keycodes that are too big, otherwise we risk doing out-of-bounds writes: BUG: KASAN: global-out-of-bounds in clear_bit include/asm-generic/bitops-instrumented.h:56 [inline] BUG: KASAN: global-out-of-bounds in kbd_keycode drivers/tty/vt/keyboard.c:1411 [inline] BUG: KASAN: global-out-of-bounds in kbd_event+0xe6b/0x3790 drivers/tty/vt/keyboard.c:1495 Write of size 8 at addr ffffffff89a1b2d8 by task syz-executor108/1722 ... kbd_keycode drivers/tty/vt/keyboard.c:1411 [inline] kbd_event+0xe6b/0x3790 drivers/tty/vt/keyboard.c:1495 input_to_handler+0x3b6/0x4c0 drivers/input/input.c:118 input_pass_values.part.0+0x2e3/0x720 drivers/input/input.c:145 input_pass_values drivers/input/input.c:949 [inline] input_set_keycode+0x290/0x320 drivers/input/input.c:954 evdev_handle_set_keycode_v2+0xc4/0x120 drivers/input/evdev.c:882 evdev_do_ioctl drivers/input/evdev.c:1150 [inline] In this case we were dealing with a fuzzed HID device that declared over 12K buttons, and while HID layer should not be reporting to us such big keycodes, we should also be defensive and reject invalid data ourselves as well. Reported-by: syzbot+19340dff067c2d3835c0@syzkaller.appspotmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20191122204220.GA129459@dtor-ws Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-12-13 08:52:43 +01:00
..
.gitignore
consolemap.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
cp437.uni
defkeymap.c_shipped
defkeymap.map
keyboard.c	tty: vt: keyboard: reject invalid keycodes	2019-12-13 08:52:43 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
selection.c	vt: selection: take screen contents from uniscr if available	2018-07-21 09:18:27 +02:00
vc_screen.c	vt: unicode fallback for scrollback	2018-06-28 21:38:12 +09:00
vt.c	vt/fbcon: deinitialize resources in visual_init() after failed memory allocation	2019-06-09 09:17:21 +02:00
vt_ioctl.c	tty: vt_ioctl: fix potential Spectre v1	2018-09-18 15:51:30 +02:00