Eric Dumazet 9ed498c628 net: silence data-races on sk_backlog.tail ... sk->sk_backlog.tail might be read without holding the socket spinlock, we need to add proper READ_ONCE()/WRITE_ONCE() to silence the warnings. KCSAN reported : BUG: KCSAN: data-race in tcp_add_backlog / tcp_recvmsg write to 0xffff8881265109f8 of 8 bytes by interrupt on cpu 1: __sk_add_backlog include/net/sock.h:907 [inline] sk_add_backlog include/net/sock.h:938 [inline] tcp_add_backlog+0x476/0xce0 net/ipv4/tcp_ipv4.c:1759 tcp_v4_rcv+0x1a70/0x1bd0 net/ipv4/tcp_ipv4.c:1947 ip_protocol_deliver_rcu+0x4d/0x420 net/ipv4/ip_input.c:204 ip_local_deliver_finish+0x110/0x140 net/ipv4/ip_input.c:231 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ip_local_deliver+0x133/0x210 net/ipv4/ip_input.c:252 dst_input include/net/dst.h:442 [inline] ip_rcv_finish+0x121/0x160 net/ipv4/ip_input.c:413 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ip_rcv+0x18f/0x1a0 net/ipv4/ip_input.c:523 __netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:4929 __netif_receive_skb+0x37/0xf0 net/core/dev.c:5043 netif_receive_skb_internal+0x59/0x190 net/core/dev.c:5133 napi_skb_finish net/core/dev.c:5596 [inline] napi_gro_receive+0x28f/0x330 net/core/dev.c:5629 receive_buf+0x284/0x30b0 drivers/net/virtio_net.c:1061 virtnet_receive drivers/net/virtio_net.c:1323 [inline] virtnet_poll+0x436/0x7d0 drivers/net/virtio_net.c:1428 napi_poll net/core/dev.c:6311 [inline] net_rx_action+0x3ae/0xa90 net/core/dev.c:6379 __do_softirq+0x115/0x33f kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0xbb/0xe0 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:536 [inline] do_IRQ+0xa6/0x180 arch/x86/kernel/irq.c:263 ret_from_intr+0x0/0x19 native_safe_halt+0xe/0x10 arch/x86/kernel/paravirt.c:71 arch_cpu_idle+0x1f/0x30 arch/x86/kernel/process.c:571 default_idle_call+0x1e/0x40 kernel/sched/idle.c:94 cpuidle_idle_call kernel/sched/idle.c:154 [inline] do_idle+0x1af/0x280 kernel/sched/idle.c:263 cpu_startup_entry+0x1b/0x20 kernel/sched/idle.c:355 start_secondary+0x208/0x260 arch/x86/kernel/smpboot.c:264 secondary_startup_64+0xa4/0xb0 arch/x86/kernel/head_64.S:241 read to 0xffff8881265109f8 of 8 bytes by task 8057 on cpu 0: tcp_recvmsg+0x46e/0x1b40 net/ipv4/tcp.c:2050 inet_recvmsg+0xbb/0x250 net/ipv4/af_inet.c:838 sock_recvmsg_nosec net/socket.c:871 [inline] sock_recvmsg net/socket.c:889 [inline] sock_recvmsg+0x92/0xb0 net/socket.c:885 sock_read_iter+0x15f/0x1e0 net/socket.c:967 call_read_iter include/linux/fs.h:1889 [inline] new_sync_read+0x389/0x4f0 fs/read_write.c:414 __vfs_read+0xb1/0xc0 fs/read_write.c:427 vfs_read fs/read_write.c:461 [inline] vfs_read+0x143/0x2c0 fs/read_write.c:446 ksys_read+0xd5/0x1b0 fs/read_write.c:587 __do_sys_read fs/read_write.c:597 [inline] __se_sys_read fs/read_write.c:595 [inline] __x64_sys_read+0x4c/0x60 fs/read_write.c:595 do_syscall_64+0xcc/0x370 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Reported by Kernel Concurrency Sanitizer on: CPU: 0 PID: 8057 Comm: syz-fuzzer Not tainted 5.4.0-rc6+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-11-06 21:35:34 -08:00
..
bpfilter	SPDX update for 5.2-rc2, round 1	2019-05-21 12:33:38 -07:00
netfilter	icmp: remove duplicate code	2019-11-05 14:03:11 -08:00
af_inet.c	net: annotate lockless accesses to sk->sk_max_ack_backlog	2019-11-06 16:14:48 -08:00
ah4.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
arp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cipso_ipv4.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
datagram.c	inet: stop leaking jiffies on the wire	2019-11-01 14:57:52 -07:00
devinet.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
esp4.c	xfrm: remove get_mtu indirection from xfrm_type	2019-07-01 06:16:40 +02:00
esp4_offload.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2019-07-05 15:01:15 -07:00
fib_frontend.c	ipv4: fix route update on metric change.	2019-10-26 11:25:53 -07:00
fib_lookup.h	ipv4: Use accessors for fib_info nexthop data	2019-06-04 19:26:49 -07:00
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_semantics.c	net: Properly update v4 routes with v6 nexthop	2019-09-05 12:35:58 +02:00
fib_trie.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fou.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
gre_demux.c	net: remove unused parameter from skb_checksum_try_convert	2019-07-05 15:30:36 -07:00
gre_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
icmp.c	net: icmp: use input address in traceroute	2019-11-03 17:25:18 -08:00
igmp.c	igmp: uninline ip_mc_validate_checksum()	2019-10-04 14:26:46 -07:00
inet_connection_sock.c	net: annotate lockless accesses to sk->sk_max_ack_backlog	2019-11-06 16:14:48 -08:00
inet_diag.c	inet_diag: use jiffies_delta_to_msecs()	2019-11-06 16:14:48 -08:00
inet_fragment.c	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
inet_hashtables.c	net: annotate accesses to sk->sk_incoming_cpu	2019-10-30 13:24:25 -07:00
inet_timewait_sock.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
inetpeer.c	net: ipv4: use a dedicated counter for icmp_v4 redirect packets	2019-02-08 21:50:15 -08:00
ip_forward.c	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
ip_fragment.c	inet: frags: re-introduce skb coalescing for local delivery	2019-08-08 15:55:10 -07:00
ip_gre.c	erspan: fix the tun_info options_len check for erspan	2019-10-29 17:36:42 -07:00
ip_input.c	inet: do not call sublist_rcv on empty list	2019-10-29 17:54:29 -07:00
ip_options.c	netfilter: nf_tables: add support for matching IPv4 options	2019-06-21 18:35:51 +02:00
ip_output.c	ipv4: fix IPSKB_FRAG_PMTU handling with fragmentation	2019-10-21 10:46:42 -07:00
ip_sockglue.c	ip_sockglue: Fix missing-check bug in ip_ra_control()	2019-05-25 11:00:50 -07:00
ip_tunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 269	2019-06-05 17:30:29 +02:00
ip_tunnel_core.c	lwtunnel: add options setting and dumping for erspan	2019-11-06 21:14:22 -08:00
ip_vti.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ipcomp.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2019-07-05 15:01:15 -07:00
ipconfig.c	ipconfig: Handle CONFIG_CIFS_ROOT option	2019-10-02 12:15:15 -04:00
ipip.c	ipip: validate header length in ipip_tunnel_xmit	2019-07-25 17:23:40 -07:00
ipmr.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-10-05 13:37:23 -07:00
ipmr_base.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
Kconfig	net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
Makefile	net: Initial nexthop code	2019-05-28 21:37:30 -07:00
metrics.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
netfilter.c	netfilter: ipv4: remove useless export_symbol	2019-01-28 11:32:58 +01:00
netlink.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
nexthop.c	nexthops: remove redundant assignment to variable err	2019-08-22 12:14:05 -07:00
ping.c	ip: support SO_MARK cmsg	2019-09-13 21:44:19 +02:00
proc.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
raw.c	netfilter: drop bridge nf reset from nf_reset	2019-10-01 18:42:15 +02:00
raw_diag.c	net: don't warn in inet diag when IPV6 is disabled	2019-07-03 11:26:35 -07:00
route.c	icmp: remove duplicate code	2019-11-05 14:03:11 -08:00
syncookies.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sysctl_net_ipv4.c	tcp: add new tcp_mtu_probe_floor sysctl	2019-08-09 13:03:30 -07:00
tcp.c	net: silence data-races on sk_backlog.tail	2019-11-06 21:35:34 -08:00
tcp_bbr.c	tcp_bbr: fix quantization code to not raise cwnd if not probing bandwidth	2019-09-27 20:37:50 +02:00
tcp_bic.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_bpf.c	net/tls: prevent skb_orphan() from leaking TLS plain text with offload	2019-08-08 22:39:35 -07:00
tcp_cdg.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_cong.c	tcp: fix tcp_set_congestion_control() use from bpf hook	2019-07-18 20:33:48 -07:00
tcp_cubic.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_dctcp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tcp_dctcp.h	tcp: refactor DCTCP ECN ACK handling	2018-10-10 22:26:00 -07:00
tcp_diag.c	net: annotate lockless accesses to sk->sk_max_ack_backlog	2019-11-06 16:14:48 -08:00
tcp_fastopen.c	tcp: add TCP_INFO status for failed client TFO	2019-10-25 19:25:37 -07:00
tcp_highspeed.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_htcp.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_hybla.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_illinois.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_input.c	tcp: add TCP_INFO status for failed client TFO	2019-10-25 19:25:37 -07:00
tcp_ipv4.c	net: annotate lockless accesses to sk->sk_ack_backlog	2019-11-06 16:14:48 -08:00
tcp_lp.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_metrics.c	tcp: refactor setting the initial congestion window	2019-05-01 11:47:54 -04:00
tcp_minisocks.c	tcp: annotate tp->snd_nxt lockless reads	2019-10-13 10:13:08 -07:00
tcp_nv.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_offload.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tcp_output.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
tcp_rate.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
tcp_recovery.c	tcp: introduce tcp_skb_timestamp_us() helper	2018-09-21 19:37:59 -07:00
tcp_scalable.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_timer.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
tcp_ulp.c	bpf: sockmap/tls, close can race with map free	2019-07-22 16:04:17 +02:00
tcp_vegas.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_vegas.h
tcp_veno.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_westwood.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tcp_yeah.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tunnel4.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
udp.c	net: annotate accesses to sk->sk_incoming_cpu	2019-10-30 13:24:25 -07:00
udp_diag.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
udp_impl.h	udp: add missing rehash callback to udplite	2019-01-17 15:01:08 -08:00
udp_offload.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
udp_tunnel.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
udplite.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_input.c	xfrm: reset transport header back to network header after all input transforms ahave been applied	2018-09-04 10:26:30 +02:00
xfrm4_output.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_policy.c	ipv4: Revert removal of rt_uses_gateway	2019-09-20 18:23:33 -07:00
xfrm4_protocol.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
xfrm4_state.c	xfrm: remove eth_proto value from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00
xfrm4_tunnel.c	xfrm: remove type and offload_type map from xfrm_state_afinfo	2019-06-06 08:34:50 +02:00