Paolo Abeni a0eea5f10e mptcp: fix memory leak on address flush ... The endpoint cleanup path is prone to a memory leak, as reported by syzkaller: BUG: memory leak unreferenced object 0xffff88810680ea00 (size 64): comm "syz-executor.6", pid 6191, jiffies 4295756280 (age 24.138s) hex dump (first 32 bytes): 58 75 7d 3c 80 88 ff ff 22 01 00 00 00 00 ad de Xu}<...."....... 01 00 02 00 00 00 00 00 ac 1e 00 07 00 00 00 00 ................ backtrace: [<0000000072a9f72a>] kmalloc include/linux/slab.h:591 [inline] [<0000000072a9f72a>] mptcp_nl_cmd_add_addr+0x287/0x9f0 net/mptcp/pm_netlink.c:1170 [<00000000f6e931bf>] genl_family_rcv_msg_doit.isra.0+0x225/0x340 net/netlink/genetlink.c:731 [<00000000f1504a2c>] genl_family_rcv_msg net/netlink/genetlink.c:775 [inline] [<00000000f1504a2c>] genl_rcv_msg+0x341/0x5b0 net/netlink/genetlink.c:792 [<0000000097e76f6a>] netlink_rcv_skb+0x148/0x430 net/netlink/af_netlink.c:2504 [<00000000ceefa2b8>] genl_rcv+0x24/0x40 net/netlink/genetlink.c:803 [<000000008ff91aec>] netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] [<000000008ff91aec>] netlink_unicast+0x537/0x750 net/netlink/af_netlink.c:1340 [<0000000041682c35>] netlink_sendmsg+0x846/0xd80 net/netlink/af_netlink.c:1929 [<00000000df3aa8e7>] sock_sendmsg_nosec net/socket.c:704 [inline] [<00000000df3aa8e7>] sock_sendmsg+0x14e/0x190 net/socket.c:724 [<000000002154c54c>] ____sys_sendmsg+0x709/0x870 net/socket.c:2403 [<000000001aab01d7>] ___sys_sendmsg+0xff/0x170 net/socket.c:2457 [<00000000fa3b1446>] __sys_sendmsg+0xe5/0x1b0 net/socket.c:2486 [<00000000db2ee9c7>] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [<00000000db2ee9c7>] do_syscall_64+0x38/0x90 arch/x86/entry/common.c:80 [<000000005873517d>] entry_SYSCALL_64_after_hwframe+0x44/0xae We should not require an allocation to cleanup stuff. Rework the code a bit so that the additional RCU work is no more needed. Fixes: 1729cf186d ("mptcp: create the listening socket for new port") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-08-19 12:16:54 +01:00
..
crypto.c	kunit: mptcp: adhere to KUNIT formatting standard	2021-04-16 17:10:40 -07:00
crypto_test.c	mptcp: move crypto test to KUNIT	2020-06-26 16:21:39 -07:00
ctrl.c	mptcp: add sysctl allow_join_initial_addr_port	2021-06-22 14:36:01 -07:00
diag.c	mptcp: allow dumping subflow context to userspace	2020-03-29 22:14:48 -07:00
Kconfig	kunit: mptcp: adhere to KUNIT formatting standard	2021-04-16 17:10:40 -07:00
Makefile	kunit: mptcp: adhere to KUNIT formatting standard	2021-04-16 17:10:40 -07:00
mib.c	mptcp: properly account bulk freed memory	2021-07-09 18:38:53 -07:00
mib.h	mptcp: properly account bulk freed memory	2021-07-09 18:38:53 -07:00
mptcp_diag.c	net: Use nlmsg_unicast() instead of netlink_unicast()	2021-07-13 09:28:29 -07:00
options.c	mptcp: avoid processing packet if a subflow reset	2021-07-09 18:38:53 -07:00
pm.c	mptcp: add deny_join_id0 in mptcp_options_received	2021-06-22 14:36:01 -07:00
pm_netlink.c	mptcp: fix memory leak on address flush	2021-08-19 12:16:54 +01:00
protocol.c	mptcp: properly account bulk freed memory	2021-07-09 18:38:53 -07:00
protocol.h	mptcp: properly account bulk freed memory	2021-07-09 18:38:53 -07:00
sockopt.c	net: sock: extend SO_TIMESTAMPING for PHC binding	2021-07-01 13:08:18 -07:00
subflow.c	mptcp: fix syncookie process if mptcp can not_accept new subflow	2021-07-09 18:38:53 -07:00
syncookies.c	mptcp: fix warning in __skb_flow_dissect() when do syn cookie for subflow join	2021-07-09 18:38:53 -07:00
token.c	mptcp: using TOKEN_MAX_RETRIES instead of magic number	2021-05-28 13:59:15 -07:00
token_test.c	mptcp: introduce token KUNIT self-tests	2020-06-26 16:21:39 -07:00