mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
7c3e9fcad9
The typedefs u32 and u64 are not available in userspace. Thus user get
an error he try to use DMA_BUF_SET_NAME_A or DMA_BUF_SET_NAME_B:
$ gcc -Wall -c -MMD -c -o ioctls_list.o ioctls_list.c
In file included from /usr/include/x86_64-linux-gnu/asm/ioctl.h:1,
from /usr/include/linux/ioctl.h:5,
from /usr/include/asm-generic/ioctls.h:5,
from ioctls_list.c:11:
ioctls_list.c:463:29: error: ‘u32’ undeclared here (not in a function)
463 | { "DMA_BUF_SET_NAME_A", DMA_BUF_SET_NAME_A, -1, -1 }, // linux/dma-buf.h
| ^~~~~~~~~~~~~~~~~~
ioctls_list.c:464:29: error: ‘u64’ undeclared here (not in a function)
464 | { "DMA_BUF_SET_NAME_B", DMA_BUF_SET_NAME_B, -1, -1 }, // linux/dma-buf.h
| ^~~~~~~~~~~~~~~~~~
The issue was initially reported here[1].
[1]: https://github.com/jerome-pouiller/ioctl/pull/14
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Fixes: a5bff92eaa ("dma-buf: Fix SET_NAME ioctl uapi")
CC: stable@vger.kernel.org
Link: https://patchwork.freedesktop.org/patch/msgid/20220517072708.245265-1-Jerome.Pouiller@silabs.com
Signed-off-by: Christian König <christian.koenig@amd.com>
98 lines
3.7 KiB
C
98 lines
3.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
/*
|
|
* Framework for buffer objects that can be shared across devices/subsystems.
|
|
*
|
|
* Copyright(C) 2015 Intel Ltd
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published by
|
|
* the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _DMA_BUF_UAPI_H_
|
|
#define _DMA_BUF_UAPI_H_
|
|
|
|
#include <linux/types.h>
|
|
|
|
/**
|
|
* struct dma_buf_sync - Synchronize with CPU access.
|
|
*
|
|
* When a DMA buffer is accessed from the CPU via mmap, it is not always
|
|
* possible to guarantee coherency between the CPU-visible map and underlying
|
|
* memory. To manage coherency, DMA_BUF_IOCTL_SYNC must be used to bracket
|
|
* any CPU access to give the kernel the chance to shuffle memory around if
|
|
* needed.
|
|
*
|
|
* Prior to accessing the map, the client must call DMA_BUF_IOCTL_SYNC
|
|
* with DMA_BUF_SYNC_START and the appropriate read/write flags. Once the
|
|
* access is complete, the client should call DMA_BUF_IOCTL_SYNC with
|
|
* DMA_BUF_SYNC_END and the same read/write flags.
|
|
*
|
|
* The synchronization provided via DMA_BUF_IOCTL_SYNC only provides cache
|
|
* coherency. It does not prevent other processes or devices from
|
|
* accessing the memory at the same time. If synchronization with a GPU or
|
|
* other device driver is required, it is the client's responsibility to
|
|
* wait for buffer to be ready for reading or writing before calling this
|
|
* ioctl with DMA_BUF_SYNC_START. Likewise, the client must ensure that
|
|
* follow-up work is not submitted to GPU or other device driver until
|
|
* after this ioctl has been called with DMA_BUF_SYNC_END?
|
|
*
|
|
* If the driver or API with which the client is interacting uses implicit
|
|
* synchronization, waiting for prior work to complete can be done via
|
|
* poll() on the DMA buffer file descriptor. If the driver or API requires
|
|
* explicit synchronization, the client may have to wait on a sync_file or
|
|
* other synchronization primitive outside the scope of the DMA buffer API.
|
|
*/
|
|
struct dma_buf_sync {
|
|
/**
|
|
* @flags: Set of access flags
|
|
*
|
|
* DMA_BUF_SYNC_START:
|
|
* Indicates the start of a map access session.
|
|
*
|
|
* DMA_BUF_SYNC_END:
|
|
* Indicates the end of a map access session.
|
|
*
|
|
* DMA_BUF_SYNC_READ:
|
|
* Indicates that the mapped DMA buffer will be read by the
|
|
* client via the CPU map.
|
|
*
|
|
* DMA_BUF_SYNC_WRITE:
|
|
* Indicates that the mapped DMA buffer will be written by the
|
|
* client via the CPU map.
|
|
*
|
|
* DMA_BUF_SYNC_RW:
|
|
* An alias for DMA_BUF_SYNC_READ | DMA_BUF_SYNC_WRITE.
|
|
*/
|
|
__u64 flags;
|
|
};
|
|
|
|
#define DMA_BUF_SYNC_READ (1 << 0)
|
|
#define DMA_BUF_SYNC_WRITE (2 << 0)
|
|
#define DMA_BUF_SYNC_RW (DMA_BUF_SYNC_READ | DMA_BUF_SYNC_WRITE)
|
|
#define DMA_BUF_SYNC_START (0 << 2)
|
|
#define DMA_BUF_SYNC_END (1 << 2)
|
|
#define DMA_BUF_SYNC_VALID_FLAGS_MASK \
|
|
(DMA_BUF_SYNC_RW | DMA_BUF_SYNC_END)
|
|
|
|
#define DMA_BUF_NAME_LEN 32
|
|
|
|
#define DMA_BUF_BASE 'b'
|
|
#define DMA_BUF_IOCTL_SYNC _IOW(DMA_BUF_BASE, 0, struct dma_buf_sync)
|
|
|
|
/* 32/64bitness of this uapi was botched in android, there's no difference
|
|
* between them in actual uapi, they're just different numbers.
|
|
*/
|
|
#define DMA_BUF_SET_NAME _IOW(DMA_BUF_BASE, 1, const char *)
|
|
#define DMA_BUF_SET_NAME_A _IOW(DMA_BUF_BASE, 1, __u32)
|
|
#define DMA_BUF_SET_NAME_B _IOW(DMA_BUF_BASE, 1, __u64)
|
|
|
|
#endif
|