mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
e5f3155267
The 'imply' keyword does not do what most people think it does, it only
politely asks Kconfig to turn on another symbol, but does not prevent
it from being disabled manually or built as a loadable module when the
user is built-in. In the ICE driver, the latter now causes a link failure:
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':
ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'
aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'
ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
This is a recurring problem in many drivers, and we have discussed
it several times befores, without reaching a consensus. I'm providing
a link to the previous email thread for reference, which discusses
some related problems.
To solve the dependency issue better than the 'imply' keyword, introduce a
separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
can depend on if it is able to use PTP support when available, but works
fine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers are
then prevented from being built-in, the same way as with a 'depends on
PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
but that can be rather confusing when you first see it.
Since this should cover the dependencies correctly, the IS_REACHABLE()
hack in the header is no longer needed now, and can be turned back
into a normal IS_ENABLED() check. Any driver that gets the dependency
wrong will now cause a link time failure rather than being unable to use
PTP support when that is in a loadable module.
However, the two recently added ptp_get_vclocks_index() and
ptp_convert_timestamp() interfaces are only called from builtin code with
ethtool and socket timestamps, so keep the current behavior by stubbing
those out completely when PTP is in a loadable module. This should be
addressed properly in a follow-up.
As Richard suggested, we may want to actually turn PTP support into a
'bool' option later on, preventing it from being a loadable module
altogether, which would be one way to solve the problem with the ethtool
interface.
Fixes: 06c16d89d2 ("ice: register 1588 PTP clock device object for E810 devices")
Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/
Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/
Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/
Acked-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
144 lines
4.2 KiB
Text
144 lines
4.2 KiB
Text
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# HISILICON device configuration
|
|
#
|
|
|
|
config NET_VENDOR_HISILICON
|
|
bool "Hisilicon devices"
|
|
default y
|
|
depends on OF || ACPI
|
|
depends on ARM || ARM64 || COMPILE_TEST
|
|
help
|
|
If you have a network (Ethernet) card belonging to this class, say Y.
|
|
|
|
Note that the answer to this question doesn't directly affect the
|
|
kernel: saying N will just cause the configurator to skip all
|
|
the questions about Hisilicon devices. If you say Y, you will be asked
|
|
for your specific card in the following questions.
|
|
|
|
if NET_VENDOR_HISILICON
|
|
|
|
config HIX5HD2_GMAC
|
|
tristate "Hisilicon HIX5HD2 Family Network Device Support"
|
|
select PHYLIB
|
|
help
|
|
This selects the hix5hd2 mac family network device.
|
|
|
|
config HISI_FEMAC
|
|
tristate "Hisilicon Fast Ethernet MAC device support"
|
|
depends on HAS_IOMEM
|
|
select PHYLIB
|
|
select RESET_CONTROLLER
|
|
help
|
|
This selects the Hisilicon Fast Ethernet MAC device(FEMAC).
|
|
The FEMAC receives and transmits data over Ethernet
|
|
ports at 10/100 Mbps in full-duplex or half-duplex mode.
|
|
The FEMAC exchanges data with the CPU, and supports
|
|
the energy efficient Ethernet (EEE).
|
|
|
|
config HIP04_ETH
|
|
tristate "HISILICON P04 Ethernet support"
|
|
depends on HAS_IOMEM # For MFD_SYSCON
|
|
select MARVELL_PHY
|
|
select MFD_SYSCON
|
|
select HNS_MDIO
|
|
help
|
|
If you wish to compile a kernel for a hardware with hisilicon p04 SoC and
|
|
want to use the internal ethernet then you should answer Y to this.
|
|
|
|
config HI13X1_GMAC
|
|
bool "Hisilicon HI13X1 Network Device Support"
|
|
depends on HIP04_ETH
|
|
help
|
|
If you wish to compile a kernel for a hardware with hisilicon hi13x1_gamc
|
|
then you should answer Y to this. This makes this driver suitable for use
|
|
on certain boards such as the HI13X1.
|
|
|
|
If you are unsure, say N.
|
|
|
|
config HNS_MDIO
|
|
tristate
|
|
select PHYLIB
|
|
help
|
|
This selects the HNS MDIO support. It is needed by HNS_DSAF to access
|
|
the PHY
|
|
|
|
config HNS
|
|
tristate
|
|
help
|
|
This selects the framework support for Hisilicon Network Subsystem. It
|
|
is needed by any driver which provides HNS acceleration engine or make
|
|
use of the engine
|
|
|
|
config HNS_DSAF
|
|
tristate "Hisilicon HNS DSAF device Support"
|
|
select HNS
|
|
select HNS_MDIO
|
|
help
|
|
This selects the DSAF (Distributed System Area Frabric) network
|
|
acceleration engine support. The engine is used in Hisilicon hip05,
|
|
Hi1610 and further ICT SoC
|
|
|
|
config HNS_ENET
|
|
tristate "Hisilicon HNS Ethernet Device Support"
|
|
select PHYLIB
|
|
select HNS
|
|
help
|
|
This selects the general ethernet driver for HNS. This module make
|
|
use of any HNS AE driver, such as HNS_DSAF
|
|
|
|
config HNS3
|
|
tristate "Hisilicon Network Subsystem Support HNS3 (Framework)"
|
|
depends on PCI
|
|
select NET_DEVLINK
|
|
select PAGE_POOL
|
|
help
|
|
This selects the framework support for Hisilicon Network Subsystem 3.
|
|
This layer facilitates clients like ENET, RoCE and user-space ethernet
|
|
drivers(like ODP)to register with HNAE devices and their associated
|
|
operations.
|
|
|
|
if HNS3
|
|
|
|
config HNS3_HCLGE
|
|
tristate "Hisilicon HNS3 HCLGE Acceleration Engine & Compatibility Layer Support"
|
|
default m
|
|
depends on PCI_MSI
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
help
|
|
This selects the HNS3_HCLGE network acceleration engine & its hardware
|
|
compatibility layer. The engine would be used in Hisilicon hip08 family of
|
|
SoCs and further upcoming SoCs.
|
|
|
|
config HNS3_DCB
|
|
bool "Hisilicon HNS3 Data Center Bridge Support"
|
|
default n
|
|
depends on HNS3_HCLGE && DCB
|
|
help
|
|
Say Y here if you want to use Data Center Bridging (DCB) in the HNS3 driver.
|
|
|
|
If unsure, say N.
|
|
|
|
config HNS3_HCLGEVF
|
|
tristate "Hisilicon HNS3VF Acceleration Engine & Compatibility Layer Support"
|
|
depends on PCI_MSI
|
|
depends on HNS3_HCLGE
|
|
help
|
|
This selects the HNS3 VF drivers network acceleration engine & its hardware
|
|
compatibility layer. The engine would be used in Hisilicon hip08 family of
|
|
SoCs and further upcoming SoCs.
|
|
|
|
config HNS3_ENET
|
|
tristate "Hisilicon HNS3 Ethernet Device Support"
|
|
default m
|
|
depends on 64BIT && PCI
|
|
depends on INET
|
|
select DIMLIB
|
|
help
|
|
This selects the Ethernet Driver for Hisilicon Network Subsystem 3 for hip08
|
|
family of SoCs. This module depends upon HNAE3 driver to access the HNAE3
|
|
devices and their associated operations.
|
|
|
|
endif #HNS3
|
|
|
|
endif # NET_VENDOR_HISILICON
|