Nick Bowler a25d426158 nvme: define compat_ioctl again to unbreak 32-bit userspace. ... Commit 89b3d6e605 ("nvme: simplify the compat ioctl handling") removed the initialization of compat_ioctl from the nvme block_device_operations structures. Presumably the expectation was that 32-bit ioctls would be directed through the regular handler but this is not the case: failing to assign .compat_ioctl actually means that the compat case is disabled entirely, and any attempt to submit nvme ioctls from 32-bit userspace fails outright with -ENOTTY. For example: % smartctl -x /dev/nvme0n1 [...] Read NVMe Identify Controller failed: NVME_IOCTL_ADMIN_CMD: Inappropriate ioctl for device The blkdev_compat_ptr_ioctl helper can be used to direct compat calls through the main ioctl handler and makes things work again. Fixes: 89b3d6e605 ("nvme: simplify the compat ioctl handling") Signed-off-by: Nick Bowler <nbowler@draconx.ca> Reviewed-by: Guixin Liu <kanie@linux.alibaba.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2022-08-02 17:22:48 -06:00
..
common	nvme-auth: Diffie-Hellman key exchange support	2022-08-02 17:14:49 -06:00
host	nvme: define compat_ioctl again to unbreak 32-bit userspace.	2022-08-02 17:22:48 -06:00
target	nvmet-auth: expire authentication sessions	2022-08-02 17:14:50 -06:00
Kconfig	nvme: implement In-Band authentication	2022-08-02 17:14:49 -06:00
Makefile	nvme: implement In-Band authentication	2022-08-02 17:14:49 -06:00