mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
![Krzysztof Kozlowski](/assets/img/avatar_default.png)
Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are adjusted. Each driver provides the implementation of power supply. However it should not be the owner of power supply class instance because it is exposed by core to other subsystems with power_supply_get_by_name(). These other subsystems have no knowledge when the driver will unregister the power supply. This leads to several issues when driver is unbound - mostly because user of power supply accesses freed memory. Instead let the core own the instance of struct 'power_supply'. Other users of this power supply will still access valid memory because it will be freed when device reference count reaches 0. Currently this means "it will leak" but power_supply_put() call in next patches will solve it. This solves invalid memory references in following race condition scenario: Thread 1: charger manager Thread 2: power supply driver, used by charger manager THREAD 1 (charger manager) THREAD 2 (power supply driver) ========================== ============================== psy = power_supply_get_by_name() Driver unbind, .remove power_supply_unregister() Device fully removed psy->get_property() The 'get_property' call is executed in invalid context because the driver was unbound and struct 'power_supply' memory was freed. This could be observed easily with charger manager driver (here compiled with max17040 fuel gauge): $ cat /sys/devices/virtual/power_supply/cm-battery/capacity & $ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind [ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 55.732584] pgd = d98d4000 [ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000 [ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM [ 55.746210] Modules linked in: [ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496 [ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000 [ 55.771647] PC is at 0x0 [ 55.774182] LR is at charger_get_property+0x2f4/0x36c [ 55.779201] pc : [<00000000>] lr : [<c034b0b4>] psr: 60000013 [ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000 [ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68 [ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000 [ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68 [ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015 [ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210) [ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000) [ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8 [ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4 [ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80 [ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001 [ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000 [ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000 [ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124 [ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550 [ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364 [ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c [ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000 [ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000 [ 55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c) [ 55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48) [ 55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104) [ 55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28) [ 55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484) [ 55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c) [ 55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100) [ 55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c) [ 55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48) [ 56.000626] Code: bad PC value [ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]--- Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [for the nvec part] Reviewed-by: Marc Dietrich <marvin24@gmx.de> [for compal-laptop.c] Acked-by: Darren Hart <dvhart@linux.intel.com> [for the mfd part] Acked-by: Lee Jones <lee.jones@linaro.org> [for the hid part] Acked-by: Jiri Kosina <jkosina@suse.cz> [for the acpi part] Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
376 lines
10 KiB
C
376 lines
10 KiB
C
/*
|
|
* Copyright © 2007 Anton Vorontsov <cbou@mail.ru>
|
|
* Copyright © 2007 Eugeny Boger <eugenyboger@dgap.mipt.ru>
|
|
*
|
|
* Author: Eugeny Boger <eugenyboger@dgap.mipt.ru>
|
|
*
|
|
* Use consistent with the GNU GPL is permitted,
|
|
* provided that this copyright notice is
|
|
* preserved in its entirety in all copies and derived works.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/device.h>
|
|
#include <linux/power_supply.h>
|
|
#include <linux/apm-emulation.h>
|
|
|
|
|
|
#define PSY_PROP(psy, prop, val) (power_supply_get_property(psy, \
|
|
POWER_SUPPLY_PROP_##prop, val))
|
|
|
|
#define _MPSY_PROP(prop, val) (power_supply_get_property(main_battery, \
|
|
prop, val))
|
|
|
|
#define MPSY_PROP(prop, val) _MPSY_PROP(POWER_SUPPLY_PROP_##prop, val)
|
|
|
|
static DEFINE_MUTEX(apm_mutex);
|
|
static struct power_supply *main_battery;
|
|
|
|
enum apm_source {
|
|
SOURCE_ENERGY,
|
|
SOURCE_CHARGE,
|
|
SOURCE_VOLTAGE,
|
|
};
|
|
|
|
struct find_bat_param {
|
|
struct power_supply *main;
|
|
struct power_supply *bat;
|
|
struct power_supply *max_charge_bat;
|
|
struct power_supply *max_energy_bat;
|
|
union power_supply_propval full;
|
|
int max_charge;
|
|
int max_energy;
|
|
};
|
|
|
|
static int __find_main_battery(struct device *dev, void *data)
|
|
{
|
|
struct find_bat_param *bp = (struct find_bat_param *)data;
|
|
|
|
bp->bat = dev_get_drvdata(dev);
|
|
|
|
if (bp->bat->desc->use_for_apm) {
|
|
/* nice, we explicitly asked to report this battery. */
|
|
bp->main = bp->bat;
|
|
return 1;
|
|
}
|
|
|
|
if (!PSY_PROP(bp->bat, CHARGE_FULL_DESIGN, &bp->full) ||
|
|
!PSY_PROP(bp->bat, CHARGE_FULL, &bp->full)) {
|
|
if (bp->full.intval > bp->max_charge) {
|
|
bp->max_charge_bat = bp->bat;
|
|
bp->max_charge = bp->full.intval;
|
|
}
|
|
} else if (!PSY_PROP(bp->bat, ENERGY_FULL_DESIGN, &bp->full) ||
|
|
!PSY_PROP(bp->bat, ENERGY_FULL, &bp->full)) {
|
|
if (bp->full.intval > bp->max_energy) {
|
|
bp->max_energy_bat = bp->bat;
|
|
bp->max_energy = bp->full.intval;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void find_main_battery(void)
|
|
{
|
|
struct find_bat_param bp;
|
|
int error;
|
|
|
|
memset(&bp, 0, sizeof(struct find_bat_param));
|
|
main_battery = NULL;
|
|
bp.main = main_battery;
|
|
|
|
error = class_for_each_device(power_supply_class, NULL, &bp,
|
|
__find_main_battery);
|
|
if (error) {
|
|
main_battery = bp.main;
|
|
return;
|
|
}
|
|
|
|
if ((bp.max_energy_bat && bp.max_charge_bat) &&
|
|
(bp.max_energy_bat != bp.max_charge_bat)) {
|
|
/* try guess battery with more capacity */
|
|
if (!PSY_PROP(bp.max_charge_bat, VOLTAGE_MAX_DESIGN,
|
|
&bp.full)) {
|
|
if (bp.max_energy > bp.max_charge * bp.full.intval)
|
|
main_battery = bp.max_energy_bat;
|
|
else
|
|
main_battery = bp.max_charge_bat;
|
|
} else if (!PSY_PROP(bp.max_energy_bat, VOLTAGE_MAX_DESIGN,
|
|
&bp.full)) {
|
|
if (bp.max_charge > bp.max_energy / bp.full.intval)
|
|
main_battery = bp.max_charge_bat;
|
|
else
|
|
main_battery = bp.max_energy_bat;
|
|
} else {
|
|
/* give up, choice any */
|
|
main_battery = bp.max_energy_bat;
|
|
}
|
|
} else if (bp.max_charge_bat) {
|
|
main_battery = bp.max_charge_bat;
|
|
} else if (bp.max_energy_bat) {
|
|
main_battery = bp.max_energy_bat;
|
|
} else {
|
|
/* give up, try the last if any */
|
|
main_battery = bp.bat;
|
|
}
|
|
}
|
|
|
|
static int do_calculate_time(int status, enum apm_source source)
|
|
{
|
|
union power_supply_propval full;
|
|
union power_supply_propval empty;
|
|
union power_supply_propval cur;
|
|
union power_supply_propval I;
|
|
enum power_supply_property full_prop;
|
|
enum power_supply_property full_design_prop;
|
|
enum power_supply_property empty_prop;
|
|
enum power_supply_property empty_design_prop;
|
|
enum power_supply_property cur_avg_prop;
|
|
enum power_supply_property cur_now_prop;
|
|
|
|
if (MPSY_PROP(CURRENT_AVG, &I)) {
|
|
/* if battery can't report average value, use momentary */
|
|
if (MPSY_PROP(CURRENT_NOW, &I))
|
|
return -1;
|
|
}
|
|
|
|
if (!I.intval)
|
|
return 0;
|
|
|
|
switch (source) {
|
|
case SOURCE_CHARGE:
|
|
full_prop = POWER_SUPPLY_PROP_CHARGE_FULL;
|
|
full_design_prop = POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN;
|
|
empty_prop = POWER_SUPPLY_PROP_CHARGE_EMPTY;
|
|
empty_design_prop = POWER_SUPPLY_PROP_CHARGE_EMPTY;
|
|
cur_avg_prop = POWER_SUPPLY_PROP_CHARGE_AVG;
|
|
cur_now_prop = POWER_SUPPLY_PROP_CHARGE_NOW;
|
|
break;
|
|
case SOURCE_ENERGY:
|
|
full_prop = POWER_SUPPLY_PROP_ENERGY_FULL;
|
|
full_design_prop = POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN;
|
|
empty_prop = POWER_SUPPLY_PROP_ENERGY_EMPTY;
|
|
empty_design_prop = POWER_SUPPLY_PROP_CHARGE_EMPTY;
|
|
cur_avg_prop = POWER_SUPPLY_PROP_ENERGY_AVG;
|
|
cur_now_prop = POWER_SUPPLY_PROP_ENERGY_NOW;
|
|
break;
|
|
case SOURCE_VOLTAGE:
|
|
full_prop = POWER_SUPPLY_PROP_VOLTAGE_MAX;
|
|
full_design_prop = POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN;
|
|
empty_prop = POWER_SUPPLY_PROP_VOLTAGE_MIN;
|
|
empty_design_prop = POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN;
|
|
cur_avg_prop = POWER_SUPPLY_PROP_VOLTAGE_AVG;
|
|
cur_now_prop = POWER_SUPPLY_PROP_VOLTAGE_NOW;
|
|
break;
|
|
default:
|
|
printk(KERN_ERR "Unsupported source: %d\n", source);
|
|
return -1;
|
|
}
|
|
|
|
if (_MPSY_PROP(full_prop, &full)) {
|
|
/* if battery can't report this property, use design value */
|
|
if (_MPSY_PROP(full_design_prop, &full))
|
|
return -1;
|
|
}
|
|
|
|
if (_MPSY_PROP(empty_prop, &empty)) {
|
|
/* if battery can't report this property, use design value */
|
|
if (_MPSY_PROP(empty_design_prop, &empty))
|
|
empty.intval = 0;
|
|
}
|
|
|
|
if (_MPSY_PROP(cur_avg_prop, &cur)) {
|
|
/* if battery can't report average value, use momentary */
|
|
if (_MPSY_PROP(cur_now_prop, &cur))
|
|
return -1;
|
|
}
|
|
|
|
if (status == POWER_SUPPLY_STATUS_CHARGING)
|
|
return ((cur.intval - full.intval) * 60L) / I.intval;
|
|
else
|
|
return -((cur.intval - empty.intval) * 60L) / I.intval;
|
|
}
|
|
|
|
static int calculate_time(int status)
|
|
{
|
|
int time;
|
|
|
|
time = do_calculate_time(status, SOURCE_ENERGY);
|
|
if (time != -1)
|
|
return time;
|
|
|
|
time = do_calculate_time(status, SOURCE_CHARGE);
|
|
if (time != -1)
|
|
return time;
|
|
|
|
time = do_calculate_time(status, SOURCE_VOLTAGE);
|
|
if (time != -1)
|
|
return time;
|
|
|
|
return -1;
|
|
}
|
|
|
|
static int calculate_capacity(enum apm_source source)
|
|
{
|
|
enum power_supply_property full_prop, empty_prop;
|
|
enum power_supply_property full_design_prop, empty_design_prop;
|
|
enum power_supply_property now_prop, avg_prop;
|
|
union power_supply_propval empty, full, cur;
|
|
int ret;
|
|
|
|
switch (source) {
|
|
case SOURCE_CHARGE:
|
|
full_prop = POWER_SUPPLY_PROP_CHARGE_FULL;
|
|
empty_prop = POWER_SUPPLY_PROP_CHARGE_EMPTY;
|
|
full_design_prop = POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN;
|
|
empty_design_prop = POWER_SUPPLY_PROP_CHARGE_EMPTY_DESIGN;
|
|
now_prop = POWER_SUPPLY_PROP_CHARGE_NOW;
|
|
avg_prop = POWER_SUPPLY_PROP_CHARGE_AVG;
|
|
break;
|
|
case SOURCE_ENERGY:
|
|
full_prop = POWER_SUPPLY_PROP_ENERGY_FULL;
|
|
empty_prop = POWER_SUPPLY_PROP_ENERGY_EMPTY;
|
|
full_design_prop = POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN;
|
|
empty_design_prop = POWER_SUPPLY_PROP_ENERGY_EMPTY_DESIGN;
|
|
now_prop = POWER_SUPPLY_PROP_ENERGY_NOW;
|
|
avg_prop = POWER_SUPPLY_PROP_ENERGY_AVG;
|
|
break;
|
|
case SOURCE_VOLTAGE:
|
|
full_prop = POWER_SUPPLY_PROP_VOLTAGE_MAX;
|
|
empty_prop = POWER_SUPPLY_PROP_VOLTAGE_MIN;
|
|
full_design_prop = POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN;
|
|
empty_design_prop = POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN;
|
|
now_prop = POWER_SUPPLY_PROP_VOLTAGE_NOW;
|
|
avg_prop = POWER_SUPPLY_PROP_VOLTAGE_AVG;
|
|
break;
|
|
default:
|
|
printk(KERN_ERR "Unsupported source: %d\n", source);
|
|
return -1;
|
|
}
|
|
|
|
if (_MPSY_PROP(full_prop, &full)) {
|
|
/* if battery can't report this property, use design value */
|
|
if (_MPSY_PROP(full_design_prop, &full))
|
|
return -1;
|
|
}
|
|
|
|
if (_MPSY_PROP(avg_prop, &cur)) {
|
|
/* if battery can't report average value, use momentary */
|
|
if (_MPSY_PROP(now_prop, &cur))
|
|
return -1;
|
|
}
|
|
|
|
if (_MPSY_PROP(empty_prop, &empty)) {
|
|
/* if battery can't report this property, use design value */
|
|
if (_MPSY_PROP(empty_design_prop, &empty))
|
|
empty.intval = 0;
|
|
}
|
|
|
|
if (full.intval - empty.intval)
|
|
ret = ((cur.intval - empty.intval) * 100L) /
|
|
(full.intval - empty.intval);
|
|
else
|
|
return -1;
|
|
|
|
if (ret > 100)
|
|
return 100;
|
|
else if (ret < 0)
|
|
return 0;
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void apm_battery_apm_get_power_status(struct apm_power_info *info)
|
|
{
|
|
union power_supply_propval status;
|
|
union power_supply_propval capacity, time_to_full, time_to_empty;
|
|
|
|
mutex_lock(&apm_mutex);
|
|
find_main_battery();
|
|
if (!main_battery) {
|
|
mutex_unlock(&apm_mutex);
|
|
return;
|
|
}
|
|
|
|
/* status */
|
|
|
|
if (MPSY_PROP(STATUS, &status))
|
|
status.intval = POWER_SUPPLY_STATUS_UNKNOWN;
|
|
|
|
/* ac line status */
|
|
|
|
if ((status.intval == POWER_SUPPLY_STATUS_CHARGING) ||
|
|
(status.intval == POWER_SUPPLY_STATUS_NOT_CHARGING) ||
|
|
(status.intval == POWER_SUPPLY_STATUS_FULL))
|
|
info->ac_line_status = APM_AC_ONLINE;
|
|
else
|
|
info->ac_line_status = APM_AC_OFFLINE;
|
|
|
|
/* battery life (i.e. capacity, in percents) */
|
|
|
|
if (MPSY_PROP(CAPACITY, &capacity) == 0) {
|
|
info->battery_life = capacity.intval;
|
|
} else {
|
|
/* try calculate using energy */
|
|
info->battery_life = calculate_capacity(SOURCE_ENERGY);
|
|
/* if failed try calculate using charge instead */
|
|
if (info->battery_life == -1)
|
|
info->battery_life = calculate_capacity(SOURCE_CHARGE);
|
|
if (info->battery_life == -1)
|
|
info->battery_life = calculate_capacity(SOURCE_VOLTAGE);
|
|
}
|
|
|
|
/* charging status */
|
|
|
|
if (status.intval == POWER_SUPPLY_STATUS_CHARGING) {
|
|
info->battery_status = APM_BATTERY_STATUS_CHARGING;
|
|
} else {
|
|
if (info->battery_life > 50)
|
|
info->battery_status = APM_BATTERY_STATUS_HIGH;
|
|
else if (info->battery_life > 5)
|
|
info->battery_status = APM_BATTERY_STATUS_LOW;
|
|
else
|
|
info->battery_status = APM_BATTERY_STATUS_CRITICAL;
|
|
}
|
|
info->battery_flag = info->battery_status;
|
|
|
|
/* time */
|
|
|
|
info->units = APM_UNITS_MINS;
|
|
|
|
if (status.intval == POWER_SUPPLY_STATUS_CHARGING) {
|
|
if (!MPSY_PROP(TIME_TO_FULL_AVG, &time_to_full) ||
|
|
!MPSY_PROP(TIME_TO_FULL_NOW, &time_to_full))
|
|
info->time = time_to_full.intval / 60;
|
|
else
|
|
info->time = calculate_time(status.intval);
|
|
} else {
|
|
if (!MPSY_PROP(TIME_TO_EMPTY_AVG, &time_to_empty) ||
|
|
!MPSY_PROP(TIME_TO_EMPTY_NOW, &time_to_empty))
|
|
info->time = time_to_empty.intval / 60;
|
|
else
|
|
info->time = calculate_time(status.intval);
|
|
}
|
|
|
|
mutex_unlock(&apm_mutex);
|
|
}
|
|
|
|
static int __init apm_battery_init(void)
|
|
{
|
|
printk(KERN_INFO "APM Battery Driver\n");
|
|
|
|
apm_get_power_status = apm_battery_apm_get_power_status;
|
|
return 0;
|
|
}
|
|
|
|
static void __exit apm_battery_exit(void)
|
|
{
|
|
apm_get_power_status = NULL;
|
|
}
|
|
|
|
module_init(apm_battery_init);
|
|
module_exit(apm_battery_exit);
|
|
|
|
MODULE_AUTHOR("Eugeny Boger <eugenyboger@dgap.mipt.ru>");
|
|
MODULE_DESCRIPTION("APM emulation driver for battery monitoring class");
|
|
MODULE_LICENSE("GPL");
|