Tom Rix 65b9b70561 apparmor: fix error check ... [ Upstream commit d108370c64 ] clang static analysis reports this representative problem: label.c:1463:16: warning: Assigned value is garbage or undefined label->hname = name; ^ ~~~~ In aa_update_label_name(), this the problem block of code if (aa_label_acntsxprint(&name, ...) == -1) return res; On failure, aa_label_acntsxprint() has a more complicated return that just -1. So check for a negative return. It was also noted that the aa_label_acntsxprint() main comment refers to a nonexistent parameter, so clean up the comment. Fixes: f1bd904175 ("apparmor: add the base fns() for domain labels") Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: John Johansen <john.johansen@canonical.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-11-26 11:40:34 +01:00
..
apparmor	apparmor: fix error check	2021-11-26 11:40:34 +01:00
integrity	evm: mark evm_fixmode as __ro_after_init	2021-11-26 11:40:23 +01:00
keys	KEYS: trusted: Fix migratable=1 failing	2021-03-03 18:22:52 +01:00
loadpin	security: mark LSM hooks as __ro_after_init	2017-03-06 11:00:15 +11:00
selinux	binder: use cred instead of task for selinux checks	2021-11-26 11:40:20 +01:00
smack	smackfs: use netlbl_cfg_cipsov4_del() for deleting cipso_v4_doi	2021-11-26 11:40:31 +01:00
tomoyo	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
yama	Yama: Check for pid death before checking ancestry	2019-01-23 08:09:48 +01:00
commoncap.c	security: commoncap: fix -Wstringop-overread warning	2021-05-22 10:57:21 +02:00
device_cgroup.c	device_cgroup: fix RCU imbalance in error case	2019-04-27 09:35:40 +02:00
inode.c	securityfs: fix use-after-free on symlink traversal	2019-05-25 18:25:34 +02:00
Kconfig	/dev/mem: Add bounce buffer for copy-out	2018-03-24 11:01:24 +01:00
lsm_audit.c	dump_common_audit_data(): fix racy accesses to ->d_name	2021-01-23 15:48:43 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
min_addr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
security.c	binder: use cred instead of task for selinux checks	2021-11-26 11:40:20 +01:00