Florian Westphal c90b99a6b4 netfilter: nf_tables: fix null deref due to zeroed list head ... commit 580077855a upstream. In nf_tables_updtable, if nf_tables_table_enable returns an error, nft_trans_destroy is called to free the transaction object. nft_trans_destroy() calls list_del(), but the transaction was never placed on a list -- the list head is all zeroes, this results in a null dereference: BUG: KASAN: null-ptr-deref in nft_trans_destroy+0x26/0x59 Call Trace: nft_trans_destroy+0x26/0x59 nf_tables_newtable+0x4bc/0x9bc [..] Its sane to assume that nft_trans_destroy() can be called on the transaction object returned by nft_trans_alloc(), so make sure the list head is initialised. Fixes: 55dd6f9307 ("netfilter: nf_tables: use new transaction infrastructure to handle table") Reported-by: mingi cho <mgcho.minic@gmail.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-08-17 14:40:20 +02:00
..
ipset
ipvs	ipvs: correctly print the memory size of ip_vs_conn_tab	2022-04-19 11:04:06 +02:00
core.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf	2022-03-28 08:57:10 -07:00
Kconfig
Makefile
nf_conncount.c
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_bpf.c	bpf: Replace __diag_ignore with unified __diag_ignore_all	2022-03-05 15:29:36 -08:00
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: conntrack: fix crash due to confirmed bit load reordering	2022-07-22 10:21:29 +02:00
nf_conntrack_ecache.c	netfilter: conntrack: remove the percpu dying list	2022-07-22 10:21:28 +02:00
nf_conntrack_expect.c
nf_conntrack_extend.c
nf_conntrack_ftp.c
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c	netfilter: conntrack: Add and use nf_ct_set_auto_assign_helper_warned()	2022-03-20 00:29:35 +01:00
nf_conntrack_irc.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: conntrack: fix crash due to confirmed bit load reordering	2022-07-22 10:21:29 +02:00
nf_conntrack_pptp.c
nf_conntrack_proto.c
nf_conntrack_proto_dccp.c
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c
nf_conntrack_proto_icmp.c
nf_conntrack_proto_icmpv6.c
nf_conntrack_proto_sctp.c
nf_conntrack_proto_tcp.c	netfilter: nf_conntrack_tcp: re-init for syn packets only	2022-04-27 15:48:45 +02:00
nf_conntrack_proto_udp.c	Revert "netfilter: conntrack: mark UDP zero checksum as CHECKSUM_UNNECESSARY"	2022-03-03 13:35:22 +01:00
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c
nf_conntrack_snmp.c
nf_conntrack_standalone.c	netfilter: conntrack: fix crash due to confirmed bit load reordering	2022-07-22 10:21:29 +02:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c	netfilter: nf_dup_netdev: add and use recursion counter	2022-06-29 09:04:32 +02:00
nf_flow_table_core.c	netfilter: flowtable: move dst_check to packet path	2022-05-18 17:34:26 +02:00
nf_flow_table_inet.c	netfilter: flowtable: Fix QinQ and pppoe support for inet table	2022-03-16 11:25:04 +01:00
nf_flow_table_ip.c	netfilter: flowtable: move dst_check to packet path	2022-05-18 17:34:26 +02:00
nf_flow_table_offload.c	netfilter: flowtable: remove redundant field in flow_offload_work struct	2022-03-20 00:29:47 +01:00
nf_hooks_lwtunnel.c
nf_internals.h
nf_log.c
nf_log_syslog.c	netfilter: nf_log: incorrect offset to network header	2022-07-22 10:21:33 +02:00
nf_nat_amanda.c
nf_nat_core.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-03-17 13:56:58 -07:00
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_masquerade.c
nf_nat_proto.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c	netfilter: nf_queue: handle socket prefetch	2022-03-01 11:51:15 +01:00
nf_sockopt.c
nf_synproxy_core.c	ip: Fix data-races around sysctl_ip_default_ttl.	2022-07-29 17:27:57 +02:00
nf_tables_api.c	netfilter: nf_tables: fix null deref due to zeroed list head	2022-08-17 14:40:20 +02:00
nf_tables_core.c	netfilter: nf_tables: avoid skb access on nf_stolen	2022-07-22 10:21:47 +02:00
nf_tables_offload.c	netfilter: nf_tables: bail out early if hardware offload is not supported	2022-06-14 18:45:05 +02:00
nf_tables_trace.c	netfilter: nf_tables: avoid skb access on nf_stolen	2022-07-22 10:21:47 +02:00
nfnetlink.c
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c
nfnetlink_hook.c
nfnetlink_log.c	net: Get rcv tstamp if needed in nfnetlink_{log, queue}.c	2022-03-03 14:38:48 +00:00
nfnetlink_osf.c
nfnetlink_queue.c	netfilter: nf_queue: do not allow packet truncation below transport header offset	2022-08-03 12:05:27 +02:00
nft_bitwise.c	netfilter: bitwise: fix reduce comparisons	2022-03-29 23:33:46 +02:00
nft_byteorder.c	netfilter: nf_tables: cancel tracking for clobbered destination registers	2022-03-20 00:29:46 +01:00
nft_chain_filter.c
nft_chain_nat.c
nft_chain_route.c
nft_cmp.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_compat.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_connlimit.c	netfilter: nf_tables: memcg accounting for dynamically allocated objects	2022-04-05 11:55:46 +02:00
nft_counter.c	netfilter: nf_tables: memcg accounting for dynamically allocated objects	2022-04-05 11:55:46 +02:00
nft_ct.c	netfilter: nft_ct: track register operations	2022-03-20 00:29:46 +01:00
nft_dup_netdev.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_dynset.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_exthdr.c	netfilter: nft_exthdr: add reduce support	2022-03-20 00:29:47 +01:00
nft_fib.c	netfilter: nft_fib: add reduce support	2022-03-20 00:29:47 +01:00
nft_fib_inet.c	netfilter: nft_fib: add reduce support	2022-03-20 00:29:47 +01:00
nft_fib_netdev.c	netfilter: nft_fib: add reduce support	2022-03-20 00:29:47 +01:00
nft_flow_offload.c	netfilter: flowtable: fix TCP flow teardown	2022-05-18 17:34:26 +02:00
nft_fwd_netdev.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_hash.c	netfilter: nft_hash: track register operations	2022-03-20 00:29:47 +01:00
nft_immediate.c	netfilter: nft_immediate: cancel register tracking for data destination register	2022-03-20 00:29:47 +01:00
nft_last.c	netfilter: nf_tables: memcg accounting for dynamically allocated objects	2022-04-05 11:55:46 +02:00
nft_limit.c	netfilter: nft_limit: Clone packet limits' cost value	2022-06-06 08:48:54 +02:00
nft_log.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_lookup.c	netfilter: nft_lookup: only cancel tracking for clobbered dregs	2022-03-20 00:29:46 +01:00
nft_masq.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_meta.c	netfilter: use get_random_u32 instead of prandom	2022-06-29 09:04:29 +02:00
nft_nat.c	netfilter: nat: really support inet nat without l3 address	2022-06-14 18:45:03 +02:00
nft_numgen.c	netfilter: use get_random_u32 instead of prandom	2022-06-29 09:04:29 +02:00
nft_objref.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_osf.c	netfilter: nft_osf: track register operations	2022-03-20 00:29:47 +01:00
nft_payload.c	netfilter: nf_tables: cancel tracking for clobbered destination registers	2022-03-20 00:29:46 +01:00
nft_queue.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_quota.c	netfilter: nf_tables: memcg accounting for dynamically allocated objects	2022-04-05 11:55:46 +02:00
nft_range.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_redir.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_reject.c
nft_reject_inet.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_reject_netdev.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_rt.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_set_bitmap.c
nft_set_hash.c	netfilter: nft_dynset: restore set element counter when failing to update	2022-07-07 17:54:54 +02:00
nft_set_pipapo.c	netfilter: nft_set_pipapo: release elements in clone from abort path	2022-07-12 16:42:14 +02:00
nft_set_pipapo.h
nft_set_pipapo_avx2.c
nft_set_pipapo_avx2.h
nft_set_rbtree.c	netfilter: nft_set_rbtree: overlap detection with element re-addition after deletion	2022-04-22 15:49:15 +02:00
nft_socket.c	netfilter: nft_socket: only do sk lookups when indev is available	2022-04-28 16:15:23 +02:00
nft_synproxy.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_tproxy.c	netfilter: nf_tables: do not reduce read-only expressions	2022-03-20 00:29:46 +01:00
nft_tunnel.c	netfilter: nft_tunnel: track register operations	2022-03-20 00:29:47 +01:00
nft_xfrm.c	netfilter: nft_xfrm: track register operations	2022-03-20 00:29:47 +01:00
utils.c
x_tables.c
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_HL.c
xt_hl.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_MASQUERADE.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_rateest.c
xt_RATEEST.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c
xt_socket.c	netfilter: xt_socket: missing ifdef CONFIG_IP6_NF_IPTABLES dependency	2022-02-13 23:55:48 +01:00
xt_state.c
xt_statistic.c
xt_string.c
xt_TCPMSS.c
xt_tcpmss.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c