mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
![Vinod Koul](/assets/img/avatar_default.png)
When renesas module is not built, we get compiler warning on xhci driver
with W=1
CC [M] drivers/usb/host/xhci-rcar.o
drivers/usb/host/xhci-pci.h:13:5: warning: no previous prototype for ‘renesas_xhci_check_request_fw’ [-Wmissing-prototypes]
int renesas_xhci_check_request_fw(struct pci_dev *dev,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-pci.h:19:6: warning: no previous prototype for ‘renesas_xhci_pci_exit’ [-Wmissing-prototypes]
void renesas_xhci_pci_exit(struct pci_dev *dev) { };
^~~~~~~~~~~~~~~~~~~~~
We have defined these symbols when CONFIG_USB_XHCI_PCI_RENESAS is not
defined, but missed making then static.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 8bd5741e31
("usb: renesas-xhci: Add the renesas xhci driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20200519093002.1152144-1-vkoul@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
28 lines
576 B
C
28 lines
576 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (C) 2019-2020 Linaro Limited */
|
|
|
|
#ifndef XHCI_PCI_H
|
|
#define XHCI_PCI_H
|
|
|
|
#if IS_ENABLED(CONFIG_USB_XHCI_PCI_RENESAS)
|
|
int renesas_xhci_check_request_fw(struct pci_dev *dev,
|
|
const struct pci_device_id *id);
|
|
void renesas_xhci_pci_exit(struct pci_dev *dev);
|
|
|
|
#else
|
|
static int renesas_xhci_check_request_fw(struct pci_dev *dev,
|
|
const struct pci_device_id *id)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void renesas_xhci_pci_exit(struct pci_dev *dev) { };
|
|
|
|
#endif
|
|
|
|
struct xhci_driver_data {
|
|
u64 quirks;
|
|
const char *firmware;
|
|
};
|
|
|
|
#endif
|