Eric Biggers bb4f8ead47 f2fs: fix error handling in f2fs_end_enable_verity() ... commit 3c0315424f upstream. f2fs didn't properly clean up if verity failed to be enabled on a file: - It left verity metadata (pages past EOF) in the page cache, which would be exposed to userspace if the file was later extended. - It didn't truncate the verity metadata at all (either from cache or from disk) if an error occurred while setting the verity bit. Fix these bugs by adding a call to truncate_inode_pages() and ensuring that we truncate the verity metadata (both from cache and from disk) in all error paths. Also rework the code to cleanly separate the success path from the error paths, which makes it much easier to understand. Finally, log a message if f2fs_truncate() fails, since it might otherwise fail silently. Reported-by: Yunlei He <heyunlei@hihonor.com> Fixes: 95ae251fe8 ("f2fs: add fs-verity support") Cc: <stable@vger.kernel.org> # v5.4+ Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-05-19 10:08:32 +02:00
..
9p	9P: Cast to loff_t before multiplying	2020-11-05 11:43:34 +01:00
adfs
affs	fs/affs: release old buffer head on error path	2021-03-04 10:26:48 +01:00
afs	afs: Stop listxattr() from listing "afs.*" attributes	2021-03-24 11:26:37 +01:00
autofs
befs
bfs	bfs: don't use WARNING: string when it's just info.	2021-01-06 14:48:39 +01:00
btrfs	btrfs: fix race when picking most recent mod log operation for an old root	2021-05-11 14:04:14 +02:00
cachefiles	cachefiles: Handle readpage error correctly	2020-11-05 11:43:36 +01:00
ceph	ceph: fix inode leak on getattr error in __fh_to_dentry	2021-05-19 10:08:26 +02:00
cifs	cifs: Return correct error code from smb2_get_enc_key	2021-05-11 14:04:04 +02:00
coda
configfs	configfs: fix a use-after-free in __configfs_open_file	2021-03-17 17:03:56 +01:00
cramfs
crypto	fscrypt: remove kernel-internal constants from UAPI header	2021-01-06 14:48:35 +01:00
debugfs	debugfs: do not attempt to create a new file before the filesystem is initalized	2021-03-04 10:26:10 +01:00
devpts
dlm	fs: dlm: fix debugfs dump	2021-05-19 10:08:20 +02:00
ecryptfs	ecryptfs: fix kernel panic with null dev_name	2021-05-11 14:04:02 +02:00
efivarfs	efivarfs: revert "fix memory leak in efivarfs_create()"	2020-12-02 08:49:53 +01:00
efs
erofs	erofs: add unsupported inode i_format check	2021-05-11 14:04:02 +02:00
exportfs
ext2	ext2: don't update mtime on COW faults	2020-09-09 19:12:30 +02:00
ext4	ext4: fix error code in ext4_commit_super	2021-05-11 14:04:16 +02:00
f2fs	f2fs: fix error handling in f2fs_end_enable_verity()	2021-05-19 10:08:32 +02:00
fat
freevxfs
fscache
fuse	cuse: prevent clone	2021-05-19 10:08:22 +02:00
gfs2	gfs2: report "already frozen/thawed" errors	2021-04-16 11:46:37 +02:00
hfs
hfsplus	hfsplus: prevent corruption in shrinking truncate	2021-05-19 10:08:29 +02:00
hostfs	hostfs: fix memory handling in follow_link()	2021-04-14 08:24:14 +02:00
hpfs
hugetlbfs	mm/hugetlb: fix F_SEAL_FUTURE_WRITE	2021-05-19 10:08:29 +02:00
iomap	iomap: fix sub-page uptodate handling	2021-05-19 10:08:30 +02:00
isofs	isofs: release buffer head before return	2021-03-04 10:26:30 +01:00
jbd2	jbd2: fix up sparse warnings in checkpoint code	2020-11-18 19:20:30 +01:00
jffs2	jffs2: check the validity of dstlen in jffs2_zlib_compress()	2021-05-11 14:04:16 +02:00
jfs	JFS: more checks for invalid superblock	2021-03-07 12:20:41 +01:00
kernfs	kernfs: do not call fsnotify() with name without a parent	2020-08-19 08:16:12 +02:00
lockd	lockd: don't use interval-based rebinding over TCP	2020-12-30 11:51:16 +01:00
minix	fs/minix: remove expected error message in block_to_path()	2020-08-21 13:05:37 +02:00
nfs	NFSv4.2 fix handling of sr_eof in SEEK's reply	2021-05-19 10:08:25 +02:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-30 11:51:22 +01:00
nfsd	NFSD: fix error handling in NFSv4.0 callbacks	2021-04-07 14:47:39 +02:00
nilfs2
nls
notify
ntfs	ntfs: check for valid standard information attribute	2021-02-26 10:10:27 +01:00
ocfs2	ocfs2: fix deadlock between setattr and dio_end_io_write	2021-04-14 08:24:10 +02:00
omfs
openpromfs
orangefs	orangefs: get rid of knob code...	2020-08-21 13:05:29 +02:00
overlayfs	ovl: fix missing revert_creds() on error path	2021-05-14 09:44:16 +02:00
proc	proc: fix lookup in /proc/net subdirectories after setns(2)	2021-01-12 20:16:10 +01:00
pstore	pstore: Fix typo in compression option name	2021-03-04 10:26:45 +01:00
qnx4
qnx6
quota	quota: Fix memory leak when handling corrupted quota file	2021-03-04 10:26:26 +01:00
ramfs	ramfs: fix nommu mmap with gaps in the page cache	2020-10-29 09:57:53 +01:00
reiserfs	reiserfs: update reiserfs_xattrs_initialized() condition	2021-04-07 14:47:43 +02:00
romfs	romfs: fix uninitialized memory leak in romfs_dev_read()	2020-08-26 10:40:51 +02:00
squashfs	squashfs: fix divide error in calculate_skip()	2021-05-19 10:08:29 +02:00
sysfs	sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output	2021-03-07 12:20:48 +01:00
sysv
tracefs
ubifs	ubifs: Only check replay with inode type to judge if inode linked	2021-05-11 14:04:14 +02:00
udf	udf: fix silent AED tagLocation corruption	2021-03-17 17:03:41 +01:00
ufs	fs/ufs: avoid potential u32 multiplication overflow	2020-08-21 13:05:37 +02:00
unicode
verity
xfs	xfs: Fix assert failure in xfs_setattr_size()	2021-03-07 12:20:42 +01:00
aio.c
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf.c
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c	binfmt_flat: revert "binfmt_flat: don't offset the data start"	2020-09-03 11:26:39 +02:00
binfmt_misc.c	binfmt_misc: fix possible deadlock in bm_register_write	2021-03-17 17:03:57 +01:00
binfmt_script.c
block_dev.c	block: don't ignore REQ_NOWAIT for direct IO	2021-04-16 11:46:38 +02:00
buffer.c	fs: Don't invalidate page buffers in block_write_full_page()	2020-11-05 11:43:24 +01:00
char_dev.c
compat.c
compat_binfmt_elf.c
compat_ioctl.c
coredump.c	coredump: fix core_pattern parse error	2020-12-11 13:23:30 +01:00
d_path.c	fs: fix NULL dereference due to data race in prepend_path()	2020-10-29 09:57:45 +01:00
dax.c	mm: provide a saner PTE walking API for modules	2021-02-26 10:10:28 +01:00
dcache.c	fix dget_parent() fastpath race	2020-10-01 13:17:19 +02:00
dcookies.c
direct-io.c	fs: direct-io: fix missing sdio->boundary	2021-04-14 08:24:11 +02:00
drop_caches.c
eventfd.c
eventpoll.c	ep_create_wakeup_source(): dentry name can change under you...	2020-10-07 08:01:31 +02:00
exec.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:44:55 +01:00
fcntl.c	fcntl: Fix potential deadlock in send_sig{io, urg}()	2021-01-06 14:48:39 +01:00
fhandle.c
file.c
file_table.c
filesystems.c
fs-writeback.c	fs: fix lazytime expiration handling in __writeback_single_inode()	2021-01-30 13:54:11 +01:00
fs_context.c
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
inode.c
internal.h
io_uring.c	io_uring: Fix current->fs handling in io_sq_wq_submit_work()	2021-01-30 13:54:10 +01:00
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c	libfs: fix error cast of negative value in simple_attr_write()	2020-11-24 13:29:19 +01:00
locks.c
Makefile
mbcache.c
mount.h
mpage.c
namei.c
namespace.c	fs/namespace.c: WARN if mnt_count has become negative	2021-01-06 14:48:40 +01:00
no-block.c
nsfs.c
open.c
pipe.c
pnode.c
pnode.h	mount: fix mounting of detached mounts onto targets that reside on shared mounts	2021-03-17 17:03:33 +01:00
posix_acl.c
proc_namespace.c
read_write.c
readdir.c	readdir: make sure to verify directory entry for legacy interfaces too	2021-04-21 12:56:16 +02:00
select.c	kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data()	2021-03-24 11:26:44 +01:00
seq_file.c
signalfd.c	fs/signalfd.c: fix inconsistent return codes for signalfd4	2020-08-26 10:40:58 +02:00
splice.c
stack.c
stat.c
statfs.c
super.c	vfs: remove lockdep bogosity in __sb_start_write	2020-11-24 13:29:01 +01:00
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c	xattr: break delegations in {set,remove}xattr	2020-08-11 15:33:39 +02:00