mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 00:48:50 +00:00
15ba7806c3
Like sas_printk() did previously, SAS_DPRINTK() offers little value now that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it can be dropped. However, after reviewing some logs in libsas, it is noticed that debug level is too low in many instances. So this change drops SAS_DPRINTK() and revises some logs to a more appropriate level. However many stay at debug level, although some are significantly promoted. We add -DDEBUG for compilation so that we keep the debug messages by default, as before. All the pre-existing checkpatch errors for spanning messages across multiple lines are also fixed. Finally, all other references to printk() [apart from special formatting in sas_ata.c] are removed and replaced with appropriate pr_xxx(). Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
37 lines
1 KiB
C
37 lines
1 KiB
C
|
|
#include "sas_internal.h"
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/export.h>
|
|
#include <scsi/sas.h>
|
|
#include <scsi/libsas.h>
|
|
|
|
/* fill task_status_struct based on SSP response frame */
|
|
void sas_ssp_task_response(struct device *dev, struct sas_task *task,
|
|
struct ssp_response_iu *iu)
|
|
{
|
|
struct task_status_struct *tstat = &task->task_status;
|
|
|
|
tstat->resp = SAS_TASK_COMPLETE;
|
|
|
|
if (iu->datapres == 0)
|
|
tstat->stat = iu->status;
|
|
else if (iu->datapres == 1)
|
|
tstat->stat = iu->resp_data[3];
|
|
else if (iu->datapres == 2) {
|
|
tstat->stat = SAM_STAT_CHECK_CONDITION;
|
|
tstat->buf_valid_size =
|
|
min_t(int, SAS_STATUS_BUF_SIZE,
|
|
be32_to_cpu(iu->sense_data_len));
|
|
memcpy(tstat->buf, iu->sense_data, tstat->buf_valid_size);
|
|
|
|
if (iu->status != SAM_STAT_CHECK_CONDITION)
|
|
dev_warn(dev, "dev %llx sent sense data, but stat(%x) is not CHECK CONDITION\n",
|
|
SAS_ADDR(task->dev->sas_addr), iu->status);
|
|
}
|
|
else
|
|
/* when datapres contains corrupt/unknown value... */
|
|
tstat->stat = SAM_STAT_CHECK_CONDITION;
|
|
}
|
|
EXPORT_SYMBOL_GPL(sas_ssp_task_response);
|
|
|