Kiyoshi Ueda a77e28c7e1 dm multipath: fix oops when request based io fails when no paths ... The patch posted at http://marc.info/?l=dm-devel&m=124539787228784&w=2 which was merged into cec47e3d4a ("dm: prepare for request based option") introduced a regression in request-based dm. If map_request() calls dm_kill_unmapped_request() to complete a cloned bio without dispatching it, clone->bio is still set when dm_end_request() is called and the BUG_ON(clone->bio) is incorrect. The patch fixes this bug by freeing bio in dm_end_request() if the clone has bio. I've redone my tests to cover all I/O paths and confirmed there's no other regression. Here is the oops I hit in request-based dm when I do I/O to a multipath device which doesn't have any active path nor queue_if_no_path setting: ------------[ cut here ]------------ kernel BUG at /root/2.6.31-rc4.rqdm/drivers/md/dm.c:828! invalid opcode: 0000 [#1] SMP last sysfs file: /sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_map CPU 1 Modules linked in: autofs4 sunrpc cpufreq_ondemand acpi_cpufreq dm_mirror dm_region_hash dm_log dm_service_time dm_multipath scsi_dh dm_mod video output sbs sbshc battery ac sg sr_mod e1000e button cdrom serio_raw rtc_cmos rtc_core rtc_lib piix lpfc scsi_transport_fc ata_piix libata megaraid_sas sd_mod scsi_mod crc_t10dif ext3 jbd uhci_hcd ohci_hcd ehci_hcd [last unloaded: microcode] Pid: 7, comm: ksoftirqd/1 Not tainted 2.6.31-rc4.rqdm #1 Express5800/120Lj [N8100-1417] RIP: 0010:[<ffffffffa023629d>] [<ffffffffa023629d>] dm_softirq_done+0xbd/0x100 [dm_mod] RSP: 0018:ffff8800280a1f08 EFLAGS: 00010282 RAX: ffffffffa02544e0 RBX: ffff8802aa1111d0 RCX: ffff8802aa1111e0 RDX: ffff8802ab913e70 RSI: 0000000000000000 RDI: ffff8802ab913e70 RBP: ffff8800280a1f28 R08: ffffc90005457040 R09: 0000000000000000 R10: 0000000000000001 R11: 0000000000000000 R12: 00000000fffffffb R13: ffff8802ab913e88 R14: ffff8802ab9c1438 R15: 0000000000000100 FS: 0000000000000000(0000) GS:ffff88002809e000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000003d54a98640 CR3: 000000029f0a1000 CR4: 00000000000006e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process ksoftirqd/1 (pid: 7, threadinfo ffff8802ae50e000, task ffff8802ae4f8040) Stack: ffff8800280a1f38 0000000000000020 ffffffff814f30a0 0000000000000004 <0> ffff8800280a1f58 ffffffff8116b245 ffff8800280a1f38 ffff8800280a1f38 <0> ffff8800280a1f58 0000000000000001 ffff8800280a1fa8 ffffffff810477bc Call Trace: <IRQ> [<ffffffff8116b245>] blk_done_softirq+0x75/0x90 [<ffffffff810477bc>] __do_softirq+0xcc/0x210 [<ffffffff81047170>] ? ksoftirqd+0x0/0x110 [<ffffffff8100ce7c>] call_softirq+0x1c/0x50 <EOI> [<ffffffff8100e785>] do_softirq+0x65/0xa0 [<ffffffff81047170>] ? ksoftirqd+0x0/0x110 [<ffffffff810471e0>] ksoftirqd+0x70/0x110 [<ffffffff81059559>] kthread+0x99/0xb0 [<ffffffff8100cd7a>] child_rip+0xa/0x20 [<ffffffff8100c73c>] ? restore_args+0x0/0x30 [<ffffffff810594c0>] ? kthread+0x0/0xb0 [<ffffffff8100cd70>] ? child_rip+0x0/0x20 Code: 44 89 e6 48 89 df e8 23 fb f2 e0 be 01 00 00 00 4c 89 f7 e8 f6 fd ff ff 5b 41 5c 41 5d 41 5e c9 c3 4c 89 ef e8 85 fe ff ff eb ed <0f> 0b eb fe 41 8b 85 dc 00 00 00 48 83 bb 10 01 00 00 00 89 83 RIP [<ffffffffa023629d>] dm_softirq_done+0xbd/0x100 [dm_mod] RSP <ffff8800280a1f08> ---[ end trace 16af0a1d8542da55 ]--- Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com>		2009-09-04 20:40:16 +01:00
..
accessibility
acpi	ACPI: don't free non-existent backlight in acpi video module	2009-08-28 15:17:07 -04:00
amba
ata	ata_piix: parallel scanning on PATA needs an extra locking	2009-08-31 17:25:00 -10:00
atm
auxdisplay
base	PM / Driver Core: Kill dev_pm_ops platform warning for now	2009-08-10 23:41:18 +02:00
block	mg_disk: Add missing ready status check on mg_write()	2009-07-28 08:57:33 +02:00
bluetooth
cdrom
char	tty: make sure to flush any pending work when halting the ldisc	2009-08-25 09:12:43 -07:00
clocksource	sh: CMT suspend/resume	2009-08-15 12:58:45 +09:00
connector
cpufreq	[CPUFREQ] Make cpufreq suspend code conditional on powerpc.	2009-08-04 14:32:11 -04:00
cpuidle
crypto
dca
dio
dma	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx	2009-07-30 16:46:31 -07:00
edac	amd64_edac: print debug statements only on error	2009-08-04 12:10:06 +02:00
eisa
firewire
firmware
gpio
gpu	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel	2009-08-31 17:22:10 -10:00
hid
hwmon	hwmon: (asus_atk0110) Fix upper limit readings	2009-07-28 16:31:39 +02:00
i2c	i2c-stu300: I2C STU300 stability updates	2009-08-20 22:27:58 +01:00
ide
idle
ieee1394
ieee802154
infiniband
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2009-08-24 12:25:27 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2009-08-04 15:38:34 -07:00
leds	leds: after setting inverted attribute, we must update the LED	2009-08-26 20:06:53 -07:00
lguest	lguest and virtio: cleanup struct definitions to Linux style.	2009-07-30 16:03:46 +09:30
macintosh	m68k: count can reach 51, not 50	2009-08-26 23:14:49 +02:00
mca
md	dm multipath: fix oops when request based io fails when no paths	2009-09-04 20:40:16 +01:00
media	V4L/DVB (12502): gspca - sn9c20x: Fix gscpa sn9c20x build errors.	2009-08-31 02:24:54 -03:00
memstick
message
mfd	mfd: twl4030 irq fixes	2009-08-04 20:31:32 +02:00
misc	cb710: use SG_MITER_TO_SG/SG_MITER_FROM_SG	2009-07-31 12:28:46 +02:00
mmc	drivers/mmc: correct error-handling code	2009-08-07 10:39:56 -07:00
mtd	[ARM] Orion NAND: Make asm volatile avoid GCC pushing ldrd out of the loop	2009-08-24 11:56:00 -04:00
net	virtio: net refill on out-of-memory	2009-08-26 12:22:32 -07:00
nubus
of
oprofile
parisc	parisc: hppb.c - fix printk format strings	2009-08-02 15:42:39 +02:00
parport
pci	PCI: check saved state before restore	2009-08-20 09:08:45 -07:00
pcmcia
platform	toshiba_acpi: return on a fail path	2009-08-28 15:17:07 -04:00
pnp
power	Merge git://git.infradead.org/users/cbou/battery-2.6.31	2009-07-30 16:45:53 -07:00
pps	pps: fix incorrect verdict check	2009-08-26 20:06:52 -07:00
ps3
rapidio
regulator
rtc	rtc: mark if rtc-cmos drivers were successfully registered	2009-07-29 19:10:35 -07:00
s390	[S390] drivers/s390: put NULL test before dereference	2009-08-23 18:10:00 +02:00
sbus
scsi	[SCSI] mpt2sas: fix config request and diag reset deadlock	2009-08-14 09:16:05 -05:00
serial	ARM: S3C64XX: serial: Fix a typo in Kconfig	2009-08-14 00:43:46 +01:00
sh
sn
spi	spi_s3c24xx: fix transfer setup code	2009-08-18 16:31:13 -07:00
ssb
staging	Staging: rspiusb: Fix buffer overflow	2009-08-07 16:12:03 -07:00
tc
telephony
thermal	thermal_sys: check get_temp return value	2009-08-26 20:06:52 -07:00
uio
usb	USB: fix oops on disconnect in cdc-acm	2009-08-07 16:05:14 -07:00
uwb
video	xenfb: connect to backend before registering fb	2009-08-27 12:31:18 -07:00
virtio	virtio: refactor find_vqs	2009-07-30 16:03:45 +09:30
vlynq
w1	drivers/w1/masters/omap_hdq.c: fix missing mutex unlock	2009-08-07 10:39:55 -07:00
watchdog	[WATCHDOG] ar7_wdt: fix path to ar7-specific headers	2009-08-15 13:05:01 +00:00
xen
zorro
Kconfig
Makefile