Frank Wunderlich cb9a9d5fe6 iommu: Check if group is NULL before remove device ... [ Upstream commit 5aa95d8834 ] If probe_device is failing, iommu_group is not initialized because iommu_group_add_device is not reached, so freeing it will result in NULL pointer access. iommu_bus_init ->bus_iommu_probe ->probe_iommu_group in for each:/* return -22 in fail case */ ->iommu_probe_device ->__iommu_probe_device /* return -22 here.*/ -> ops->probe_device /* return -22 here.*/ -> iommu_group_get_for_dev -> ops->device_group -> iommu_group_add_device //good case ->remove_iommu_group //in fail case, it will remove group ->iommu_release_device ->iommu_group_remove_device // here we don't have group In my case ops->probe_device (mtk_iommu_probe_device from mtk_iommu_v1.c) is due to failing fwspec->ops mismatch. Fixes: d72e31c937 ("iommu: IOMMU Groups") Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Link: https://lore.kernel.org/r/20210731074737.4573-1-linux@fw-web.de Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-08-26 08:36:15 -04:00
..
amd_iommu.c	iommu/amd: Fix sleeping in atomic in increase_address_space()	2021-03-11 14:06:49 +01:00
amd_iommu.h
amd_iommu_debugfs.c
amd_iommu_init.c	iommu/amd: Remove performance counter pre-initialization test	2021-05-19 10:08:22 +02:00
amd_iommu_proto.h
amd_iommu_quirks.c
amd_iommu_types.h	iommu/amd: Set DTE[IntTabLen] to represent 512 IRTEs	2020-12-11 13:23:31 +01:00
amd_iommu_v2.c	iommu/amd: Do not use IOMMUv2 functionality when SME is active	2020-09-17 13:47:49 +02:00
arm-smmu-impl.c
arm-smmu-v3.c
arm-smmu.c	iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation	2021-07-20 16:10:44 +02:00
arm-smmu.h
dma-iommu.c	iommu/dma: Fix compile warning in 32-bit builds	2021-07-14 16:53:48 +02:00
dmar.c	iommu/vt-d: Fix sysfs leak in alloc_iommu()	2021-06-03 08:59:00 +02:00
exynos-iommu.c	iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()	2020-10-07 08:01:28 +02:00
fsl_pamu.c
fsl_pamu.h
fsl_pamu_domain.c
fsl_pamu_domain.h
hyperv-iommu.c	irqdomain/treewide: Keep firmware node unconditionally allocated	2020-07-29 10:18:28 +02:00
intel-iommu-debugfs.c
intel-iommu.c	iommu/vt-d: Fix agaw for a supported 48 bit guest address width	2021-08-18 08:57:04 +02:00
intel-pasid.c
intel-pasid.h
intel-svm.c	iommu/vt-d: Fix unaligned addresses for intel_flush_svm_range_dev()	2021-01-19 18:26:18 +01:00
intel-trace.c
intel_irq_remapping.c	iommu/intel: Fix memleak in intel_irq_remapping_alloc	2021-01-17 14:05:37 +01:00
io-pgtable-arm-v7s.c
io-pgtable-arm.c
io-pgtable.c
iommu-debugfs.c
iommu-sysfs.c
iommu-traces.c
iommu.c	iommu: Check if group is NULL before remove device	2021-08-26 08:36:15 -04:00
iova.c	iommu/iova: Don't BUG on invalid PFNs	2020-09-03 11:26:43 +02:00
ipmmu-vmsa.c
irq_remapping.c
irq_remapping.h
Kconfig	iommu/amd: Use cmpxchg_double() when updating 128-bit IRTE	2020-09-26 18:03:15 +02:00
Makefile
msm_iommu.c
msm_iommu.h
msm_iommu_hw-8xxx.h
mtk_iommu.c
mtk_iommu.h
mtk_iommu_v1.c
of_iommu.c
omap-iommu-debug.c	iommu/omap: Check for failure of a call to omap_iommu_dump_ctx	2020-08-21 13:05:33 +02:00
omap-iommu.c
omap-iommu.h
omap-iopgtable.h
qcom_iommu.c
rockchip-iommu.c
s390-iommu.c
tegra-gart.c
tegra-smmu.c
virtio-iommu.c	iommu/virtio: Reverse arguments to list_add	2020-05-14 07:58:29 +02:00