Adrian Hunter a8bbb4c264 perf build-id: Fix caching files with a wrong build ID ... commit ab66fdace8 upstream. Build ID events associate a file name with a build ID. However, when using perf inject, there is no guarantee that the file on the current machine at the current time has that build ID. Fix by comparing the build IDs and skip adding to the cache if they are different. Example: $ echo "int main() {return 0;}" > prog.c $ gcc -o prog prog.c $ perf record --buildid-all ./prog [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.019 MB perf.data ] $ file-buildid() { file $1 | awk -F= '{print $2}' | awk -F, '{print $1}' ; } $ file-buildid prog 444ad9be165d8058a48ce2ffb4e9f55854a3293e $ file-buildid ~/.debug/$(pwd)/prog/444ad9be165d8058a48ce2ffb4e9f55854a3293e/elf 444ad9be165d8058a48ce2ffb4e9f55854a3293e $ echo "int main() {return 1;}" > prog.c $ gcc -o prog prog.c $ file-buildid prog 885524d5aaa24008a3e2b06caa3ea95d013c0fc5 Before: $ perf buildid-cache --purge $(pwd)/prog $ perf inject -i perf.data -o junk $ file-buildid ~/.debug/$(pwd)/prog/444ad9be165d8058a48ce2ffb4e9f55854a3293e/elf 885524d5aaa24008a3e2b06caa3ea95d013c0fc5 $ After: $ perf buildid-cache --purge $(pwd)/prog $ perf inject -i perf.data -o junk $ file-buildid ~/.debug/$(pwd)/prog/444ad9be165d8058a48ce2ffb4e9f55854a3293e/elf $ Fixes: 454c407ec1 ("perf: add perf-inject builtin") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Tom Zanussi <tzanussi@gmail.com> Link: https://lore.kernel.org/r/20220621125144.5623-1-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-06-29 09:03:31 +02:00
..
arch	perf regs x86: Fix arch__intr_reg_mask() for the hybrid platform	2022-05-25 09:57:34 +02:00
bench	perf bench numa: Address compiler error on s390	2022-05-25 09:57:34 +02:00
dlfilters
Documentation
examples/bpf
include
jvmti
pmu-events	perf jevents: Fix event syntax error caused by ExtSel	2022-06-09 10:23:16 +02:00
python
scripts	perf scripts python: intel-pt-events.py: Fix printing of switch events	2022-01-05 12:42:40 +01:00
tests	perf tests: Remove bash construct from record+zstd_comp_decomp.sh	2021-11-25 09:48:33 +01:00
trace
ui	perf annotate: Avoid TUI crash when navigating in the annotation of recursive functions	2022-01-20 09:13:15 +01:00
util	perf build-id: Fix caching files with a wrong build ID	2022-06-29 09:03:31 +02:00
.gitignore
Build
builtin-annotate.c
builtin-bench.c
builtin-buildid-cache.c
builtin-buildid-list.c
builtin-c2c.c	perf c2c: Fix sorting in percent_rmt_hitm_cmp()	2022-06-14 18:36:13 +02:00
builtin-config.c
builtin-daemon.c
builtin-data.c
builtin-diff.c
builtin-evlist.c
builtin-ftrace.c
builtin-help.c
builtin-inject.c	perf inject: Fix segfault due to perf_data__fd() without open	2021-12-22 09:32:48 +01:00
builtin-kallsyms.c
builtin-kmem.c
builtin-kvm.c
builtin-list.c
builtin-lock.c
builtin-mem.c
builtin-probe.c
builtin-record.c
builtin-report.c	perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE event	2022-04-27 14:38:59 +02:00
builtin-sched.c
builtin-script.c	perf script: Always allow field 'data_src' for auxtrace	2022-04-27 14:38:59 +02:00
builtin-stat.c	perf stat: Fix forked applications enablement of counters	2022-04-08 14:23:51 +02:00
builtin-timechart.c
builtin-top.c
builtin-trace.c
builtin-version.c
builtin.h
check-headers.sh
command-list.txt
CREDITS
design.txt
Makefile
Makefile.config	perf tools: Use Python devtools for version autodetection rather than runtime	2022-06-09 10:22:53 +02:00
Makefile.perf	perf build: Suppress 'rm dlfilter' build message	2021-10-31 12:51:41 -03:00
MANIFEST
perf-archive.sh
perf-completion.sh
perf-iostat.sh
perf-read-vdso.c
perf-sys.h
perf-with-kcore.sh
perf.c	perf tools: Fix perf's libperf_print callback	2022-04-13 20:59:20 +02:00
perf.h