mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
![YueHaibing](/assets/img/avatar_default.png)
Syzkaller report this: BUG: unable to handle kernel paging request at fffffbfff830524b PGD 237fe8067 P4D 237fe8067 PUD 237e64067 PMD 1c9716067 PTE 0 Oops: 0000 [#1] SMP KASAN PTI CPU: 1 PID: 4465 Comm: syz-executor.0 Not tainted 5.0.0+ #5 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 RIP: 0010:__list_add_valid+0x21/0xe0 lib/list_debug.c:23 Code: 8b 0c 24 e9 17 fd ff ff 90 55 48 89 fd 48 8d 7a 08 53 48 89 d3 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 48 83 ec 08 <80> 3c 02 00 0f 85 8b 00 00 00 48 8b 53 08 48 39 f2 75 35 48 89 f2 RSP: 0018:ffff8881ea2278d0 EFLAGS: 00010282 RAX: dffffc0000000000 RBX: ffffffffc1829250 RCX: 1ffff1103d444ef4 RDX: 1ffffffff830524b RSI: ffffffff85659300 RDI: ffffffffc1829258 RBP: ffffffffc1879250 R08: fffffbfff0acb269 R09: fffffbfff0acb269 R10: ffff8881ea2278f0 R11: fffffbfff0acb268 R12: ffffffffc1829250 R13: dffffc0000000000 R14: 0000000000000008 R15: ffffffffc187c830 FS: 00007fe0361df700(0000) GS:ffff8881f7300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: fffffbfff830524b CR3: 00000001eb39a001 CR4: 00000000007606e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: __list_add include/linux/list.h:60 [inline] list_add include/linux/list.h:79 [inline] proto_register+0x444/0x8f0 net/core/sock.c:3375 nr_proto_init+0x73/0x4b3 [netrom] ? 0xffffffffc1628000 ? 0xffffffffc1628000 do_one_initcall+0xbc/0x47d init/main.c:887 do_init_module+0x1b5/0x547 kernel/module.c:3456 load_module+0x6405/0x8c10 kernel/module.c:3804 __do_sys_finit_module+0x162/0x190 kernel/module.c:3898 do_syscall_64+0x9f/0x450 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x462e99 Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe0361dec58 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 000000000073bf00 RCX: 0000000000462e99 RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000003 RBP: 00007fe0361dec70 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe0361df6bc R13: 00000000004bcefa R14: 00000000006f6fb0 R15: 0000000000000004 Modules linked in: netrom(+) ax25 fcrypt pcbc af_alg arizona_ldo1 v4l2_common videodev media v4l2_dv_timings hdlc ide_cd_mod snd_soc_sigmadsp_regmap snd_soc_sigmadsp intel_spi_platform intel_spi mtd spi_nor snd_usbmidi_lib usbcore lcd ti_ads7950 hi6421_regulator snd_soc_kbl_rt5663_max98927 snd_soc_hdac_hdmi snd_hda_ext_core snd_hda_core snd_soc_rt5663 snd_soc_core snd_pcm_dmaengine snd_compress snd_soc_rl6231 mac80211 rtc_rc5t583 spi_slave_time leds_pwm hid_gt683r hid industrialio_triggered_buffer kfifo_buf industrialio ir_kbd_i2c rc_core led_class_flash dwc_xlgmac snd_ymfpci gameport snd_mpu401_uart snd_rawmidi snd_ac97_codec snd_pcm ac97_bus snd_opl3_lib snd_timer snd_seq_device snd_hwdep snd soundcore iptable_security iptable_raw iptable_mangle iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_vti ip_gre ipip sit tunnel4 ip_tunnel hsr veth netdevsim vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon dummy team bonding vcan bridge stp llc ip6_gre gre ip6_tunnel tunnel6 tun joydev mousedev ppdev tpm kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel ide_pci_generic piix aesni_intel aes_x86_64 crypto_simd cryptd glue_helper ide_core psmouse input_leds i2c_piix4 serio_raw intel_agp intel_gtt ata_generic agpgart pata_acpi parport_pc rtc_cmos parport floppy sch_fq_codel ip_tables x_tables sha1_ssse3 sha1_generic ipv6 [last unloaded: rxrpc] Dumping ftrace buffer: (ftrace buffer empty) CR2: fffffbfff830524b ---[ end trace 039ab24b305c4b19 ]--- If nr_proto_init failed, it may forget to call proto_unregister, tiggering this issue.This patch rearrange code of nr_proto_init to avoid such issues. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
272 lines
7.7 KiB
C
272 lines
7.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Declarations of NET/ROM type objects.
|
|
*
|
|
* Jonathan Naylor G4KLX 9/4/95
|
|
*/
|
|
|
|
#ifndef _NETROM_H
|
|
#define _NETROM_H
|
|
|
|
#include <linux/netrom.h>
|
|
#include <linux/list.h>
|
|
#include <linux/slab.h>
|
|
#include <net/sock.h>
|
|
#include <linux/refcount.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#define NR_NETWORK_LEN 15
|
|
#define NR_TRANSPORT_LEN 5
|
|
|
|
#define NR_PROTO_IP 0x0C
|
|
|
|
#define NR_PROTOEXT 0x00
|
|
#define NR_CONNREQ 0x01
|
|
#define NR_CONNACK 0x02
|
|
#define NR_DISCREQ 0x03
|
|
#define NR_DISCACK 0x04
|
|
#define NR_INFO 0x05
|
|
#define NR_INFOACK 0x06
|
|
#define NR_RESET 0x07
|
|
|
|
#define NR_CHOKE_FLAG 0x80
|
|
#define NR_NAK_FLAG 0x40
|
|
#define NR_MORE_FLAG 0x20
|
|
|
|
/* Define Link State constants. */
|
|
enum {
|
|
NR_STATE_0,
|
|
NR_STATE_1,
|
|
NR_STATE_2,
|
|
NR_STATE_3
|
|
};
|
|
|
|
#define NR_COND_ACK_PENDING 0x01
|
|
#define NR_COND_REJECT 0x02
|
|
#define NR_COND_PEER_RX_BUSY 0x04
|
|
#define NR_COND_OWN_RX_BUSY 0x08
|
|
|
|
#define NR_DEFAULT_T1 120000 /* Outstanding frames - 120 seconds */
|
|
#define NR_DEFAULT_T2 5000 /* Response delay - 5 seconds */
|
|
#define NR_DEFAULT_N2 3 /* Number of Retries - 3 */
|
|
#define NR_DEFAULT_T4 180000 /* Busy Delay - 180 seconds */
|
|
#define NR_DEFAULT_IDLE 0 /* No Activity Timeout - none */
|
|
#define NR_DEFAULT_WINDOW 4 /* Default Window Size - 4 */
|
|
#define NR_DEFAULT_OBS 6 /* Default Obsolescence Count - 6 */
|
|
#define NR_DEFAULT_QUAL 10 /* Default Neighbour Quality - 10 */
|
|
#define NR_DEFAULT_TTL 16 /* Default Time To Live - 16 */
|
|
#define NR_DEFAULT_ROUTING 1 /* Is routing enabled ? */
|
|
#define NR_DEFAULT_FAILS 2 /* Link fails until route fails */
|
|
#define NR_DEFAULT_RESET 0 /* Sent / accept reset cmds? */
|
|
|
|
#define NR_MODULUS 256
|
|
#define NR_MAX_WINDOW_SIZE 127 /* Maximum Window Allowable - 127 */
|
|
#define NR_MAX_PACKET_SIZE 236 /* Maximum Packet Length - 236 */
|
|
|
|
struct nr_sock {
|
|
struct sock sock;
|
|
ax25_address user_addr, source_addr, dest_addr;
|
|
struct net_device *device;
|
|
unsigned char my_index, my_id;
|
|
unsigned char your_index, your_id;
|
|
unsigned char state, condition, bpqext, window;
|
|
unsigned short vs, vr, va, vl;
|
|
unsigned char n2, n2count;
|
|
unsigned long t1, t2, t4, idle;
|
|
unsigned short fraglen;
|
|
struct timer_list t1timer;
|
|
struct timer_list t2timer;
|
|
struct timer_list t4timer;
|
|
struct timer_list idletimer;
|
|
struct sk_buff_head ack_queue;
|
|
struct sk_buff_head reseq_queue;
|
|
struct sk_buff_head frag_queue;
|
|
};
|
|
|
|
#define nr_sk(sk) ((struct nr_sock *)(sk))
|
|
|
|
struct nr_neigh {
|
|
struct hlist_node neigh_node;
|
|
ax25_address callsign;
|
|
ax25_digi *digipeat;
|
|
ax25_cb *ax25;
|
|
struct net_device *dev;
|
|
unsigned char quality;
|
|
unsigned char locked;
|
|
unsigned short count;
|
|
unsigned int number;
|
|
unsigned char failed;
|
|
refcount_t refcount;
|
|
};
|
|
|
|
struct nr_route {
|
|
unsigned char quality;
|
|
unsigned char obs_count;
|
|
struct nr_neigh *neighbour;
|
|
};
|
|
|
|
struct nr_node {
|
|
struct hlist_node node_node;
|
|
ax25_address callsign;
|
|
char mnemonic[7];
|
|
unsigned char which;
|
|
unsigned char count;
|
|
struct nr_route routes[3];
|
|
refcount_t refcount;
|
|
spinlock_t node_lock;
|
|
};
|
|
|
|
/*********************************************************************
|
|
* nr_node & nr_neigh lists, refcounting and locking
|
|
*********************************************************************/
|
|
|
|
#define nr_node_hold(__nr_node) \
|
|
refcount_inc(&((__nr_node)->refcount))
|
|
|
|
static __inline__ void nr_node_put(struct nr_node *nr_node)
|
|
{
|
|
if (refcount_dec_and_test(&nr_node->refcount)) {
|
|
kfree(nr_node);
|
|
}
|
|
}
|
|
|
|
#define nr_neigh_hold(__nr_neigh) \
|
|
refcount_inc(&((__nr_neigh)->refcount))
|
|
|
|
static __inline__ void nr_neigh_put(struct nr_neigh *nr_neigh)
|
|
{
|
|
if (refcount_dec_and_test(&nr_neigh->refcount)) {
|
|
if (nr_neigh->ax25)
|
|
ax25_cb_put(nr_neigh->ax25);
|
|
kfree(nr_neigh->digipeat);
|
|
kfree(nr_neigh);
|
|
}
|
|
}
|
|
|
|
/* nr_node_lock and nr_node_unlock also hold/put the node's refcounter.
|
|
*/
|
|
static __inline__ void nr_node_lock(struct nr_node *nr_node)
|
|
{
|
|
nr_node_hold(nr_node);
|
|
spin_lock_bh(&nr_node->node_lock);
|
|
}
|
|
|
|
static __inline__ void nr_node_unlock(struct nr_node *nr_node)
|
|
{
|
|
spin_unlock_bh(&nr_node->node_lock);
|
|
nr_node_put(nr_node);
|
|
}
|
|
|
|
#define nr_neigh_for_each(__nr_neigh, list) \
|
|
hlist_for_each_entry(__nr_neigh, list, neigh_node)
|
|
|
|
#define nr_neigh_for_each_safe(__nr_neigh, node2, list) \
|
|
hlist_for_each_entry_safe(__nr_neigh, node2, list, neigh_node)
|
|
|
|
#define nr_node_for_each(__nr_node, list) \
|
|
hlist_for_each_entry(__nr_node, list, node_node)
|
|
|
|
#define nr_node_for_each_safe(__nr_node, node2, list) \
|
|
hlist_for_each_entry_safe(__nr_node, node2, list, node_node)
|
|
|
|
|
|
/*********************************************************************/
|
|
|
|
/* af_netrom.c */
|
|
extern int sysctl_netrom_default_path_quality;
|
|
extern int sysctl_netrom_obsolescence_count_initialiser;
|
|
extern int sysctl_netrom_network_ttl_initialiser;
|
|
extern int sysctl_netrom_transport_timeout;
|
|
extern int sysctl_netrom_transport_maximum_tries;
|
|
extern int sysctl_netrom_transport_acknowledge_delay;
|
|
extern int sysctl_netrom_transport_busy_delay;
|
|
extern int sysctl_netrom_transport_requested_window_size;
|
|
extern int sysctl_netrom_transport_no_activity_timeout;
|
|
extern int sysctl_netrom_routing_control;
|
|
extern int sysctl_netrom_link_fails_count;
|
|
extern int sysctl_netrom_reset_circuit;
|
|
|
|
int nr_rx_frame(struct sk_buff *, struct net_device *);
|
|
void nr_destroy_socket(struct sock *);
|
|
|
|
/* nr_dev.c */
|
|
int nr_rx_ip(struct sk_buff *, struct net_device *);
|
|
void nr_setup(struct net_device *);
|
|
|
|
/* nr_in.c */
|
|
int nr_process_rx_frame(struct sock *, struct sk_buff *);
|
|
|
|
/* nr_loopback.c */
|
|
void nr_loopback_init(void);
|
|
void nr_loopback_clear(void);
|
|
int nr_loopback_queue(struct sk_buff *);
|
|
|
|
/* nr_out.c */
|
|
void nr_output(struct sock *, struct sk_buff *);
|
|
void nr_send_nak_frame(struct sock *);
|
|
void nr_kick(struct sock *);
|
|
void nr_transmit_buffer(struct sock *, struct sk_buff *);
|
|
void nr_establish_data_link(struct sock *);
|
|
void nr_enquiry_response(struct sock *);
|
|
void nr_check_iframes_acked(struct sock *, unsigned short);
|
|
|
|
/* nr_route.c */
|
|
void nr_rt_device_down(struct net_device *);
|
|
struct net_device *nr_dev_first(void);
|
|
struct net_device *nr_dev_get(ax25_address *);
|
|
int nr_rt_ioctl(unsigned int, void __user *);
|
|
void nr_link_failed(ax25_cb *, int);
|
|
int nr_route_frame(struct sk_buff *, ax25_cb *);
|
|
extern const struct seq_operations nr_node_seqops;
|
|
extern const struct seq_operations nr_neigh_seqops;
|
|
void nr_rt_free(void);
|
|
|
|
/* nr_subr.c */
|
|
void nr_clear_queues(struct sock *);
|
|
void nr_frames_acked(struct sock *, unsigned short);
|
|
void nr_requeue_frames(struct sock *);
|
|
int nr_validate_nr(struct sock *, unsigned short);
|
|
int nr_in_rx_window(struct sock *, unsigned short);
|
|
void nr_write_internal(struct sock *, int);
|
|
|
|
void __nr_transmit_reply(struct sk_buff *skb, int mine, unsigned char cmdflags);
|
|
|
|
/*
|
|
* This routine is called when a Connect Acknowledge with the Choke Flag
|
|
* set is needed to refuse a connection.
|
|
*/
|
|
#define nr_transmit_refusal(skb, mine) \
|
|
do { \
|
|
__nr_transmit_reply((skb), (mine), NR_CONNACK | NR_CHOKE_FLAG); \
|
|
} while (0)
|
|
|
|
/*
|
|
* This routine is called when we don't have a circuit matching an incoming
|
|
* NET/ROM packet. This is an G8PZT Xrouter extension.
|
|
*/
|
|
#define nr_transmit_reset(skb, mine) \
|
|
do { \
|
|
__nr_transmit_reply((skb), (mine), NR_RESET); \
|
|
} while (0)
|
|
|
|
void nr_disconnect(struct sock *, int);
|
|
|
|
/* nr_timer.c */
|
|
void nr_init_timers(struct sock *sk);
|
|
void nr_start_heartbeat(struct sock *);
|
|
void nr_start_t1timer(struct sock *);
|
|
void nr_start_t2timer(struct sock *);
|
|
void nr_start_t4timer(struct sock *);
|
|
void nr_start_idletimer(struct sock *);
|
|
void nr_stop_heartbeat(struct sock *);
|
|
void nr_stop_t1timer(struct sock *);
|
|
void nr_stop_t2timer(struct sock *);
|
|
void nr_stop_t4timer(struct sock *);
|
|
void nr_stop_idletimer(struct sock *);
|
|
int nr_t1timer_running(struct sock *);
|
|
|
|
/* sysctl_net_netrom.c */
|
|
int nr_register_sysctl(void);
|
|
void nr_unregister_sysctl(void);
|
|
|
|
#endif
|