mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
![Guenter Roeck](/assets/img/avatar_default.png)
[ Upstream commit 11bca0a83f
]
An interrupt storm on a bad interrupt will cause the kernel
log to be clogged.
[ 60.089234] ->handle_irq(): ffffffffbe2f803f,
[ 60.090455] 0xffffffffbf2af380
[ 60.090510] handle_bad_irq+0x0/0x2e5
[ 60.090522] ->irq_data.chip(): ffffffffbf2af380,
[ 60.090553] IRQ_NOPROBE set
[ 60.090584] ->handle_irq(): ffffffffbe2f803f,
[ 60.090590] handle_bad_irq+0x0/0x2e5
[ 60.090596] ->irq_data.chip(): ffffffffbf2af380,
[ 60.090602] 0xffffffffbf2af380
[ 60.090608] ->action(): (null)
[ 60.090779] handle_bad_irq+0x0/0x2e5
This was seen when running an upstream kernel on Acer Chromebook R11. The
system was unstable as result.
Guard the log message with __printk_ratelimit to reduce the impact. This
won't prevent the interrupt storm from happening, but at least the system
remains stable.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Dmitry Torokhov <dtor@chromium.org>
Cc: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=197953
Link: https://lkml.kernel.org/r/1512234784-21038-1-git-send-email-linux@roeck-us.net
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Debugging printout:
|
|
*/
|
|
|
|
#include <linux/kallsyms.h>
|
|
|
|
#define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
|
|
#define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
|
|
/* FIXME */
|
|
#define ___PD(f) do { } while (0)
|
|
|
|
static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
|
|
{
|
|
static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 5);
|
|
|
|
if (!__ratelimit(&ratelimit))
|
|
return;
|
|
|
|
printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
|
|
irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
|
|
printk("->handle_irq(): %p, ", desc->handle_irq);
|
|
print_symbol("%s\n", (unsigned long)desc->handle_irq);
|
|
printk("->irq_data.chip(): %p, ", desc->irq_data.chip);
|
|
print_symbol("%s\n", (unsigned long)desc->irq_data.chip);
|
|
printk("->action(): %p\n", desc->action);
|
|
if (desc->action) {
|
|
printk("->action->handler(): %p, ", desc->action->handler);
|
|
print_symbol("%s\n", (unsigned long)desc->action->handler);
|
|
}
|
|
|
|
___P(IRQ_LEVEL);
|
|
___P(IRQ_PER_CPU);
|
|
___P(IRQ_NOPROBE);
|
|
___P(IRQ_NOREQUEST);
|
|
___P(IRQ_NOTHREAD);
|
|
___P(IRQ_NOAUTOEN);
|
|
|
|
___PS(IRQS_AUTODETECT);
|
|
___PS(IRQS_REPLAY);
|
|
___PS(IRQS_WAITING);
|
|
___PS(IRQS_PENDING);
|
|
|
|
___PD(IRQS_INPROGRESS);
|
|
___PD(IRQS_DISABLED);
|
|
___PD(IRQS_MASKED);
|
|
}
|
|
|
|
#undef ___P
|
|
#undef ___PS
|
|
#undef ___PD
|