mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
![Maarten Lankhorst](/assets/img/avatar_default.png)
op 08-10-13 18:58, Thomas Hellstrom schreef: > On 10/08/2013 06:47 PM, Jerome Glisse wrote: >> On Tue, Oct 08, 2013 at 06:29:35PM +0200, Thomas Hellstrom wrote: >>> On 10/08/2013 04:55 PM, Jerome Glisse wrote: >>>> On Tue, Oct 08, 2013 at 04:45:18PM +0200, Christian König wrote: >>>>> Am 08.10.2013 16:33, schrieb Jerome Glisse: >>>>>> On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote: >>>>>>> Allocate and copy all kernel memory before doing reservations. This prevents a locking >>>>>>> inversion between mmap_sem and reservation_class, and allows us to drop the trylocking >>>>>>> in ttm_bo_vm_fault without upsetting lockdep. >>>>>>> >>>>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> >>>>>> I would say NAK. Current code only allocate temporary page in AGP case. >>>>>> So AGP case is userspace -> temp page -> cs checker -> radeon ib. >>>>>> >>>>>> Non AGP is directly memcpy to radeon IB. >>>>>> >>>>>> Your patch allocate memory memcpy userspace to it and it will then be >>>>>> memcpy to IB. Which means you introduce an extra memcpy in the process >>>>>> not something we want. >>>>> Totally agree. Additional to that there is no good reason to provide >>>>> anything else than anonymous system memory to the CS ioctl, so the >>>>> dependency between the mmap_sem and reservations are not really >>>>> clear to me. >>>>> >>>>> Christian. >>>> I think is that in other code path you take mmap_sem first then reserve >>>> bo. But here we reserve bo and then we take mmap_sem because of copy >>> >from user. >>>> Cheers, >>>> Jerome >>>> >>> Actually the log message is a little confusing. I think the mmap_sem >>> locking inversion problem is orthogonal to what's being fixed here. >>> >>> This patch fixes the possible recursive bo::reserve caused by >>> malicious user-space handing a pointer to ttm memory so that the ttm >>> fault handler is called when bos are already reserved. That may >>> cause a (possibly interruptible) livelock. >>> >>> Once that is fixed, we are free to choose the mmap_sem -> >>> bo::reserve locking order. Currently it's bo::reserve->mmap_sem(), >>> but the hack required in the ttm fault handler is admittedly a bit >>> ugly. The plan is to change the locking order to >>> mmap_sem->bo::reserve >>> >>> I'm not sure if it applies to this particular case, but it should be >>> possible to make sure that copy_from_user_inatomic() will always >>> succeed, by making sure the pages are present using >>> get_user_pages(), and release the pages after >>> copy_from_user_inatomic() is done. That way there's no need for a >>> double memcpy slowpath, but if the copied data is very fragmented I >>> guess the resulting code may look ugly. The get_user_pages() >>> function will return an error if it hits TTM pages. >>> >>> /Thomas >> get_user_pages + copy_from_user_inatomic is overkill. We should just >> do get_user_pages which fails with ttm memory and then use copy_highpage >> helper. >> >> Cheers, >> Jerome > Yeah, it may well be that that's the preferred solution. > > /Thomas > I still disagree, and shuffled radeon_ib_get around to be called sooner. How does the patch below look? 8<------- Allocate and copy all kernel memory before doing reservations. This prevents a locking inversion between mmap_sem and reservation_class, and allows us to drop the trylocking in ttm_bo_vm_fault without upsetting lockdep. Changes since v1: - Kill extra memcpy for !AGP case. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> Reviewed-by: Jerome Glisse <jglisse@redhat.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
707 lines
19 KiB
C
707 lines
19 KiB
C
/*
|
|
* Copyright 2008 Jerome Glisse.
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* Jerome Glisse <glisse@freedesktop.org>
|
|
*/
|
|
#include <drm/drmP.h>
|
|
#include <drm/radeon_drm.h>
|
|
#include "radeon_reg.h"
|
|
#include "radeon.h"
|
|
#include "radeon_trace.h"
|
|
|
|
static int radeon_cs_parser_relocs(struct radeon_cs_parser *p)
|
|
{
|
|
struct drm_device *ddev = p->rdev->ddev;
|
|
struct radeon_cs_chunk *chunk;
|
|
unsigned i, j;
|
|
bool duplicate;
|
|
|
|
if (p->chunk_relocs_idx == -1) {
|
|
return 0;
|
|
}
|
|
chunk = &p->chunks[p->chunk_relocs_idx];
|
|
p->dma_reloc_idx = 0;
|
|
/* FIXME: we assume that each relocs use 4 dwords */
|
|
p->nrelocs = chunk->length_dw / 4;
|
|
p->relocs_ptr = kcalloc(p->nrelocs, sizeof(void *), GFP_KERNEL);
|
|
if (p->relocs_ptr == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
p->relocs = kcalloc(p->nrelocs, sizeof(struct radeon_cs_reloc), GFP_KERNEL);
|
|
if (p->relocs == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
for (i = 0; i < p->nrelocs; i++) {
|
|
struct drm_radeon_cs_reloc *r;
|
|
|
|
duplicate = false;
|
|
r = (struct drm_radeon_cs_reloc *)&chunk->kdata[i*4];
|
|
for (j = 0; j < i; j++) {
|
|
if (r->handle == p->relocs[j].handle) {
|
|
p->relocs_ptr[i] = &p->relocs[j];
|
|
duplicate = true;
|
|
break;
|
|
}
|
|
}
|
|
if (duplicate) {
|
|
p->relocs[i].handle = 0;
|
|
continue;
|
|
}
|
|
|
|
p->relocs[i].gobj = drm_gem_object_lookup(ddev, p->filp,
|
|
r->handle);
|
|
if (p->relocs[i].gobj == NULL) {
|
|
DRM_ERROR("gem object lookup failed 0x%x\n",
|
|
r->handle);
|
|
return -ENOENT;
|
|
}
|
|
p->relocs_ptr[i] = &p->relocs[i];
|
|
p->relocs[i].robj = gem_to_radeon_bo(p->relocs[i].gobj);
|
|
p->relocs[i].lobj.bo = p->relocs[i].robj;
|
|
p->relocs[i].lobj.written = !!r->write_domain;
|
|
|
|
/* the first reloc of an UVD job is the msg and that must be in
|
|
VRAM, also but everything into VRAM on AGP cards to avoid
|
|
image corruptions */
|
|
if (p->ring == R600_RING_TYPE_UVD_INDEX &&
|
|
p->rdev->family < CHIP_PALM &&
|
|
(i == 0 || drm_pci_device_is_agp(p->rdev->ddev))) {
|
|
|
|
p->relocs[i].lobj.domain =
|
|
RADEON_GEM_DOMAIN_VRAM;
|
|
|
|
p->relocs[i].lobj.alt_domain =
|
|
RADEON_GEM_DOMAIN_VRAM;
|
|
|
|
} else {
|
|
uint32_t domain = r->write_domain ?
|
|
r->write_domain : r->read_domains;
|
|
|
|
p->relocs[i].lobj.domain = domain;
|
|
if (domain == RADEON_GEM_DOMAIN_VRAM)
|
|
domain |= RADEON_GEM_DOMAIN_GTT;
|
|
p->relocs[i].lobj.alt_domain = domain;
|
|
}
|
|
|
|
p->relocs[i].lobj.tv.bo = &p->relocs[i].robj->tbo;
|
|
p->relocs[i].handle = r->handle;
|
|
|
|
radeon_bo_list_add_object(&p->relocs[i].lobj,
|
|
&p->validated);
|
|
}
|
|
return radeon_bo_list_validate(&p->ticket, &p->validated, p->ring);
|
|
}
|
|
|
|
static int radeon_cs_get_ring(struct radeon_cs_parser *p, u32 ring, s32 priority)
|
|
{
|
|
p->priority = priority;
|
|
|
|
switch (ring) {
|
|
default:
|
|
DRM_ERROR("unknown ring id: %d\n", ring);
|
|
return -EINVAL;
|
|
case RADEON_CS_RING_GFX:
|
|
p->ring = RADEON_RING_TYPE_GFX_INDEX;
|
|
break;
|
|
case RADEON_CS_RING_COMPUTE:
|
|
if (p->rdev->family >= CHIP_TAHITI) {
|
|
if (p->priority > 0)
|
|
p->ring = CAYMAN_RING_TYPE_CP1_INDEX;
|
|
else
|
|
p->ring = CAYMAN_RING_TYPE_CP2_INDEX;
|
|
} else
|
|
p->ring = RADEON_RING_TYPE_GFX_INDEX;
|
|
break;
|
|
case RADEON_CS_RING_DMA:
|
|
if (p->rdev->family >= CHIP_CAYMAN) {
|
|
if (p->priority > 0)
|
|
p->ring = R600_RING_TYPE_DMA_INDEX;
|
|
else
|
|
p->ring = CAYMAN_RING_TYPE_DMA1_INDEX;
|
|
} else if (p->rdev->family >= CHIP_R600) {
|
|
p->ring = R600_RING_TYPE_DMA_INDEX;
|
|
} else {
|
|
return -EINVAL;
|
|
}
|
|
break;
|
|
case RADEON_CS_RING_UVD:
|
|
p->ring = R600_RING_TYPE_UVD_INDEX;
|
|
break;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void radeon_cs_sync_rings(struct radeon_cs_parser *p)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < p->nrelocs; i++) {
|
|
if (!p->relocs[i].robj)
|
|
continue;
|
|
|
|
radeon_ib_sync_to(&p->ib, p->relocs[i].robj->tbo.sync_obj);
|
|
}
|
|
}
|
|
|
|
/* XXX: note that this is called from the legacy UMS CS ioctl as well */
|
|
int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
|
|
{
|
|
struct drm_radeon_cs *cs = data;
|
|
uint64_t *chunk_array_ptr;
|
|
unsigned size, i;
|
|
u32 ring = RADEON_CS_RING_GFX;
|
|
s32 priority = 0;
|
|
|
|
if (!cs->num_chunks) {
|
|
return 0;
|
|
}
|
|
/* get chunks */
|
|
INIT_LIST_HEAD(&p->validated);
|
|
p->idx = 0;
|
|
p->ib.sa_bo = NULL;
|
|
p->ib.semaphore = NULL;
|
|
p->const_ib.sa_bo = NULL;
|
|
p->const_ib.semaphore = NULL;
|
|
p->chunk_ib_idx = -1;
|
|
p->chunk_relocs_idx = -1;
|
|
p->chunk_flags_idx = -1;
|
|
p->chunk_const_ib_idx = -1;
|
|
p->chunks_array = kcalloc(cs->num_chunks, sizeof(uint64_t), GFP_KERNEL);
|
|
if (p->chunks_array == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
chunk_array_ptr = (uint64_t *)(unsigned long)(cs->chunks);
|
|
if (DRM_COPY_FROM_USER(p->chunks_array, chunk_array_ptr,
|
|
sizeof(uint64_t)*cs->num_chunks)) {
|
|
return -EFAULT;
|
|
}
|
|
p->cs_flags = 0;
|
|
p->nchunks = cs->num_chunks;
|
|
p->chunks = kcalloc(p->nchunks, sizeof(struct radeon_cs_chunk), GFP_KERNEL);
|
|
if (p->chunks == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
for (i = 0; i < p->nchunks; i++) {
|
|
struct drm_radeon_cs_chunk __user **chunk_ptr = NULL;
|
|
struct drm_radeon_cs_chunk user_chunk;
|
|
uint32_t __user *cdata;
|
|
|
|
chunk_ptr = (void __user*)(unsigned long)p->chunks_array[i];
|
|
if (DRM_COPY_FROM_USER(&user_chunk, chunk_ptr,
|
|
sizeof(struct drm_radeon_cs_chunk))) {
|
|
return -EFAULT;
|
|
}
|
|
p->chunks[i].length_dw = user_chunk.length_dw;
|
|
p->chunks[i].chunk_id = user_chunk.chunk_id;
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_RELOCS) {
|
|
p->chunk_relocs_idx = i;
|
|
}
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_IB) {
|
|
p->chunk_ib_idx = i;
|
|
/* zero length IB isn't useful */
|
|
if (p->chunks[i].length_dw == 0)
|
|
return -EINVAL;
|
|
}
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_CONST_IB) {
|
|
p->chunk_const_ib_idx = i;
|
|
/* zero length CONST IB isn't useful */
|
|
if (p->chunks[i].length_dw == 0)
|
|
return -EINVAL;
|
|
}
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
|
|
p->chunk_flags_idx = i;
|
|
/* zero length flags aren't useful */
|
|
if (p->chunks[i].length_dw == 0)
|
|
return -EINVAL;
|
|
}
|
|
|
|
size = p->chunks[i].length_dw;
|
|
cdata = (void __user *)(unsigned long)user_chunk.chunk_data;
|
|
p->chunks[i].user_ptr = cdata;
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_CONST_IB)
|
|
continue;
|
|
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_IB) {
|
|
if (!p->rdev || !(p->rdev->flags & RADEON_IS_AGP))
|
|
continue;
|
|
}
|
|
|
|
p->chunks[i].kdata = drm_malloc_ab(size, sizeof(uint32_t));
|
|
size *= sizeof(uint32_t);
|
|
if (p->chunks[i].kdata == NULL) {
|
|
return -ENOMEM;
|
|
}
|
|
if (DRM_COPY_FROM_USER(p->chunks[i].kdata, cdata, size)) {
|
|
return -EFAULT;
|
|
}
|
|
if (p->chunks[i].chunk_id == RADEON_CHUNK_ID_FLAGS) {
|
|
p->cs_flags = p->chunks[i].kdata[0];
|
|
if (p->chunks[i].length_dw > 1)
|
|
ring = p->chunks[i].kdata[1];
|
|
if (p->chunks[i].length_dw > 2)
|
|
priority = (s32)p->chunks[i].kdata[2];
|
|
}
|
|
}
|
|
|
|
/* these are KMS only */
|
|
if (p->rdev) {
|
|
if ((p->cs_flags & RADEON_CS_USE_VM) &&
|
|
!p->rdev->vm_manager.enabled) {
|
|
DRM_ERROR("VM not active on asic!\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (radeon_cs_get_ring(p, ring, priority))
|
|
return -EINVAL;
|
|
|
|
/* we only support VM on some SI+ rings */
|
|
if ((p->rdev->asic->ring[p->ring]->cs_parse == NULL) &&
|
|
((p->cs_flags & RADEON_CS_USE_VM) == 0)) {
|
|
DRM_ERROR("Ring %d requires VM!\n", p->ring);
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* cs_parser_fini() - clean parser states
|
|
* @parser: parser structure holding parsing context.
|
|
* @error: error number
|
|
*
|
|
* If error is set than unvalidate buffer, otherwise just free memory
|
|
* used by parsing context.
|
|
**/
|
|
static void radeon_cs_parser_fini(struct radeon_cs_parser *parser, int error, bool backoff)
|
|
{
|
|
unsigned i;
|
|
|
|
if (!error) {
|
|
ttm_eu_fence_buffer_objects(&parser->ticket,
|
|
&parser->validated,
|
|
parser->ib.fence);
|
|
} else if (backoff) {
|
|
ttm_eu_backoff_reservation(&parser->ticket,
|
|
&parser->validated);
|
|
}
|
|
|
|
if (parser->relocs != NULL) {
|
|
for (i = 0; i < parser->nrelocs; i++) {
|
|
if (parser->relocs[i].gobj)
|
|
drm_gem_object_unreference_unlocked(parser->relocs[i].gobj);
|
|
}
|
|
}
|
|
kfree(parser->track);
|
|
kfree(parser->relocs);
|
|
kfree(parser->relocs_ptr);
|
|
for (i = 0; i < parser->nchunks; i++)
|
|
drm_free_large(parser->chunks[i].kdata);
|
|
kfree(parser->chunks);
|
|
kfree(parser->chunks_array);
|
|
radeon_ib_free(parser->rdev, &parser->ib);
|
|
radeon_ib_free(parser->rdev, &parser->const_ib);
|
|
}
|
|
|
|
static int radeon_cs_ib_chunk(struct radeon_device *rdev,
|
|
struct radeon_cs_parser *parser)
|
|
{
|
|
int r;
|
|
|
|
if (parser->chunk_ib_idx == -1)
|
|
return 0;
|
|
|
|
if (parser->cs_flags & RADEON_CS_USE_VM)
|
|
return 0;
|
|
|
|
r = radeon_cs_parse(rdev, parser->ring, parser);
|
|
if (r || parser->parser_error) {
|
|
DRM_ERROR("Invalid command stream !\n");
|
|
return r;
|
|
}
|
|
|
|
if (parser->ring == R600_RING_TYPE_UVD_INDEX)
|
|
radeon_uvd_note_usage(rdev);
|
|
|
|
radeon_cs_sync_rings(parser);
|
|
r = radeon_ib_schedule(rdev, &parser->ib, NULL);
|
|
if (r) {
|
|
DRM_ERROR("Failed to schedule IB !\n");
|
|
}
|
|
return r;
|
|
}
|
|
|
|
static int radeon_bo_vm_update_pte(struct radeon_cs_parser *parser,
|
|
struct radeon_vm *vm)
|
|
{
|
|
struct radeon_device *rdev = parser->rdev;
|
|
struct radeon_bo_list *lobj;
|
|
struct radeon_bo *bo;
|
|
int r;
|
|
|
|
r = radeon_vm_bo_update_pte(rdev, vm, rdev->ring_tmp_bo.bo, &rdev->ring_tmp_bo.bo->tbo.mem);
|
|
if (r) {
|
|
return r;
|
|
}
|
|
list_for_each_entry(lobj, &parser->validated, tv.head) {
|
|
bo = lobj->bo;
|
|
r = radeon_vm_bo_update_pte(parser->rdev, vm, bo, &bo->tbo.mem);
|
|
if (r) {
|
|
return r;
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int radeon_cs_ib_vm_chunk(struct radeon_device *rdev,
|
|
struct radeon_cs_parser *parser)
|
|
{
|
|
struct radeon_fpriv *fpriv = parser->filp->driver_priv;
|
|
struct radeon_vm *vm = &fpriv->vm;
|
|
int r;
|
|
|
|
if (parser->chunk_ib_idx == -1)
|
|
return 0;
|
|
if ((parser->cs_flags & RADEON_CS_USE_VM) == 0)
|
|
return 0;
|
|
|
|
if (parser->const_ib.length_dw) {
|
|
r = radeon_ring_ib_parse(rdev, parser->ring, &parser->const_ib);
|
|
if (r) {
|
|
return r;
|
|
}
|
|
}
|
|
|
|
r = radeon_ring_ib_parse(rdev, parser->ring, &parser->ib);
|
|
if (r) {
|
|
return r;
|
|
}
|
|
|
|
if (parser->ring == R600_RING_TYPE_UVD_INDEX)
|
|
radeon_uvd_note_usage(rdev);
|
|
|
|
mutex_lock(&rdev->vm_manager.lock);
|
|
mutex_lock(&vm->mutex);
|
|
r = radeon_vm_alloc_pt(rdev, vm);
|
|
if (r) {
|
|
goto out;
|
|
}
|
|
r = radeon_bo_vm_update_pte(parser, vm);
|
|
if (r) {
|
|
goto out;
|
|
}
|
|
radeon_cs_sync_rings(parser);
|
|
radeon_ib_sync_to(&parser->ib, vm->fence);
|
|
radeon_ib_sync_to(&parser->ib, radeon_vm_grab_id(
|
|
rdev, vm, parser->ring));
|
|
|
|
if ((rdev->family >= CHIP_TAHITI) &&
|
|
(parser->chunk_const_ib_idx != -1)) {
|
|
r = radeon_ib_schedule(rdev, &parser->ib, &parser->const_ib);
|
|
} else {
|
|
r = radeon_ib_schedule(rdev, &parser->ib, NULL);
|
|
}
|
|
|
|
if (!r) {
|
|
radeon_vm_fence(rdev, vm, parser->ib.fence);
|
|
}
|
|
|
|
out:
|
|
radeon_vm_add_to_lru(rdev, vm);
|
|
mutex_unlock(&vm->mutex);
|
|
mutex_unlock(&rdev->vm_manager.lock);
|
|
return r;
|
|
}
|
|
|
|
static int radeon_cs_handle_lockup(struct radeon_device *rdev, int r)
|
|
{
|
|
if (r == -EDEADLK) {
|
|
r = radeon_gpu_reset(rdev);
|
|
if (!r)
|
|
r = -EAGAIN;
|
|
}
|
|
return r;
|
|
}
|
|
|
|
static int radeon_cs_ib_fill(struct radeon_device *rdev, struct radeon_cs_parser *parser)
|
|
{
|
|
struct radeon_cs_chunk *ib_chunk;
|
|
struct radeon_vm *vm = NULL;
|
|
int r;
|
|
|
|
if (parser->chunk_ib_idx == -1)
|
|
return 0;
|
|
|
|
if (parser->cs_flags & RADEON_CS_USE_VM) {
|
|
struct radeon_fpriv *fpriv = parser->filp->driver_priv;
|
|
vm = &fpriv->vm;
|
|
|
|
if ((rdev->family >= CHIP_TAHITI) &&
|
|
(parser->chunk_const_ib_idx != -1)) {
|
|
ib_chunk = &parser->chunks[parser->chunk_const_ib_idx];
|
|
if (ib_chunk->length_dw > RADEON_IB_VM_MAX_SIZE) {
|
|
DRM_ERROR("cs IB CONST too big: %d\n", ib_chunk->length_dw);
|
|
return -EINVAL;
|
|
}
|
|
r = radeon_ib_get(rdev, parser->ring, &parser->const_ib,
|
|
vm, ib_chunk->length_dw * 4);
|
|
if (r) {
|
|
DRM_ERROR("Failed to get const ib !\n");
|
|
return r;
|
|
}
|
|
parser->const_ib.is_const_ib = true;
|
|
parser->const_ib.length_dw = ib_chunk->length_dw;
|
|
if (DRM_COPY_FROM_USER(parser->const_ib.ptr,
|
|
ib_chunk->user_ptr,
|
|
ib_chunk->length_dw * 4))
|
|
return -EFAULT;
|
|
}
|
|
|
|
ib_chunk = &parser->chunks[parser->chunk_ib_idx];
|
|
if (ib_chunk->length_dw > RADEON_IB_VM_MAX_SIZE) {
|
|
DRM_ERROR("cs IB too big: %d\n", ib_chunk->length_dw);
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
ib_chunk = &parser->chunks[parser->chunk_ib_idx];
|
|
|
|
r = radeon_ib_get(rdev, parser->ring, &parser->ib,
|
|
vm, ib_chunk->length_dw * 4);
|
|
if (r) {
|
|
DRM_ERROR("Failed to get ib !\n");
|
|
return r;
|
|
}
|
|
parser->ib.length_dw = ib_chunk->length_dw;
|
|
if (ib_chunk->kdata)
|
|
memcpy(parser->ib.ptr, ib_chunk->kdata, ib_chunk->length_dw * 4);
|
|
else if (DRM_COPY_FROM_USER(parser->ib.ptr, ib_chunk->user_ptr, ib_chunk->length_dw * 4))
|
|
return -EFAULT;
|
|
return 0;
|
|
}
|
|
|
|
int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
|
|
{
|
|
struct radeon_device *rdev = dev->dev_private;
|
|
struct radeon_cs_parser parser;
|
|
int r;
|
|
|
|
down_read(&rdev->exclusive_lock);
|
|
if (!rdev->accel_working) {
|
|
up_read(&rdev->exclusive_lock);
|
|
return -EBUSY;
|
|
}
|
|
/* initialize parser */
|
|
memset(&parser, 0, sizeof(struct radeon_cs_parser));
|
|
parser.filp = filp;
|
|
parser.rdev = rdev;
|
|
parser.dev = rdev->dev;
|
|
parser.family = rdev->family;
|
|
r = radeon_cs_parser_init(&parser, data);
|
|
if (r) {
|
|
DRM_ERROR("Failed to initialize parser !\n");
|
|
radeon_cs_parser_fini(&parser, r, false);
|
|
up_read(&rdev->exclusive_lock);
|
|
r = radeon_cs_handle_lockup(rdev, r);
|
|
return r;
|
|
}
|
|
|
|
r = radeon_cs_ib_fill(rdev, &parser);
|
|
if (!r) {
|
|
r = radeon_cs_parser_relocs(&parser);
|
|
if (r && r != -ERESTARTSYS)
|
|
DRM_ERROR("Failed to parse relocation %d!\n", r);
|
|
}
|
|
|
|
if (r) {
|
|
radeon_cs_parser_fini(&parser, r, false);
|
|
up_read(&rdev->exclusive_lock);
|
|
r = radeon_cs_handle_lockup(rdev, r);
|
|
return r;
|
|
}
|
|
|
|
trace_radeon_cs(&parser);
|
|
|
|
r = radeon_cs_ib_chunk(rdev, &parser);
|
|
if (r) {
|
|
goto out;
|
|
}
|
|
r = radeon_cs_ib_vm_chunk(rdev, &parser);
|
|
if (r) {
|
|
goto out;
|
|
}
|
|
out:
|
|
radeon_cs_parser_fini(&parser, r, true);
|
|
up_read(&rdev->exclusive_lock);
|
|
r = radeon_cs_handle_lockup(rdev, r);
|
|
return r;
|
|
}
|
|
|
|
/**
|
|
* radeon_cs_packet_parse() - parse cp packet and point ib index to next packet
|
|
* @parser: parser structure holding parsing context.
|
|
* @pkt: where to store packet information
|
|
*
|
|
* Assume that chunk_ib_index is properly set. Will return -EINVAL
|
|
* if packet is bigger than remaining ib size. or if packets is unknown.
|
|
**/
|
|
int radeon_cs_packet_parse(struct radeon_cs_parser *p,
|
|
struct radeon_cs_packet *pkt,
|
|
unsigned idx)
|
|
{
|
|
struct radeon_cs_chunk *ib_chunk = &p->chunks[p->chunk_ib_idx];
|
|
struct radeon_device *rdev = p->rdev;
|
|
uint32_t header;
|
|
|
|
if (idx >= ib_chunk->length_dw) {
|
|
DRM_ERROR("Can not parse packet at %d after CS end %d !\n",
|
|
idx, ib_chunk->length_dw);
|
|
return -EINVAL;
|
|
}
|
|
header = radeon_get_ib_value(p, idx);
|
|
pkt->idx = idx;
|
|
pkt->type = RADEON_CP_PACKET_GET_TYPE(header);
|
|
pkt->count = RADEON_CP_PACKET_GET_COUNT(header);
|
|
pkt->one_reg_wr = 0;
|
|
switch (pkt->type) {
|
|
case RADEON_PACKET_TYPE0:
|
|
if (rdev->family < CHIP_R600) {
|
|
pkt->reg = R100_CP_PACKET0_GET_REG(header);
|
|
pkt->one_reg_wr =
|
|
RADEON_CP_PACKET0_GET_ONE_REG_WR(header);
|
|
} else
|
|
pkt->reg = R600_CP_PACKET0_GET_REG(header);
|
|
break;
|
|
case RADEON_PACKET_TYPE3:
|
|
pkt->opcode = RADEON_CP_PACKET3_GET_OPCODE(header);
|
|
break;
|
|
case RADEON_PACKET_TYPE2:
|
|
pkt->count = -1;
|
|
break;
|
|
default:
|
|
DRM_ERROR("Unknown packet type %d at %d !\n", pkt->type, idx);
|
|
return -EINVAL;
|
|
}
|
|
if ((pkt->count + 1 + pkt->idx) >= ib_chunk->length_dw) {
|
|
DRM_ERROR("Packet (%d:%d:%d) end after CS buffer (%d) !\n",
|
|
pkt->idx, pkt->type, pkt->count, ib_chunk->length_dw);
|
|
return -EINVAL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* radeon_cs_packet_next_is_pkt3_nop() - test if the next packet is P3 NOP
|
|
* @p: structure holding the parser context.
|
|
*
|
|
* Check if the next packet is NOP relocation packet3.
|
|
**/
|
|
bool radeon_cs_packet_next_is_pkt3_nop(struct radeon_cs_parser *p)
|
|
{
|
|
struct radeon_cs_packet p3reloc;
|
|
int r;
|
|
|
|
r = radeon_cs_packet_parse(p, &p3reloc, p->idx);
|
|
if (r)
|
|
return false;
|
|
if (p3reloc.type != RADEON_PACKET_TYPE3)
|
|
return false;
|
|
if (p3reloc.opcode != RADEON_PACKET3_NOP)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* radeon_cs_dump_packet() - dump raw packet context
|
|
* @p: structure holding the parser context.
|
|
* @pkt: structure holding the packet.
|
|
*
|
|
* Used mostly for debugging and error reporting.
|
|
**/
|
|
void radeon_cs_dump_packet(struct radeon_cs_parser *p,
|
|
struct radeon_cs_packet *pkt)
|
|
{
|
|
volatile uint32_t *ib;
|
|
unsigned i;
|
|
unsigned idx;
|
|
|
|
ib = p->ib.ptr;
|
|
idx = pkt->idx;
|
|
for (i = 0; i <= (pkt->count + 1); i++, idx++)
|
|
DRM_INFO("ib[%d]=0x%08X\n", idx, ib[idx]);
|
|
}
|
|
|
|
/**
|
|
* radeon_cs_packet_next_reloc() - parse next (should be reloc) packet
|
|
* @parser: parser structure holding parsing context.
|
|
* @data: pointer to relocation data
|
|
* @offset_start: starting offset
|
|
* @offset_mask: offset mask (to align start offset on)
|
|
* @reloc: reloc informations
|
|
*
|
|
* Check if next packet is relocation packet3, do bo validation and compute
|
|
* GPU offset using the provided start.
|
|
**/
|
|
int radeon_cs_packet_next_reloc(struct radeon_cs_parser *p,
|
|
struct radeon_cs_reloc **cs_reloc,
|
|
int nomm)
|
|
{
|
|
struct radeon_cs_chunk *relocs_chunk;
|
|
struct radeon_cs_packet p3reloc;
|
|
unsigned idx;
|
|
int r;
|
|
|
|
if (p->chunk_relocs_idx == -1) {
|
|
DRM_ERROR("No relocation chunk !\n");
|
|
return -EINVAL;
|
|
}
|
|
*cs_reloc = NULL;
|
|
relocs_chunk = &p->chunks[p->chunk_relocs_idx];
|
|
r = radeon_cs_packet_parse(p, &p3reloc, p->idx);
|
|
if (r)
|
|
return r;
|
|
p->idx += p3reloc.count + 2;
|
|
if (p3reloc.type != RADEON_PACKET_TYPE3 ||
|
|
p3reloc.opcode != RADEON_PACKET3_NOP) {
|
|
DRM_ERROR("No packet3 for relocation for packet at %d.\n",
|
|
p3reloc.idx);
|
|
radeon_cs_dump_packet(p, &p3reloc);
|
|
return -EINVAL;
|
|
}
|
|
idx = radeon_get_ib_value(p, p3reloc.idx + 1);
|
|
if (idx >= relocs_chunk->length_dw) {
|
|
DRM_ERROR("Relocs at %d after relocations chunk end %d !\n",
|
|
idx, relocs_chunk->length_dw);
|
|
radeon_cs_dump_packet(p, &p3reloc);
|
|
return -EINVAL;
|
|
}
|
|
/* FIXME: we assume reloc size is 4 dwords */
|
|
if (nomm) {
|
|
*cs_reloc = p->relocs;
|
|
(*cs_reloc)->lobj.gpu_offset =
|
|
(u64)relocs_chunk->kdata[idx + 3] << 32;
|
|
(*cs_reloc)->lobj.gpu_offset |= relocs_chunk->kdata[idx + 0];
|
|
} else
|
|
*cs_reloc = p->relocs_ptr[(idx / 4)];
|
|
return 0;
|
|
}
|