mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 11:19:37 +00:00
![Shengjiu Wang](/assets/img/avatar_default.png)
Audmix support two substream, When two substream start
to run, the trigger function may be called by two substream
in same time, that the priv->tdms may be updated wrongly.
The expected priv->tdms is 0x3, but sometimes the
result is 0x2, or 0x1.
Fixes: be1df61cf0
("ASoC: fsl: Add Audio Mixer CPU DAI driver")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/1e706afe53fdd1fbbbc79277c48a98f8416ba873.1573458378.git.shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <stable@vger.kernel.org>
103 lines
4.1 KiB
C
103 lines
4.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* NXP AUDMIX ALSA SoC Digital Audio Interface (DAI) driver
|
|
*
|
|
* Copyright 2017 NXP
|
|
*/
|
|
|
|
#ifndef __FSL_AUDMIX_H
|
|
#define __FSL_AUDMIX_H
|
|
|
|
#define FSL_AUDMIX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\
|
|
SNDRV_PCM_FMTBIT_S24_LE |\
|
|
SNDRV_PCM_FMTBIT_S32_LE)
|
|
/* AUDMIX Registers */
|
|
#define FSL_AUDMIX_CTR 0x200 /* Control */
|
|
#define FSL_AUDMIX_STR 0x204 /* Status */
|
|
|
|
#define FSL_AUDMIX_ATCR0 0x208 /* Attenuation Control */
|
|
#define FSL_AUDMIX_ATIVAL0 0x20c /* Attenuation Initial Value */
|
|
#define FSL_AUDMIX_ATSTPUP0 0x210 /* Attenuation step up factor */
|
|
#define FSL_AUDMIX_ATSTPDN0 0x214 /* Attenuation step down factor */
|
|
#define FSL_AUDMIX_ATSTPTGT0 0x218 /* Attenuation step target */
|
|
#define FSL_AUDMIX_ATTNVAL0 0x21c /* Attenuation Value */
|
|
#define FSL_AUDMIX_ATSTP0 0x220 /* Attenuation step number */
|
|
|
|
#define FSL_AUDMIX_ATCR1 0x228 /* Attenuation Control */
|
|
#define FSL_AUDMIX_ATIVAL1 0x22c /* Attenuation Initial Value */
|
|
#define FSL_AUDMIX_ATSTPUP1 0x230 /* Attenuation step up factor */
|
|
#define FSL_AUDMIX_ATSTPDN1 0x234 /* Attenuation step down factor */
|
|
#define FSL_AUDMIX_ATSTPTGT1 0x238 /* Attenuation step target */
|
|
#define FSL_AUDMIX_ATTNVAL1 0x23c /* Attenuation Value */
|
|
#define FSL_AUDMIX_ATSTP1 0x240 /* Attenuation step number */
|
|
|
|
/* AUDMIX Control Register */
|
|
#define FSL_AUDMIX_CTR_MIXCLK_SHIFT 0
|
|
#define FSL_AUDMIX_CTR_MIXCLK_MASK BIT(FSL_AUDMIX_CTR_MIXCLK_SHIFT)
|
|
#define FSL_AUDMIX_CTR_MIXCLK(i) ((i) << FSL_AUDMIX_CTR_MIXCLK_SHIFT)
|
|
#define FSL_AUDMIX_CTR_OUTSRC_SHIFT 1
|
|
#define FSL_AUDMIX_CTR_OUTSRC_MASK (0x3 << FSL_AUDMIX_CTR_OUTSRC_SHIFT)
|
|
#define FSL_AUDMIX_CTR_OUTSRC(i) (((i) << FSL_AUDMIX_CTR_OUTSRC_SHIFT)\
|
|
& FSL_AUDMIX_CTR_OUTSRC_MASK)
|
|
#define FSL_AUDMIX_CTR_OUTWIDTH_SHIFT 3
|
|
#define FSL_AUDMIX_CTR_OUTWIDTH_MASK (0x7 << FSL_AUDMIX_CTR_OUTWIDTH_SHIFT)
|
|
#define FSL_AUDMIX_CTR_OUTWIDTH(i) (((i) << FSL_AUDMIX_CTR_OUTWIDTH_SHIFT)\
|
|
& FSL_AUDMIX_CTR_OUTWIDTH_MASK)
|
|
#define FSL_AUDMIX_CTR_OUTCKPOL_SHIFT 6
|
|
#define FSL_AUDMIX_CTR_OUTCKPOL_MASK BIT(FSL_AUDMIX_CTR_OUTCKPOL_SHIFT)
|
|
#define FSL_AUDMIX_CTR_OUTCKPOL(i) ((i) << FSL_AUDMIX_CTR_OUTCKPOL_SHIFT)
|
|
#define FSL_AUDMIX_CTR_MASKRTDF_SHIFT 7
|
|
#define FSL_AUDMIX_CTR_MASKRTDF_MASK BIT(FSL_AUDMIX_CTR_MASKRTDF_SHIFT)
|
|
#define FSL_AUDMIX_CTR_MASKRTDF(i) ((i) << FSL_AUDMIX_CTR_MASKRTDF_SHIFT)
|
|
#define FSL_AUDMIX_CTR_MASKCKDF_SHIFT 8
|
|
#define FSL_AUDMIX_CTR_MASKCKDF_MASK BIT(FSL_AUDMIX_CTR_MASKCKDF_SHIFT)
|
|
#define FSL_AUDMIX_CTR_MASKCKDF(i) ((i) << FSL_AUDMIX_CTR_MASKCKDF_SHIFT)
|
|
#define FSL_AUDMIX_CTR_SYNCMODE_SHIFT 9
|
|
#define FSL_AUDMIX_CTR_SYNCMODE_MASK BIT(FSL_AUDMIX_CTR_SYNCMODE_SHIFT)
|
|
#define FSL_AUDMIX_CTR_SYNCMODE(i) ((i) << FSL_AUDMIX_CTR_SYNCMODE_SHIFT)
|
|
#define FSL_AUDMIX_CTR_SYNCSRC_SHIFT 10
|
|
#define FSL_AUDMIX_CTR_SYNCSRC_MASK BIT(FSL_AUDMIX_CTR_SYNCSRC_SHIFT)
|
|
#define FSL_AUDMIX_CTR_SYNCSRC(i) ((i) << FSL_AUDMIX_CTR_SYNCSRC_SHIFT)
|
|
|
|
/* AUDMIX Status Register */
|
|
#define FSL_AUDMIX_STR_RATEDIFF BIT(0)
|
|
#define FSL_AUDMIX_STR_CLKDIFF BIT(1)
|
|
#define FSL_AUDMIX_STR_MIXSTAT_SHIFT 2
|
|
#define FSL_AUDMIX_STR_MIXSTAT_MASK (0x3 << FSL_AUDMIX_STR_MIXSTAT_SHIFT)
|
|
#define FSL_AUDMIX_STR_MIXSTAT(i) (((i) & FSL_AUDMIX_STR_MIXSTAT_MASK) \
|
|
>> FSL_AUDMIX_STR_MIXSTAT_SHIFT)
|
|
/* AUDMIX Attenuation Control Register */
|
|
#define FSL_AUDMIX_ATCR_AT_EN BIT(0)
|
|
#define FSL_AUDMIX_ATCR_AT_UPDN BIT(1)
|
|
#define FSL_AUDMIX_ATCR_ATSTPDIF_SHIFT 2
|
|
#define FSL_AUDMIX_ATCR_ATSTPDFI_MASK \
|
|
(0xfff << FSL_AUDMIX_ATCR_ATSTPDIF_SHIFT)
|
|
|
|
/* AUDMIX Attenuation Initial Value Register */
|
|
#define FSL_AUDMIX_ATIVAL_ATINVAL_MASK 0x3FFFF
|
|
|
|
/* AUDMIX Attenuation Step Up Factor Register */
|
|
#define FSL_AUDMIX_ATSTPUP_ATSTEPUP_MASK 0x3FFFF
|
|
|
|
/* AUDMIX Attenuation Step Down Factor Register */
|
|
#define FSL_AUDMIX_ATSTPDN_ATSTEPDN_MASK 0x3FFFF
|
|
|
|
/* AUDMIX Attenuation Step Target Register */
|
|
#define FSL_AUDMIX_ATSTPTGT_ATSTPTG_MASK 0x3FFFF
|
|
|
|
/* AUDMIX Attenuation Value Register */
|
|
#define FSL_AUDMIX_ATTNVAL_ATCURVAL_MASK 0x3FFFF
|
|
|
|
/* AUDMIX Attenuation Step Number Register */
|
|
#define FSL_AUDMIX_ATSTP_STPCTR_MASK 0x3FFFF
|
|
|
|
#define FSL_AUDMIX_MAX_DAIS 2
|
|
struct fsl_audmix {
|
|
struct platform_device *pdev;
|
|
struct regmap *regmap;
|
|
struct clk *ipg_clk;
|
|
spinlock_t lock; /* Protect tdms */
|
|
u8 tdms;
|
|
};
|
|
|
|
#endif /* __FSL_AUDMIX_H */
|