mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
adbcada43f
This patch adds a flag to journal entries which, if set, indicates that they weren't done as flush/fua writes. - non flush/fua journal writes don't update last_seq (i.e. they don't free up space in the journal), thus the journal free space calculations now check whether nonflush journal writes are currently allowed (i.e. are we low on free space, or would doing a flush write free up a lot of space in the journal) - write_delay_ms, the user configurable option for when open journal entries are automatically written, is now interpreted as the max delay between flush journal writes (default 1 second). - bch2_journal_flush_seq_async is changed to ensure a flush write >= the requested sequence number has happened - journal read/replay must now ignore, and blacklist, any journal entries newer than the most recent flush entry in the journal. Also, the way the read_entire_journal option is handled has been improved; struct journal_replay now has an entry, 'ignore', for entries that were read but should not be used. - assorted refactoring and improvements related to journal read in journal_io.c and recovery.c Previously, we'd have to issue a flush/fua write every time we accumulated a full journal entry - typically the bucket size. Now we need to issue them much less frequently: when an fsync is requested, or it's been more than write_delay_ms since the last flush, or when we need to free up space in the journal. This is a significant performance improvement on many write heavy workloads. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
45 lines
1.2 KiB
C
45 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _BCACHEFS_JOURNAL_IO_H
|
|
#define _BCACHEFS_JOURNAL_IO_H
|
|
|
|
/*
|
|
* Only used for holding the journal entries we read in btree_journal_read()
|
|
* during cache_registration
|
|
*/
|
|
struct journal_replay {
|
|
struct list_head list;
|
|
struct bch_devs_list devs;
|
|
/* checksum error, but we may want to try using it anyways: */
|
|
bool bad;
|
|
bool ignore;
|
|
/* must be last: */
|
|
struct jset j;
|
|
};
|
|
|
|
static inline struct jset_entry *__jset_entry_type_next(struct jset *jset,
|
|
struct jset_entry *entry, unsigned type)
|
|
{
|
|
while (entry < vstruct_last(jset)) {
|
|
if (entry->type == type)
|
|
return entry;
|
|
|
|
entry = vstruct_next(entry);
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
#define for_each_jset_entry_type(entry, jset, type) \
|
|
for (entry = (jset)->start; \
|
|
(entry = __jset_entry_type_next(jset, entry, type)); \
|
|
entry = vstruct_next(entry))
|
|
|
|
#define for_each_jset_key(k, _n, entry, jset) \
|
|
for_each_jset_entry_type(entry, jset, BCH_JSET_ENTRY_btree_keys) \
|
|
vstruct_for_each_safe(entry, k, _n)
|
|
|
|
int bch2_journal_read(struct bch_fs *, struct list_head *, u64 *, u64 *);
|
|
|
|
void bch2_journal_write(struct closure *);
|
|
|
|
#endif /* _BCACHEFS_JOURNAL_IO_H */
|