mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-23 17:30:02 +00:00
Code Issues Releases Wiki Activity
linux-stable/net/rose
History
Anmol Karn bbcdbd1d3a rose: Fix Null pointer dereference in rose_send_frame() 
[ Upstream commit 3b3fd068c5 ]

rose_send_frame() dereferences `neigh->dev` when called from
rose_transmit_clear_request(), and the first occurrence of the
`neigh` is in rose_loopback_timer() as `rose_loopback_neigh`,
and it is initialized in rose_add_loopback_neigh() as NULL.
i.e when `rose_loopback_neigh` used in rose_loopback_timer()
its `->dev` was still NULL and rose_loopback_timer() was calling
rose_rx_call_request() without checking for NULL.

- net/rose/rose_link.c
This bug seems to get triggered in this line:

rose_call = (ax25_address *)neigh->dev->dev_addr;

Fix it by adding NULL checking for `rose_loopback_neigh->dev`
in rose_loopback_timer().

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Reported-by: syzbot+a1c743815982d9496393@syzkaller.appspotmail.com
Tested-by: syzbot+a1c743815982d9496393@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=9d2a7ca8c7f2e4b682c97578dfa3f236258300b3
Signed-off-by: Anmol Karn <anmol.karan123@gmail.com>
Link: https://lore.kernel.org/r/20201119191043.28813-1-anmol.karan123@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-08 10:17:32 +01:00
..
af_rose.c net/rose: Convert timers to use timer_setup() 2019-05-02 09:40:34 +02:00
Makefile
rose_dev.c net: Kill dev_rebuild_header 2015-03-02 16:43:41 -05:00
rose_in.c rose: limit sk_filter trim to payload 2016-07-13 11:53:40 -07:00
rose_link.c net/rose: Convert timers to use timer_setup() 2019-05-02 09:40:34 +02:00
rose_loopback.c rose: Fix Null pointer dereference in rose_send_frame() 2020-12-08 10:17:32 +01:00
rose_out.c
rose_route.c net/rose: Convert timers to use timer_setup() 2019-05-02 09:40:34 +02:00
rose_subr.c net: rose: fix a possible stack overflow 2019-04-03 06:25:08 +02:00
rose_timer.c net/rose: Convert timers to use timer_setup() 2019-05-02 09:40:34 +02:00
sysctl_net_rose.c net: Convert uses of typedef ctl_table to struct ctl_table 2013-06-13 02:36:09 -07:00