linux-stable/sound/isa
Xiaomeng Tong db9a101f93 ALSA: cs4236: fix an incorrect NULL check on list iterator
commit 0112f822f8 upstream.

The bug is here:
	err = snd_card_cs423x_pnp(dev, card->private_data, pdev, cdev);

The list iterator value 'cdev' will *always* be set and non-NULL
by list_for_each_entry(), so it is incorrect to assume that the
iterator value will be NULL if the list is empty or no element
is found.

To fix the bug, use a new variable 'iter' as the list iterator,
while use the original variable 'cdev' as a dedicated pointer
to point to the found element. And snd_card_cs423x_pnp() itself
has NULL check for cdev.

Cc: stable@vger.kernel.org
Fixes: c2b73d1458 ("ALSA: cs4236: cs4232 and cs4236 driver merge to solve PnP BIOS detection")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220327060822.4735-1-xiam0nd.tong@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-20 09:08:10 +02:00
..
ad1816a ALSA: isa: make snd_pcm_hardware const 2017-08-17 12:44:11 +02:00
ad1848 ALSA: ad1848: fix format string overflow warning 2017-07-18 17:52:24 +02:00
cs423x ALSA: cs4236: fix an incorrect NULL check on list iterator 2022-04-20 09:08:10 +02:00
es1688 ALSA: es1688: Add the missed snd_card_free() 2020-06-20 10:25:00 +02:00
galaxy Annotate hardware config module parameters in sound/isa/ 2017-04-20 12:02:32 +01:00
gus ALSA: gus: fix null pointer dereference on pointer block 2021-11-26 11:40:38 +01:00
msnd ALSA: msnd: Fix the default sample sizes 2018-09-26 08:37:59 +02:00
opti9xx ALSA: opti9xx: shut up gcc-10 range warning 2020-05-05 19:15:52 +02:00
sb ALSA: sb: Fix potential ABBA deadlock in CSP driver 2021-07-28 11:12:18 +02:00
wavefront ALSA: isa/wavefront: prevent out of bounds write in ioctl 2020-06-25 15:41:48 +02:00
wss ALSA: wss: Fix invalid snd_free_pages() at error path 2018-12-05 19:41:24 +01:00
adlib.c Annotate hardware config module parameters in sound/isa/ 2017-04-20 12:02:32 +01:00
als100.c ALSA: als100: constify pnp_card_device_id 2017-08-17 12:42:19 +02:00
azt2320.c ALSA: azt2320: constify pnp_card_device_id 2017-08-17 12:42:21 +02:00
cmi8328.c ALSA: cmi8238: Use IS_ENABLED() 2017-05-17 07:13:05 +02:00
cmi8330.c ALSA: isa: Fix error return code in snd_cmi8330_probe() 2021-07-20 16:17:54 +02:00
es18xx.c ALSA: isa: make snd_pcm_hardware const 2017-08-17 12:44:11 +02:00
Kconfig ALSA: seq: Allow the modular sequencer registration 2017-06-12 08:43:33 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
opl3sa2.c ALSA: opl3sa2: constify pnp_device_id and pnp_card_device_id 2017-08-17 12:42:16 +02:00
sc6000.c Annotate hardware config module parameters in sound/isa/ 2017-04-20 12:02:32 +01:00
sscape.c ALSA: sscape: constify pnp_card_device_id 2017-08-17 12:42:31 +02:00