mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Yang Yingliang](/assets/img/avatar_default.png)
Fix the following make W=1 kernel build warning: drivers/net/phy/mdio-boardinfo.c:63: warning: expecting prototype for mdio_register_board_info(). Prototype was for mdiobus_register_board_info() instead Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
80 lines
1.9 KiB
C
80 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* mdio-boardinfo - Collect pre-declarations for MDIO devices
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/export.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/list.h>
|
|
|
|
#include "mdio-boardinfo.h"
|
|
|
|
static LIST_HEAD(mdio_board_list);
|
|
static DEFINE_MUTEX(mdio_board_lock);
|
|
|
|
/**
|
|
* mdiobus_setup_mdiodev_from_board_info - create and setup MDIO devices
|
|
* from pre-collected board specific MDIO information
|
|
* @bus: Bus the board_info belongs to
|
|
* @cb: Callback to create device on bus
|
|
* Context: can sleep
|
|
*/
|
|
void mdiobus_setup_mdiodev_from_board_info(struct mii_bus *bus,
|
|
int (*cb)
|
|
(struct mii_bus *bus,
|
|
struct mdio_board_info *bi))
|
|
{
|
|
struct mdio_board_entry *be;
|
|
struct mdio_board_entry *tmp;
|
|
struct mdio_board_info *bi;
|
|
int ret;
|
|
|
|
mutex_lock(&mdio_board_lock);
|
|
list_for_each_entry_safe(be, tmp, &mdio_board_list, list) {
|
|
bi = &be->board_info;
|
|
|
|
if (strcmp(bus->id, bi->bus_id))
|
|
continue;
|
|
|
|
mutex_unlock(&mdio_board_lock);
|
|
ret = cb(bus, bi);
|
|
mutex_lock(&mdio_board_lock);
|
|
if (ret)
|
|
continue;
|
|
|
|
}
|
|
mutex_unlock(&mdio_board_lock);
|
|
}
|
|
EXPORT_SYMBOL(mdiobus_setup_mdiodev_from_board_info);
|
|
|
|
/**
|
|
* mdiobus_register_board_info - register MDIO devices for a given board
|
|
* @info: array of devices descriptors
|
|
* @n: number of descriptors provided
|
|
* Context: can sleep
|
|
*
|
|
* The board info passed can be marked with __initdata but be pointers
|
|
* such as platform_data etc. are copied as-is
|
|
*/
|
|
int mdiobus_register_board_info(const struct mdio_board_info *info,
|
|
unsigned int n)
|
|
{
|
|
struct mdio_board_entry *be;
|
|
unsigned int i;
|
|
|
|
be = kcalloc(n, sizeof(*be), GFP_KERNEL);
|
|
if (!be)
|
|
return -ENOMEM;
|
|
|
|
for (i = 0; i < n; i++, be++, info++) {
|
|
memcpy(&be->board_info, info, sizeof(*info));
|
|
mutex_lock(&mdio_board_lock);
|
|
list_add_tail(&be->list, &mdio_board_list);
|
|
mutex_unlock(&mdio_board_lock);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(mdiobus_register_board_info);
|