mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
![Tony Luck](/assets/img/avatar_default.png)
Documentation/filesystems/seq_file.rst describes the possible return values from a "show()" function used by single_open(). show_trace() returns the value of "trace_count". This could be interpreted as "SEQ_SKIP", or just confuse the calling function. Change to just return "0" to avoid confusing anyone reading this code and possibly using as a template. Reading "daemon_active" was never an intended use case. Signed-off-by: Tony Luck <tony.luck@intel.com> Signed-off-by: Borislav Petkov <bp@suse.de> Link: https://lore.kernel.org/r/20221018165900.109029-1-tony.luck@intel.com
59 lines
1.1 KiB
C
59 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <linux/debugfs.h>
|
|
#include <linux/ras.h>
|
|
#include "debugfs.h"
|
|
|
|
struct dentry *ras_debugfs_dir;
|
|
|
|
static atomic_t trace_count = ATOMIC_INIT(0);
|
|
|
|
int ras_userspace_consumers(void)
|
|
{
|
|
return atomic_read(&trace_count);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ras_userspace_consumers);
|
|
|
|
static int trace_show(struct seq_file *m, void *v)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int trace_open(struct inode *inode, struct file *file)
|
|
{
|
|
atomic_inc(&trace_count);
|
|
return single_open(file, trace_show, NULL);
|
|
}
|
|
|
|
static int trace_release(struct inode *inode, struct file *file)
|
|
{
|
|
atomic_dec(&trace_count);
|
|
return single_release(inode, file);
|
|
}
|
|
|
|
static const struct file_operations trace_fops = {
|
|
.open = trace_open,
|
|
.read = seq_read,
|
|
.llseek = seq_lseek,
|
|
.release = trace_release,
|
|
};
|
|
|
|
int __init ras_add_daemon_trace(void)
|
|
{
|
|
struct dentry *fentry;
|
|
|
|
if (!ras_debugfs_dir)
|
|
return -ENOENT;
|
|
|
|
fentry = debugfs_create_file("daemon_active", S_IRUSR, ras_debugfs_dir,
|
|
NULL, &trace_fops);
|
|
if (!fentry)
|
|
return -ENODEV;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
void __init ras_debugfs_init(void)
|
|
{
|
|
ras_debugfs_dir = debugfs_create_dir("ras", NULL);
|
|
}
|