Bart Van Assche af07e4dd07 scsi: block: Fix a race in the runtime power management code ... commit fa4d0f1992 upstream. With the current implementation the following race can happen: * blk_pre_runtime_suspend() calls blk_freeze_queue_start() and blk_mq_unfreeze_queue(). * blk_queue_enter() calls blk_queue_pm_only() and that function returns true. * blk_queue_enter() calls blk_pm_request_resume() and that function does not call pm_request_resume() because the queue runtime status is RPM_ACTIVE. * blk_pre_runtime_suspend() changes the queue status into RPM_SUSPENDING. Fix this race by changing the queue runtime status into RPM_SUSPENDING before switching q_usage_counter to atomic mode. Link: https://lore.kernel.org/r/20201209052951.16136-2-bvanassche@acm.org Fixes: 986d413b7c ("blk-mq: Enable support for runtime power management") Cc: Ming Lei <ming.lei@redhat.com> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: stable <stable@vger.kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Jens Axboe <axboe@kernel.dk> Acked-by: Alan Stern <stern@rowland.harvard.edu> Acked-by: Stanley Chu <stanley.chu@mediatek.com> Co-developed-by: Can Guo <cang@codeaurora.org> Signed-off-by: Can Guo <cang@codeaurora.org> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-06 14:48:37 +01:00
..
partitions
badblocks.c
bfq-cgroup.c	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bfq-iosched.c	block: only call sched requeue_request() for scheduled requests	2020-09-23 12:40:37 +02:00
bfq-iosched.h	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bfq-wf2q.c	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bio-integrity.c	block: release bip in a right way in error path	2020-07-16 08:16:36 +02:00
bio.c	block/diskstats: more accurate approximation of io_ticks for slow disks	2020-10-07 08:01:29 +02:00
blk-cgroup.c	blk-cgroup: Pre-allocate tree node on blkg_conf_prep	2020-11-10 12:37:30 +01:00
blk-core.c	block: ratelimit handle_bad_sector() message	2020-10-29 09:58:01 +01:00
blk-exec.c
blk-flush.c
blk-integrity.c
blk-ioc.c	block: Fix use-after-free issue accessing struct io_cq	2020-04-17 10:50:04 +02:00
blk-iocost.c	blk-iocost: ioc_pd_free() shouldn't assume irq disabled	2020-09-09 19:12:35 +02:00
blk-iolatency.c
blk-lib.c
blk-map.c
blk-merge.c	block: fix get_max_io_size()	2020-09-03 11:27:01 +02:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	blk-mq-debugfs: update blk_queue_flag_name[] accordingly for new flags	2020-07-22 09:32:52 +02:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART	2020-09-03 11:27:01 +02:00
blk-mq-sched.h	block: only call sched requeue_request() for scheduled requests	2020-09-23 12:40:37 +02:00
blk-mq-sysfs.c	blk-mq: move cancel of hctx->run_work to the front of blk_exit_queue	2020-10-29 09:57:34 +01:00
blk-mq-tag.c
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c	blk-mq: In blk_mq_dispatch_rq_list() "no budget" is a reason to kick	2020-12-30 11:50:54 +01:00
blk-mq.h
blk-pm.c	scsi: block: Fix a race in the runtime power management code	2021-01-06 14:48:37 +01:00
blk-pm.h
blk-rq-qos.c
blk-rq-qos.h
blk-settings.c
blk-softirq.c
blk-stat.c
blk-stat.h
blk-sysfs.c	blk-mq: move cancel of hctx->run_work to the front of blk_exit_queue	2020-10-29 09:57:34 +01:00
blk-throttle.c
blk-timeout.c
blk-wbt.c
blk-wbt.h
blk-zoned.c	block: Simplify REQ_OP_ZONE_RESET_ALL handling	2020-12-30 11:50:54 +01:00
blk.h
bounce.c
bsg-lib.c
bsg.c
cmdline-parser.c
compat_ioctl.c
elevator.c
genhd.c
ioctl.c
ioprio.c
Kconfig
Kconfig.iosched
kyber-iosched.c
Makefile
mq-deadline.c
opal_proto.h
partition-generic.c
scsi_ioctl.c
sed-opal.c
t10-pi.c