mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
497888cf69
All these are instances of #define NAME value; or #define NAME(params_opt) value; These of course fail to build when used in contexts like if(foo $OP NAME) while(bar $OP NAME) and may silently generate the wrong code in contexts such as foo = NAME + 1; /* foo = value; + 1; */ bar = NAME - 1; /* bar = value; - 1; */ baz = NAME & quux; /* baz = value; & quux; */ Reported on comp.lang.c, Message-ID: <ab0d55fe-25e5-482b-811e-c475aa6065c3@c29g2000yqd.googlegroups.com> Initial analysis of the dangers provided by Keith Thompson in that thread. There are many more instances of more complicated macros having unnecessary trailing semicolons, but this pile seems to be all of the cases of simple values suffering from the problem. (Thus things that are likely to be found in one of the contexts above, more complicated ones aren't.) Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
56 lines
1.6 KiB
C
56 lines
1.6 KiB
C
/*
|
|
* Architecture specific parts of the Floppy driver
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* Copyright (C) 1995 - 2000 Ralf Baechle
|
|
*/
|
|
#ifndef _ASM_FLOPPY_H
|
|
#define _ASM_FLOPPY_H
|
|
|
|
#include <linux/dma-mapping.h>
|
|
|
|
static inline void fd_cacheflush(char * addr, long size)
|
|
{
|
|
dma_cache_sync(NULL, addr, size, DMA_BIDIRECTIONAL);
|
|
}
|
|
|
|
#define MAX_BUFFER_SECTORS 24
|
|
|
|
|
|
/*
|
|
* And on Mips's the CMOS info fails also ...
|
|
*
|
|
* FIXME: This information should come from the ARC configuration tree
|
|
* or wherever a particular machine has stored this ...
|
|
*/
|
|
#define FLOPPY0_TYPE fd_drive_type(0)
|
|
#define FLOPPY1_TYPE fd_drive_type(1)
|
|
|
|
#define FDC1 fd_getfdaddr1()
|
|
|
|
#define N_FDC 1 /* do you *really* want a second controller? */
|
|
#define N_DRIVE 8
|
|
|
|
/*
|
|
* The DMA channel used by the floppy controller cannot access data at
|
|
* addresses >= 16MB
|
|
*
|
|
* Went back to the 1MB limit, as some people had problems with the floppy
|
|
* driver otherwise. It doesn't matter much for performance anyway, as most
|
|
* floppy accesses go through the track buffer.
|
|
*
|
|
* On MIPSes using vdma, this actually means that *all* transfers go thru
|
|
* the * track buffer since 0x1000000 is always smaller than KSEG0/1.
|
|
* Actually this needs to be a bit more complicated since the so much different
|
|
* hardware available with MIPS CPUs ...
|
|
*/
|
|
#define CROSS_64KB(a, s) ((unsigned long)(a)/K_64 != ((unsigned long)(a) + (s) - 1) / K_64)
|
|
|
|
#define EXTRA_FLOPPY_PARAMS
|
|
|
|
#include <floppy.h>
|
|
|
|
#endif /* _ASM_FLOPPY_H */
|