mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Brian Foster](/assets/img/avatar_default.png)
XFS has some inconsistent log message rate limiting with respect to buffer alerts. The metadata I/O error notification uses the generic ratelimited alert, the buffer push code uses a custom rate limit and the similar quiesce time failure checks are not rate limited at all (when they should be). The custom rate limit defined in the buf item code is specifically crafted for buffer alerts. It is more aggressive than generic rate limiting code because it must accommodate a high frequency of I/O error events in a relative short timeframe. Factor out the custom rate limit state from the buf item code into a per-buftarg rate limit so various alerts are limited based on the target. Define a buffer alert helper function and use it for the buffer alerts that are already ratelimited. Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Allison Collins <allison.henderson@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
85 lines
2.9 KiB
C
85 lines
2.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __XFS_MESSAGE_H
|
|
#define __XFS_MESSAGE_H 1
|
|
|
|
struct xfs_mount;
|
|
|
|
extern __printf(2, 3)
|
|
void xfs_emerg(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_alert(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(3, 4)
|
|
void xfs_alert_tag(const struct xfs_mount *mp, int tag, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_crit(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_err(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_warn(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_notice(const struct xfs_mount *mp, const char *fmt, ...);
|
|
extern __printf(2, 3)
|
|
void xfs_info(const struct xfs_mount *mp, const char *fmt, ...);
|
|
|
|
#ifdef DEBUG
|
|
extern __printf(2, 3)
|
|
void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...);
|
|
#else
|
|
static inline __printf(2, 3)
|
|
void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
#define xfs_printk_ratelimited(func, dev, fmt, ...) \
|
|
do { \
|
|
static DEFINE_RATELIMIT_STATE(_rs, \
|
|
DEFAULT_RATELIMIT_INTERVAL, \
|
|
DEFAULT_RATELIMIT_BURST); \
|
|
if (__ratelimit(&_rs)) \
|
|
func(dev, fmt, ##__VA_ARGS__); \
|
|
} while (0)
|
|
|
|
#define xfs_printk_once(func, dev, fmt, ...) \
|
|
({ \
|
|
static bool __section(.data.once) __print_once; \
|
|
bool __ret_print_once = !__print_once; \
|
|
\
|
|
if (!__print_once) { \
|
|
__print_once = true; \
|
|
func(dev, fmt, ##__VA_ARGS__); \
|
|
} \
|
|
unlikely(__ret_print_once); \
|
|
})
|
|
|
|
#define xfs_emerg_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_emerg, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_alert_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_alert, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_crit_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_crit, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_err_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_err, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_warn_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_warn, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_notice_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_notice, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_info_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_info, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_debug_ratelimited(dev, fmt, ...) \
|
|
xfs_printk_ratelimited(xfs_debug, dev, fmt, ##__VA_ARGS__)
|
|
|
|
#define xfs_warn_once(dev, fmt, ...) \
|
|
xfs_printk_once(xfs_warn, dev, fmt, ##__VA_ARGS__)
|
|
#define xfs_notice_once(dev, fmt, ...) \
|
|
xfs_printk_once(xfs_notice, dev, fmt, ##__VA_ARGS__)
|
|
|
|
void assfail(struct xfs_mount *mp, char *expr, char *f, int l);
|
|
void asswarn(struct xfs_mount *mp, char *expr, char *f, int l);
|
|
|
|
extern void xfs_hex_dump(const void *p, int length);
|
|
|
|
void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
|
|
const char *fmt, ...);
|
|
|
|
#endif /* __XFS_MESSAGE_H */
|