Jacob Keller d5b90e99e1 devlink: report 0 after hitting end in region read ... commit fdd41ec21e ("devlink: Return right error code in case of errors for region read") modified the region read code to report errors properly in unexpected cases. In the case where the start_offset and ret_offset match, it unilaterally converted this into an error. This causes an issue for the "dump" version of the command. In this case, the devlink region dump will always report an invalid argument: 000000000000ffd0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff 000000000000ffe0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff devlink answers: Invalid argument 000000000000fff0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff This occurs because the expected flow for the dump is to return 0 after there is no further data. The simplest fix would be to stop converting the error code to -EINVAL if start_offset == ret_offset. However, avoid unnecessary work by checking for when start_offset is larger than the region size and returning 0 upfront. Fixes: fdd41ec21e ("devlink: Return right error code in case of errors for region read") Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-02-05 14:23:20 +01:00
..
bpf_sk_storage.c	bpf: Switch bpf_map ref counter to atomic64_t so bpf_map_inc() never fails	2019-11-18 11:41:59 +01:00
datagram.c	net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram	2019-12-09 09:59:07 +01:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev.c	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
dev_addr_lists.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
dev_ioctl.c	net: Introduce peer to peer one step PTP time stamping.	2019-12-25 19:51:34 -08:00
devlink.c	devlink: report 0 after hitting end in region read	2020-02-05 14:23:20 +01:00
drop_monitor.c	net: drop_monitor: Use kstrdup	2020-01-30 10:03:37 +01:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
filter.c	treewide: remove redundant IS_ERR() before error code check	2020-02-04 03:05:27 +00:00
flow_dissector.c	flow_dissector: Fix to use new variables for port ranges in bpf hook	2020-01-27 11:25:07 +01:00
flow_offload.c	net: core: rename indirect block ingress cb function	2019-12-06 20:45:09 -08:00
gen_estimator.c	net_sched: gen_estimator: extend packet counter to 64bit	2019-11-06 21:51:36 -08:00
gen_stats.c	net_sched: add TCA_STATS_PKT64 attribute	2019-11-05 18:20:55 -08:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: link_watch: prevent starvation when processing linkwatch wq	2019-07-01 19:02:47 -07:00
lwt_bpf.c	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-04 12:27:13 -08:00
lwtunnel.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Makefile	ethtool: move to its own directory	2019-12-12 17:07:05 -08:00
neighbour.c	neigh_stat_seq_next() should increase position index	2020-01-24 11:42:18 +01:00
net-procfs.c	net: procfs: use index hashlist instead of name hashlist	2019-10-01 14:47:19 -07:00
net-sysfs.c	net-sysfs: Call dev_hold always in rx_queue_add_kobject	2019-12-17 22:57:11 -08:00
net-sysfs.h
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
net_namespace.c	netns: Constify exported functions	2020-01-17 13:25:24 +01:00
netclassid_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: fix skb use after free in netpoll	2019-08-27 20:52:02 -07:00
netprio_cgroup.c	netprio: use css ID instead of cgroup ID	2019-11-12 08:18:03 -08:00
page_pool.c	page_pool: help compiler remove code in case CONFIG_NUMA=n	2020-01-02 15:37:52 -08:00
pktgen.c	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	net/core: Do not clear VF index for node/port GUIDs query	2020-01-30 15:20:26 +01:00
scm.c	y2038: socket: remove timespec reference in timestamping	2019-11-15 14:38:29 +01:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	net: Support GRO/GSO fraglist chaining.	2020-01-27 11:00:21 +01:00
skmsg.c	net, sk_msg: Don't check if sock is locked when tearing down psock	2020-01-22 20:30:20 +01:00
sock.c	xsk, net: Make sock_def_readable() have external linkage	2020-01-22 00:08:52 +01:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	bpf: Sockmap, ensure sock lock held during tear down	2020-01-15 23:26:13 +01:00
sock_reuseport.c	soreuseport: Cleanup duplicate initialization of more_reuse->max_socks.	2020-01-27 11:01:16 +01:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net, sysctl: Fix compiler warning when only cBPF is present	2019-12-19 17:17:51 +01:00
timestamping.c	net: Introduce a new MII time stamping interface.	2019-12-25 19:51:33 -08:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-01-24 20:54:30 +01:00
xdp.c	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00