Takeshi Misawa b2f4a59a22 rxrpc: Fix memory leak in rxrpc_lookup_local ... commit b8323f7288 upstream. Commit 9ebeddef58 ("rxrpc: rxrpc_peer needs to hold a ref on the rxrpc_local record") Then release ref in __rxrpc_put_peer and rxrpc_put_peer_locked. struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t gfp) - peer->local = local; + peer->local = rxrpc_get_local(local); rxrpc_discard_prealloc also need ref release in discarding. syzbot report: BUG: memory leak unreferenced object 0xffff8881080ddc00 (size 256): comm "syz-executor339", pid 8462, jiffies 4294942238 (age 12.350s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 0a 00 00 00 00 c0 00 08 81 88 ff ff ................ backtrace: [<000000002b6e495f>] kmalloc include/linux/slab.h:552 [inline] [<000000002b6e495f>] kzalloc include/linux/slab.h:682 [inline] [<000000002b6e495f>] rxrpc_alloc_local net/rxrpc/local_object.c:79 [inline] [<000000002b6e495f>] rxrpc_lookup_local+0x1c1/0x760 net/rxrpc/local_object.c:244 [<000000006b43a77b>] rxrpc_bind+0x174/0x240 net/rxrpc/af_rxrpc.c:149 [<00000000fd447a55>] afs_open_socket+0xdb/0x200 fs/afs/rxrpc.c:64 [<000000007fd8867c>] afs_net_init+0x2b4/0x340 fs/afs/main.c:126 [<0000000063d80ec1>] ops_init+0x4e/0x190 net/core/net_namespace.c:152 [<00000000073c5efa>] setup_net+0xde/0x2d0 net/core/net_namespace.c:342 [<00000000a6744d5b>] copy_net_ns+0x19f/0x3e0 net/core/net_namespace.c:483 [<0000000017d3aec3>] create_new_namespaces+0x199/0x4f0 kernel/nsproxy.c:110 [<00000000186271ef>] unshare_nsproxy_namespaces+0x9b/0x120 kernel/nsproxy.c:226 [<000000002de7bac4>] ksys_unshare+0x2fe/0x5c0 kernel/fork.c:2957 [<00000000349b12ba>] __do_sys_unshare kernel/fork.c:3025 [inline] [<00000000349b12ba>] __se_sys_unshare kernel/fork.c:3023 [inline] [<00000000349b12ba>] __x64_sys_unshare+0x12/0x20 kernel/fork.c:3023 [<000000006d178ef7>] do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 [<00000000637076d4>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: 9ebeddef58 ("rxrpc: rxrpc_peer needs to hold a ref on the rxrpc_local record") Signed-off-by: Takeshi Misawa <jeliantsurux@gmail.com> Reported-and-tested-by: syzbot+305326672fed51b205f7@syzkaller.appspotmail.com Signed-off-by: David Howells <dhowells@redhat.com> Link: https://lore.kernel.org/r/161183091692.3506637.3206605651502458810.stgit@warthog.procyon.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-02-03 23:26:01 +01:00
..
af_rxrpc.c	rxrpc: Fix call interruptibility handling	2020-04-17 10:49:57 +02:00
ar-internal.h	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
call_accept.c	rxrpc: Fix memory leak in rxrpc_lookup_local	2021-02-03 23:26:01 +01:00
call_event.c	rxrpc: Fix afs large storage transmission performance drop	2020-07-09 09:37:52 +02:00
call_object.c	rxrpc: Fix race between recvmsg and sendmsg on immediate call failure	2020-08-11 15:33:40 +02:00
conn_client.c	rxrpc: Fix call interruptibility handling	2020-04-17 10:49:57 +02:00
conn_event.c	rxrpc: Fix some missing _bh annotations on locking conn->state_lock	2020-10-14 10:33:05 +02:00
conn_object.c	rxrpc: Fix race between recvmsg and sendmsg on immediate call failure	2020-08-11 15:33:40 +02:00
conn_service.c	rxrpc: Fix missing security check on incoming calls	2020-01-17 19:49:05 +01:00
input.c	rxrpc: Call state should be read with READ_ONCE() under some circumstances	2021-01-23 15:57:59 +01:00
insecure.c	rxrpc: Fix -Wframe-larger-than= warnings from on-stack crypto	2019-07-30 10:32:35 -07:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
key.c	rxrpc: Fix handling of an unsupported token type in rxrpc_read()	2021-01-23 15:58:00 +01:00
local_event.c	rxrpc: Use the tx-phase skb flag to simplify tracing	2019-08-27 10:04:18 +01:00
local_object.c	rxrpc: Fix DATA Tx to disable nofrag for UDP on AF_INET6 socket	2020-05-02 08:48:47 +02:00
Makefile	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
misc.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
net_ns.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36	2019-05-24 17:27:11 +02:00
output.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
peer_event.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
peer_object.c	rxrpc: Make rxrpc_kernel_get_srtt() indicate validity	2020-09-09 19:12:23 +02:00
proc.c	rxrpc: Adjust /proc/net/rxrpc/calls to display call->debug_id not user_ID	2020-06-24 17:50:37 +02:00
protocol.h	rxrpc: Improve jumbo packet counting	2019-08-27 09:48:37 +01:00
recvmsg.c	rxrpc: Fix race between recvmsg and sendmsg on immediate call failure	2020-08-11 15:33:40 +02:00
rtt.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
rxkad.c	rxrpc: Fix a memory leak in rxkad_verify_response()	2020-05-27 17:46:49 +02:00
security.c	rxrpc: Fix missing security check on incoming calls	2020-01-17 19:49:05 +01:00
sendmsg.c	rxrpc: Fix race between recvmsg and sendmsg on immediate call failure	2020-08-11 15:33:40 +02:00
skbuff.c	rxrpc: Use skb_unshare() rather than skb_cow_data()	2019-08-27 10:13:46 +01:00
sysctl.c	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
utils.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36	2019-05-24 17:27:11 +02:00