Arnd Bergmann b5e8ad92c3 dm integrity: use init_completion instead of COMPLETION_INITIALIZER_ONSTACK ... The new lockdep support for completions causeed the stack usage in dm-integrity to explode, in case of write_journal from 504 bytes to 1120 (using arm gcc-7.1.1): drivers/md/dm-integrity.c: In function 'write_journal': drivers/md/dm-integrity.c:827:1: error: the frame size of 1120 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The problem is that not only the size of 'struct completion' grows significantly, but we end up having multiple copies of it on the stack when we assign it from a local variable after the initial declaration. COMPLETION_INITIALIZER_ONSTACK() is the right thing to use when we want to declare and initialize a completion on the stack. However, this driver doesn't do that and instead initializes the completion just before it is used. In this case, init_completion() does the same thing more efficiently, and drops the stack usage for the function above down to 496 bytes. While the other functions in this file are not bad enough to cause a warning, they benefit equally from the change, so I do the change across the entire file. In the one place where we reuse a completion, I picked the cheaper reinit_completion() over init_completion(). Fixes: cd8084f91c ("locking/lockdep: Apply crossrelease to completions") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Mikulas Patocka <mpatocka@redhat.com> Acked-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>		2017-09-11 11:00:54 -04:00
..
bcache	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-07-03 13:08:04 -07:00
persistent-data	dm space map disk: fix some book keeping in the disk space map	2017-05-15 15:09:50 -04:00
bitmap.c	md/bitmap: don't read page from device with Bitmap_sync	2017-07-10 10:30:41 -07:00
bitmap.h	md: move bitmap_destroy to the beginning of __md_stop	2017-03-16 16:55:58 -07:00
dm-bio-prison-v1.c	dm bio prison: use rb_entry() rather than container_of()	2017-06-19 11:03:50 -04:00
dm-bio-prison-v1.h	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
dm-bio-prison-v2.c	dm bio prison: use rb_entry() rather than container_of()	2017-06-19 11:03:50 -04:00
dm-bio-prison-v2.h	dm bio prison v2: new interface for the bio prison	2017-03-07 11:30:16 -05:00
dm-bio-record.h
dm-bufio.c	dm integrity: optimize writing dm-bufio buffers that are partially changed	2017-08-28 11:47:17 -04:00
dm-bufio.h	dm integrity: optimize writing dm-bufio buffers that are partially changed	2017-08-28 11:47:17 -04:00
dm-builtin.c	dm: move request-based code out to dm-rq.[hc]	2016-06-10 15:15:44 -04:00
dm-cache-background-tracker.c	dm cache: handle kmalloc failure allocating background_tracker struct	2017-05-17 09:44:53 -04:00
dm-cache-background-tracker.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-block-types.h	linux: drop __bitwise__ everywhere	2016-12-16 00:13:41 +02:00
dm-cache-metadata.c	dm cache metadata: fail operations if fail_io mode has been established	2017-05-05 14:40:13 -04:00
dm-cache-metadata.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-policy-internal.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-policy-smq.c	dm cache policy smq: don't do any writebacks unless IDLE	2017-05-14 21:54:33 -04:00
dm-cache-policy.c
dm-cache-policy.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-target.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-core.h	dm: add basic support for using the select or poll function	2017-06-19 11:03:49 -04:00
dm-crypt.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-delay.c	dm: mark targets that pass integrity data	2017-04-24 12:04:32 -04:00
dm-era-target.c	dm block manager: remove an unused argument from dm_block_manager_create()	2017-04-27 17:08:41 -04:00
dm-exception-store.c
dm-exception-store.h
dm-flakey.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-integrity.c	dm integrity: use init_completion instead of COMPLETION_INITIALIZER_ONSTACK	2017-09-11 11:00:54 -04:00
dm-io.c	Merge branch 'for-4.13/block' of git://git.kernel.dk/linux-block	2017-07-03 10:34:51 -07:00
dm-ioctl.c	dm ioctl: constify ioctl lookup table	2017-08-28 11:47:18 -04:00
dm-kcopyd.c	dm kcopyd: add sequential write feature	2017-06-19 11:03:51 -04:00
dm-linear.c	libnvdimm for 4.13	2017-07-07 09:44:06 -07:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c	dm log writes: fix >512b sectorsize support	2017-09-11 10:03:12 -04:00
dm-log.c	block,fs: use REQ_* flags directly	2016-11-01 09:43:26 -06:00
dm-mpath.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c
dm-raid.c	dm raid: bump target version	2017-07-25 14:54:20 -04:00
dm-raid1.c	Merge branch 'for-4.13/block' of git://git.kernel.dk/linux-block	2017-07-03 10:34:51 -07:00
dm-region-hash.c	block: rename bio bi_rw to bi_opf	2016-08-07 14:41:02 -06:00
dm-round-robin.c	dm round robin: revert "use percpu 'repeat_count' and 'current_path'"	2017-02-17 00:54:09 -05:00
dm-rq.c	dm rq: do not update rq partially in each ending bio	2017-08-28 10:23:28 -04:00
dm-rq.h	dm rq: do not update rq partially in each ending bio	2017-08-28 10:23:28 -04:00
dm-service-time.c
dm-snap-persistent.c	dm: make flush bios explicitly sync	2017-05-31 10:50:23 -04:00
dm-snap-transient.c
dm-snap.c	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
dm-stats.c	mm: introduce kv[mz]alloc helpers	2017-05-08 17:15:12 -07:00
dm-stats.h
dm-stripe.c	libnvdimm for 4.13	2017-07-07 09:44:06 -07:00
dm-switch.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-sysfs.c	dm: move request-based code out to dm-rq.[hc]	2016-06-10 15:15:44 -04:00
dm-table.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-target.c	dm: don't return errnos from ->map	2017-06-09 09:27:32 -06:00
dm-thin-metadata.c	dm thin metadata: call precommit before saving the roots	2017-05-15 15:09:49 -04:00
dm-thin-metadata.h	dm thin: fix a race condition between discarding and provisioning a block	2016-07-20 12:43:35 -04:00
dm-thin.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-uevent.c
dm-uevent.h
dm-verity-fec.c	dm verity fec: fix GFP flags used with mempool_alloc()	2017-07-26 15:55:44 -04:00
dm-verity-fec.h	dm verity fec: limit error correction recursion	2017-03-16 09:37:31 -04:00
dm-verity-target.c	dm: constify argument arrays	2017-08-28 11:47:18 -04:00
dm-verity.h	dm verity: switch to using asynchronous hash crypto API	2017-04-24 15:37:04 -04:00
dm-zero.c	dm: don't return errnos from ->map	2017-06-09 09:27:32 -06:00
dm-zoned-metadata.c	dm zoned: use GFP_NOIO in I/O path	2017-07-26 15:55:43 -04:00
dm-zoned-reclaim.c	dm zoned: use GFP_NOIO in I/O path	2017-07-26 15:55:43 -04:00
dm-zoned-target.c	dm zoned: use GFP_NOIO in I/O path	2017-07-26 15:55:43 -04:00
dm-zoned.h	dm zoned: drive-managed zoned block device target	2017-06-19 11:05:20 -04:00
dm.c	dm: fix printk() rate limiting code	2017-08-28 09:58:27 -04:00
dm.h	dm: introduce enum dm_queue_mode to cleanup related code	2017-04-27 17:08:44 -04:00
faulty.c	md: fix deadlock between mddev_suspend() and md_write_start()	2017-06-13 10:18:01 -07:00
Kconfig	dm zoned: drive-managed zoned block device target	2017-06-19 11:05:20 -04:00
linear.c	md: fix deadlock between mddev_suspend() and md_write_start()	2017-06-13 10:18:01 -07:00
linear.h	md linear: fix a race between linear_add() and linear_congested()	2017-02-13 09:17:50 -08:00
Makefile	dm zoned: drive-managed zoned block device target	2017-06-19 11:05:20 -04:00
md-cluster.c	md-cluster: fix potential lock issue in add_new_disk	2017-05-21 20:37:09 -07:00
md-cluster.h	md-cluster: add the support for resize	2017-03-16 16:55:50 -07:00
md.c	MD: not clear ->safemode for external metadata array	2017-08-11 20:42:06 -07:00
md.h	md: raid1-10: move raid1/raid10 common code into raid1-10.c	2017-07-21 12:47:20 -07:00
multipath.c	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md	2017-07-08 12:50:18 -07:00
multipath.h
raid0.c	md: fix deadlock between mddev_suspend() and md_write_start()	2017-06-13 10:18:01 -07:00
raid0.h
raid1-10.c	md: raid1-10: move raid1/raid10 common code into raid1-10.c	2017-07-21 12:47:20 -07:00
raid1.c	md: simplify code with bio_io_error	2017-07-21 13:16:52 -07:00
raid1.h	md/raid1: Use a new variable to count flighting sync requests	2017-04-27 14:01:16 -07:00
raid5-cache.c	md/r5cache: fix io_unit handling in r5l_log_endio()	2017-08-08 07:42:37 -07:00
raid5-log.h	md/r5cache: gracefully handle journal device errors for writeback mode	2017-05-11 22:11:11 -07:00
raid5-ppl.c	raid5-ppl: use BIOSET_NEED_BVECS when creating bioset	2017-07-12 09:26:37 -07:00
raid5.c	md/raid5: add thread_group worker async_tx_issue_pending_all	2017-07-24 07:49:15 -07:00
raid5.h	- A major update for DM cache that reduces the latency for deciding	2017-05-03 10:31:20 -07:00
raid10.c	md: simplify code with bio_io_error	2017-07-21 13:16:52 -07:00
raid10.h	md/raid10: simplify the splitting of requests.	2017-04-11 10:13:02 -07:00