linux-stable/drivers/usb
Jerry Zhang 5421694d8c usb: gadget: f_fs: Only return delayed status when len is 0
commit 4d644abf25 upstream.

Commit 1b9ba000 ("Allow function drivers to pause control
transfers") states that USB_GADGET_DELAYED_STATUS is only
supported if data phase is 0 bytes.

It seems that when the length is not 0 bytes, there is no
need to explicitly delay the data stage since the transfer
is not completed until the user responds. However, when the
length is 0, there is no data stage and the transfer is
finished once setup() returns, hence there is a need to
explicitly delay completion.

This manifests as the following bugs:

Prior to 946ef68ad4 ('Let setup() return
USB_GADGET_DELAYED_STATUS'), when setup is 0 bytes, ffs
would require user to queue a 0 byte request in order to
clear setup state. However, that 0 byte request was actually
not needed and would hang and cause errors in other setup
requests.

After the above commit, 0 byte setups work since the gadget
now accepts empty queues to ep0 to clear the delay, but all
other setups hang.

Fixes: 946ef68ad4 ("Let setup() return USB_GADGET_DELAYED_STATUS")
Signed-off-by: Jerry Zhang <zhangjerry@google.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-28 07:55:44 +02:00
..
atm License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
c67x00 c67x00-hcd: constify hc_driver structures 2017-07-30 07:26:52 -07:00
chipidea USB: chipidea: msm: fix ulpi-node lookup 2018-01-02 20:31:14 +01:00
class usb: cdc_acm: Add quirk for Castles VEGA3000 2018-07-28 07:55:44 +02:00
common USB: ulpi: fix bus-node lookup 2017-12-10 13:40:44 +01:00
core usb: core: handle hub C_PORT_OVER_CURRENT condition 2018-07-28 07:55:44 +02:00
dwc2 usb: dwc2: Fix DMA alignment to start at allocated boundary 2018-07-28 07:55:44 +02:00
dwc3 usb: dwc3: Makefile: fix link error on randconfig 2018-05-25 16:17:39 +02:00
early USB: early: Use new USB product ID and strings for DbC device 2017-11-21 09:49:21 +01:00
gadget usb: gadget: f_fs: Only return delayed status when len is 0 2018-07-28 07:55:44 +02:00
host xhci: Fix perceived dead host due to runtime suspend race with event handler 2018-07-25 11:25:11 +02:00
image License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
isp1760 License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
misc USB: yurex: fix out-of-bounds uaccess in read handler 2018-07-17 11:39:26 +02:00
mon usb: usbmon: Read text within supplied buffer size 2018-03-19 08:42:46 +01:00
mtu3 usb: mtu3: fix error return code in ssusb_gadget_init() 2017-12-10 13:40:41 +01:00
musb usb: musb: fix remote wakeup racing with suspend 2018-06-21 04:02:59 +09:00
phy usb: phy: tahvo: fix error handling in tahvo_usb_probe() 2017-12-10 13:40:40 +01:00
renesas_usbhs usb: renesas_usbhs: missed the "running" flag in usb_dmac with rx path 2018-02-28 10:19:43 +01:00
serial USB: serial: mos7840: fix status-register error handling 2018-07-17 11:39:26 +02:00
storage usb-storage: Add compatibility quirk flags for G-Technologies G-Drive 2018-06-16 09:45:15 +02:00
typec usb: typec: ucsi: Fix for incorrect status data issue 2018-07-08 15:30:47 +02:00
usbip usbip: vhci_sysfs: fix potential Spectre v1 2018-06-16 09:45:15 +02:00
wusbcore License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Kconfig usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT 2018-02-22 15:42:31 +01:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
README
usb-skeleton.c

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.