mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 07:04:24 +00:00
Code Issues Releases Wiki Activity
No description
839862 commits 105 branches 5103 tags 5.6 GiB
C 97.6%
Assembly 1%
Shell 0.5%
Python 0.3%
Makefile 0.3%
Find a file
Maxime Chevallier b73484b2fc ethtool: Check for vlan etype or vlan tci when parsing flow_rule 
When parsing an ethtool flow spec to build a flow_rule, the code checks
if both the vlan etype and the vlan tci are specified by the user to add
a FLOW_DISSECTOR_KEY_VLAN match.

However, when the user only specified a vlan etype or a vlan tci, this
check silently ignores these parameters.

For example, the following rule :

ethtool -N eth0 flow-type udp4 vlan 0x0010 action -1 loc 0

will result in no error being issued, but the equivalent rule will be
created and passed to the NIC driver :

ethtool -N eth0 flow-type udp4 action -1 loc 0

In the end, neither the NIC driver using the rule nor the end user have
a way to know that these keys were dropped along the way, or that
incorrect parameters were entered.

This kind of check should be left to either the driver, or the ethtool
flow spec layer.

This commit makes so that ethtool parameters are forwarded as-is to the
NIC driver.

Since none of the users of ethtool_rx_flow_rule_create are using the
VLAN dissector, I don't think this qualifies as a regression.

Fixes: eca4205f9e ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Acked-by: Pablo Neira Ayuso <pablo@gnumonks.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-05-30 15:04:55 -07:00
arch First round of arm64 fixes for -rc2 2019-05-22 08:36:16 -07:00
block
certs
crypto SPDX update for 5.2-rc2, round 1 2019-05-21 12:33:38 -07:00
Documentation Documentation: net-sysfs: Remove duplicate PHY device documentation 2019-05-28 17:26:44 -07:00
drivers net: mvpp2: fix bad MVPP2_TXQ_SCHED_TOKEN_CNTR_REG queue value 2019-05-30 14:31:13 -07:00
fs Fix a gfs2 sign extension bug introduced in v4.3. 2019-05-22 08:31:09 -07:00
include udp: Avoid post-GRO UDP checksum recalculation 2019-05-30 11:10:39 -07:00
init
ipc
kernel SPDX update for 5.2-rc2, round 1 2019-05-21 12:33:38 -07:00
lib SPDX update for 5.2-rc2, round 1 2019-05-21 12:33:38 -07:00
LICENSES
mm
net ethtool: Check for vlan etype or vlan tci when parsing flow_rule 2019-05-30 15:04:55 -07:00
samples treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13 2019-05-21 11:28:45 +02:00
scripts SPDX update for 5.2-rc2, round 1 2019-05-21 12:33:38 -07:00
security selinux/stable-5.2 PR 20190521 2019-05-21 12:51:20 -07:00
sound treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13 2019-05-21 11:28:45 +02:00
tools selftests: pmtu: Fix encapsulating device in pmtu_vti6_link_change_mtu 2019-05-28 17:15:06 -07:00
usr
virt
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS
Makefile
README

README 

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.