mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 10:29:37 +00:00
29396cd573
This patch resolves some undefined behavior where variables in expr_id_data were accessed (for debugging) without being defined. To better enforce the tagged union behavior, the struct is moved into expr.c and accessors provided. Tag values (kinds) are explicitly identified. Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-By: Kajol Jain<kjain@linux.ibm.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Link: https://lore.kernel.org/r/20200826153055.2067780-1-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
51 lines
1.5 KiB
C
51 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef PARSE_CTX_H
|
|
#define PARSE_CTX_H 1
|
|
|
|
// There are fixes that need to land upstream before we can use libbpf's headers,
|
|
// for now use our copy uncoditionally, since the data structures at this point
|
|
// are exactly the same, no problem.
|
|
//#ifdef HAVE_LIBBPF_SUPPORT
|
|
//#include <bpf/hashmap.h>
|
|
//#else
|
|
#include "util/hashmap.h"
|
|
//#endif
|
|
|
|
struct metric_ref;
|
|
|
|
struct expr_id {
|
|
char *id;
|
|
struct expr_id *parent;
|
|
};
|
|
|
|
struct expr_parse_ctx {
|
|
struct hashmap ids;
|
|
struct expr_id *parent;
|
|
};
|
|
|
|
struct expr_id_data;
|
|
|
|
struct expr_scanner_ctx {
|
|
int start_token;
|
|
int runtime;
|
|
};
|
|
|
|
void expr__ctx_init(struct expr_parse_ctx *ctx);
|
|
void expr__ctx_clear(struct expr_parse_ctx *ctx);
|
|
void expr__del_id(struct expr_parse_ctx *ctx, const char *id);
|
|
int expr__add_id(struct expr_parse_ctx *ctx, const char *id);
|
|
int expr__add_id_val(struct expr_parse_ctx *ctx, const char *id, double val);
|
|
int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref);
|
|
int expr__get_id(struct expr_parse_ctx *ctx, const char *id,
|
|
struct expr_id_data **data);
|
|
int expr__resolve_id(struct expr_parse_ctx *ctx, const char *id,
|
|
struct expr_id_data **datap);
|
|
int expr__parse(double *final_val, struct expr_parse_ctx *ctx,
|
|
const char *expr, int runtime);
|
|
int expr__find_other(const char *expr, const char *one,
|
|
struct expr_parse_ctx *ids, int runtime);
|
|
|
|
double expr_id_data__value(const struct expr_id_data *data);
|
|
struct expr_id *expr_id_data__parent(struct expr_id_data *data);
|
|
|
|
#endif
|