mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
44d89409a1
The idea behind keeping the saturation mask local to a context backfired
spectacularly. The premise with the local mask was that we would be more
proactive in attempting to use semaphores after each time the context
idled, and that all new contexts would attempt to use semaphores
ignoring the current state of the system. This turns out to be horribly
optimistic. If the system state is still oversaturated and the existing
workloads have all stopped using semaphores, the new workloads would
attempt to use semaphores and be deprioritised behind real work. The
new contexts would not switch off using semaphores until their initial
batch of low priority work had completed. Given sufficient backload load
of equal user priority, this would completely starve the new work of any
GPU time.
To compensate, remove the local tracking in favour of keeping it as
global state on the engine -- once the system is saturated and
semaphores are disabled, everyone stops attempting to use semaphores
until the system is idle again. One of the reason for preferring local
context tracking was that it worked with virtual engines, so for
switching to global state we could either do a complete check of all the
virtual siblings or simply disable semaphores for those requests. This
takes the simpler approach of disabling semaphores on virtual engines.
The downside is that the decision that the engine is saturated is a
local measure -- we are only checking whether or not this context was
scheduled in a timely fashion, it may be legitimately delayed due to user
priorities. We still have the same dilemma though, that we do not want
to employ the semaphore poll unless it will be used.
v2: Explain why we need to assume the worst wrt virtual engines.
Fixes: ca6e56f654 ("drm/i915: Disable semaphore busywaits on saturated systems")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Cc: Dmitry Ermilov <dmitry.ermilov@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190618074153.16055-8-chris@chris-wilson.co.uk
68 lines
1.4 KiB
C
68 lines
1.4 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef __INTEL_CONTEXT_TYPES__
|
|
#define __INTEL_CONTEXT_TYPES__
|
|
|
|
#include <linux/kref.h>
|
|
#include <linux/list.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/types.h>
|
|
|
|
#include "i915_active_types.h"
|
|
#include "intel_engine_types.h"
|
|
#include "intel_sseu.h"
|
|
|
|
struct i915_gem_context;
|
|
struct i915_vma;
|
|
struct intel_context;
|
|
struct intel_ring;
|
|
|
|
struct intel_context_ops {
|
|
int (*pin)(struct intel_context *ce);
|
|
void (*unpin)(struct intel_context *ce);
|
|
|
|
void (*enter)(struct intel_context *ce);
|
|
void (*exit)(struct intel_context *ce);
|
|
|
|
void (*reset)(struct intel_context *ce);
|
|
void (*destroy)(struct kref *kref);
|
|
};
|
|
|
|
struct intel_context {
|
|
struct kref ref;
|
|
|
|
struct i915_gem_context *gem_context;
|
|
struct intel_engine_cs *engine;
|
|
struct intel_engine_cs *inflight;
|
|
|
|
struct list_head signal_link;
|
|
struct list_head signals;
|
|
|
|
struct i915_vma *state;
|
|
struct intel_ring *ring;
|
|
|
|
u32 *lrc_reg_state;
|
|
u64 lrc_desc;
|
|
|
|
unsigned int active_count; /* notionally protected by timeline->mutex */
|
|
|
|
atomic_t pin_count;
|
|
struct mutex pin_mutex; /* guards pinning and associated on-gpuing */
|
|
|
|
/**
|
|
* active: Active tracker for the rq activity (inc. external) on this
|
|
* intel_context object.
|
|
*/
|
|
struct i915_active active;
|
|
|
|
const struct intel_context_ops *ops;
|
|
|
|
/** sseu: Control eu/slice partitioning */
|
|
struct intel_sseu sseu;
|
|
};
|
|
|
|
#endif /* __INTEL_CONTEXT_TYPES__ */
|