linux-stable/drivers/media
Adam Sampson 7291d99ebc media: usbtv: fix brightness and contrast controls
[ Upstream commit b3168c87c0 ]

Because the brightness and contrast controls share a register,
usbtv_s_ctrl needs to read the existing values for both controls before
inserting the new value. However, the code accidentally wrote to the
registers (from an uninitialised stack array), rather than reading them.

The user-visible effect of this was that adjusting the brightness would
also set the contrast to a random value, and vice versa -- so it wasn't
possible to correctly adjust the brightness of usbtv's video output.

Tested with an "EasyDAY" UTV007 device.

Fixes: c53a846c48 ("usbtv: add video controls")

Signed-off-by: Adam Sampson <ats@offog.org>
Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-12-20 10:10:29 +01:00
..
cec
common
dvb-core dvb_frontend: don't use-after-free the frontend struct 2017-12-17 15:08:01 +01:00
dvb-frontends
firewire
i2c
mmc
pci
platform media: camss-vfe: always initialize reg at vfe_set_xbar_cfg() 2017-12-20 10:10:27 +01:00
radio
rc media: rc: partial revert of "media: rc: per-protocol repeat period" 2017-12-14 09:53:00 +01:00
spi
tuners
usb media: usbtv: fix brightness and contrast controls 2017-12-20 10:10:29 +01:00
v4l2-core v4l2: disable filesystem-dax mapping support 2017-12-05 11:26:29 +01:00
Kconfig
Makefile
media-device.c
media-devnode.c
media-entity.c