Matthias Kaehlcke 60b6fd81e2 thermal: cpu_cooling: Actually trace CPU load in thermal_power_cpu_get_power ... [ Upstream commit bf45ac18b7 ] The CPU load values passed to the thermal_power_cpu_get_power tracepoint are zero for all CPUs, unless, unless the thermal_power_cpu_limit tracepoint is enabled too: irq/41-rockchip-98 [000] .... 290.972410: thermal_power_cpu_get_power: cpus=0000000f freq=1800000 load={{0x0,0x0,0x0,0x0}} dynamic_power=4815 vs irq/41-rockchip-96 [000] .... 95.773585: thermal_power_cpu_get_power: cpus=0000000f freq=1800000 load={{0x56,0x64,0x64,0x5e}} dynamic_power=4959 irq/41-rockchip-96 [000] .... 95.773596: thermal_power_cpu_limit: cpus=0000000f freq=408000 cdev_state=10 power=416 There seems to be no good reason for omitting the CPU load information depending on another tracepoint. My guess is that the intention was to check whether thermal_power_cpu_get_power is (still) enabled, however 'load_cpu != NULL' already indicates that it was at least enabled when cpufreq_get_requested_power() was entered, there seems little gain from omitting the assignment if the tracepoint was just disabled, so just remove the check. Fixes: 6828a4711f ("thermal: add trace events to the power allocator governor") Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Javi Merino <javi.merino@kernel.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Eduardo Valentin <edubezval@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-01-27 14:50:48 +01:00
..
broadcom
int340x_thermal
qcom
samsung
st
tegra
ti-soc-thermal
armada_thermal.c	thermal: armada: fix a test in probe()	2019-12-01 09:16:54 +01:00
clock_cooling.c
cpu_cooling.c	thermal: cpu_cooling: Actually trace CPU load in thermal_power_cpu_get_power	2020-01-27 14:50:48 +01:00
da9062-thermal.c
db8500_thermal.c
devfreq_cooling.c
dove_thermal.c
fair_share.c
gov_bang_bang.c
hisi_thermal.c
imx_thermal.c
intel_bxt_pmic_thermal.c
intel_pch_thermal.c
intel_powerclamp.c
intel_quark_dts_thermal.c
intel_soc_dts_iosf.c
intel_soc_dts_iosf.h
intel_soc_dts_thermal.c
Kconfig
kirkwood_thermal.c
Makefile
max77620_thermal.c
mtk_thermal.c	thermal: mediatek: fix register index error	2020-01-27 14:50:19 +01:00
of-thermal.c
power_allocator.c
qcom-spmi-temp-alarm.c
qoriq_thermal.c
rcar_gen3_thermal.c	thermal: rcar_gen3_thermal: fix interrupt type	2020-01-27 14:50:48 +01:00
rcar_thermal.c	thermal: rcar_thermal: Prevent hardware access during system suspend	2019-12-01 09:17:00 +01:00
rockchip_thermal.c
spear_thermal.c
step_wise.c
tango_thermal.c
thermal-generic-adc.c
thermal_core.c	thermal: Fix deadlock in thermal thermal_zone_device_check	2019-12-13 08:52:50 +01:00
thermal_core.h
thermal_helpers.c
thermal_hwmon.c	thermal_hwmon: Sanitize thermal_zone type	2019-10-11 18:21:19 +02:00
thermal_hwmon.h
thermal_sysfs.c
uniphier_thermal.c
user_space.c
x86_pkg_temp_thermal.c
zx2967_thermal.c