Vasily Averin 15e0db6e61 ipc/util.c: sysvipc_find_ipc() incorrectly updates position index ... [ Upstream commit 5e698222c7 ] Commit 89163f93c6 ("ipc/util.c: sysvipc_find_ipc() should increase position index") is causing this bug (seen on 5.6.8): # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages # ipcmk -Q Message queue id: 0 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x82db8127 0 root 644 0 0 # ipcmk -Q Message queue id: 1 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x82db8127 0 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcrm -q 0 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x76d1fb2a 1 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcmk -Q Message queue id: 2 # ipcrm -q 2 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x76d1fb2a 1 root 644 0 0 0x76d1fb2a 1 root 644 0 0 # ipcmk -Q Message queue id: 3 # ipcrm -q 1 # ipcs -q ------ Message Queues -------- key msqid owner perms used-bytes messages 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 0x7c982867 3 root 644 0 0 Whenever an IPC item with a low id is deleted, the items with higher ids are duplicated, as if filling a hole. new_pos should jump through hole of unused ids, pos can be updated inside "for" cycle. Fixes: 89163f93c6 ("ipc/util.c: sysvipc_find_ipc() should increase position index") Reported-by: Andreas Schwab <schwab@suse.de> Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Waiman Long <longman@redhat.com> Cc: NeilBrown <neilb@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Oberparleiter <oberpar@linux.ibm.com> Cc: Davidlohr Bueso <dave@stgolabs.net> Cc: Manfred Spraul <manfred@colorfullife.com> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/4921fe9b-9385-a2b4-1dc4-1099be6d2e39@virtuozzo.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-05-20 08:18:40 +02:00
..
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ipc_sysctl.c	ipc/msg: increase MSGMNI, remove scaling	2014-12-13 12:42:52 -08:00
mq_sysctl.c	ipc: convert use of typedef ctl_table to struct ctl_table	2014-06-06 16:08:16 -07:00
mqueue.c	ipc/mqueue.c: change __do_notify() to bypass check_kill_permission()	2020-05-14 07:57:23 +02:00
msg.c	ipc/msg.c: consolidate all xxxctl_down() functions	2020-02-11 04:33:55 -08:00
msgutil.c	ipc: prevent lockup on alloc_msg and free_msg	2019-06-15 11:54:00 +02:00
namespace.c	ipc: simplify ipc initialization	2018-08-22 10:52:52 -07:00
sem.c	Revert "ipc,sem: remove uneeded sem_undo_list lock usage in exit_sem()"	2020-02-28 16:38:49 +01:00
shm.c	ipc/shm.c: use ERR_CAST() for shm_lock() error return	2018-10-05 16:32:04 -07:00
syscall.c	y2038: ipc: Redirect ipc(SEMTIMEDOP, ...) to compat_ksys_semtimedop	2018-04-20 16:20:30 +02:00
util.c	ipc/util.c: sysvipc_find_ipc() incorrectly updates position index	2020-05-20 08:18:40 +02:00
util.h	ipc/util.c: update return value of ipc_getref from int to bool	2018-08-22 10:52:52 -07:00