Anna Schumaker 26e8bfa30d SUNRPC/TLS: Lock the lower_xprt during the tls handshake ... Otherwise we run the risk of having the lower_xprt freed from underneath us, causing an oops that looks like this: [ 224.150698] BUG: kernel NULL pointer dereference, address: 0000000000000018 [ 224.150951] #PF: supervisor read access in kernel mode [ 224.151117] #PF: error_code(0x0000) - not-present page [ 224.151278] PGD 0 P4D 0 [ 224.151361] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 224.151499] CPU: 2 PID: 99 Comm: kworker/u10:6 Not tainted 6.6.0-rc3-g6465e260f487 #41264 a00b0960990fb7bc6d6a330ee03588b67f08a47b [ 224.151977] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS unknown 2/2/2022 [ 224.152216] Workqueue: xprtiod xs_tcp_tls_setup_socket [sunrpc] [ 224.152434] RIP: 0010:xs_tcp_tls_setup_socket+0x3cc/0x7e0 [sunrpc] [ 224.152643] Code: 00 00 48 8b 7c 24 08 e9 f3 01 00 00 48 83 7b c0 00 0f 85 d2 01 00 00 49 8d 84 24 f8 05 00 00 48 89 44 24 10 48 8b 00 48 89 c5 <4c> 8b 68 18 66 41 83 3f 0a 75 71 45 31 ff 4c 89 ef 31 f6 e8 5c 76 [ 224.153246] RSP: 0018:ffffb00ec060fd18 EFLAGS: 00010246 [ 224.153427] RAX: 0000000000000000 RBX: ffff8c06c2e53e40 RCX: 0000000000000001 [ 224.153652] RDX: ffff8c073bca2408 RSI: 0000000000000282 RDI: ffff8c06c259ee00 [ 224.153868] RBP: 0000000000000000 R08: ffffffff9da55aa0 R09: 0000000000000001 [ 224.154084] R10: 00000034306c30f1 R11: 0000000000000002 R12: ffff8c06c2e51800 [ 224.154300] R13: ffff8c06c355d400 R14: 0000000004208160 R15: ffff8c06c2e53820 [ 224.154521] FS: 0000000000000000(0000) GS:ffff8c073bd00000(0000) knlGS:0000000000000000 [ 224.154763] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 224.154940] CR2: 0000000000000018 CR3: 0000000062c1e000 CR4: 0000000000750ee0 [ 224.155157] PKRU: 55555554 [ 224.155244] Call Trace: [ 224.155325] <TASK> [ 224.155395] ? __die_body+0x68/0xb0 [ 224.155507] ? page_fault_oops+0x34c/0x3a0 [ 224.155635] ? _raw_spin_unlock_irqrestore+0xe/0x40 [ 224.155793] ? exc_page_fault+0x7a/0x1b0 [ 224.155916] ? asm_exc_page_fault+0x26/0x30 [ 224.156047] ? xs_tcp_tls_setup_socket+0x3cc/0x7e0 [sunrpc ae3a15912ae37fd51dafbdbc2dbd069117f8f5c8] [ 224.156367] ? xs_tcp_tls_setup_socket+0x2fe/0x7e0 [sunrpc ae3a15912ae37fd51dafbdbc2dbd069117f8f5c8] [ 224.156697] ? __pfx_xs_tls_handshake_done+0x10/0x10 [sunrpc ae3a15912ae37fd51dafbdbc2dbd069117f8f5c8] [ 224.157013] process_scheduled_works+0x24e/0x450 [ 224.157158] worker_thread+0x21c/0x2d0 [ 224.157275] ? __pfx_worker_thread+0x10/0x10 [ 224.157409] kthread+0xe8/0x110 [ 224.157510] ? __pfx_kthread+0x10/0x10 [ 224.157628] ret_from_fork+0x37/0x50 [ 224.157741] ? __pfx_kthread+0x10/0x10 [ 224.157859] ret_from_fork_asm+0x1b/0x30 [ 224.157983] </TASK> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>		2023-09-27 15:16:40 -04:00
..
6lowpan
9p	net: annotate data-races around sock->ops	2023-08-09 15:32:43 -07:00
802
8021q	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
appletalk	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
atm	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
ax25	ax25: Kconfig: Update link for linux-ax25.org	2023-09-18 12:56:58 +01:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-24 10:51:39 -07:00
bluetooth	TTY/Serial driver changes for 6.6-rc1	2023-09-01 09:38:00 -07:00
bpf	bpf: Prevent inlining of bpf_fentry_test7()	2023-08-30 08:36:17 +02:00
bpfilter
bridge	net: bridge: use DEV_STATS_INC()	2023-09-19 13:35:15 +02:00
caif	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
can	net: annotate data-races around sk->sk_tsflags	2023-09-01 07:27:33 +01:00
ceph	libceph: do not include crypto/algapi.h	2023-08-24 11:24:37 +02:00
core	net: core: Use the bitmap API to allocate bitmaps	2023-09-16 13:32:30 +01:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-01 21:07:46 -07:00
dccp	dccp: fix dccp_v4_err()/dccp_v6_err() again	2023-09-18 07:10:31 +01:00
devlink	devlink: move devlink_notify_register/unregister() to dev.c	2023-08-28 08:02:24 -07:00
dns_resolver
dsa	net: dsa: mark parsed interface mode for legacy switch drivers	2023-08-09 13:08:09 -07:00
ethernet
ethtool	ethtool: netlink: always pass genl_info to .prepare_data	2023-08-15 15:01:03 -07:00
handshake	net/handshake: Fix memory leak in __sock_create() and sock_alloc_file()	2023-09-20 11:54:49 +01:00
hsr	net: hsr: Add __packed to struct hsr_sup_tlv.	2023-09-18 08:26:19 +01:00
ieee802154	sysctl-6.6-rc1	2023-08-29 17:39:15 -07:00
ife
ipv4	ipv4: fix null-deref in ipv4_link_failure	2023-09-17 15:14:58 +01:00
ipv6	Including fixes from netfilter and bpf.	2023-09-07 18:33:07 -07:00
iucv
kcm	kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().	2023-09-14 10:43:51 +02:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
l2tp	inet: introduce inet->inet_flags	2023-08-16 11:09:16 +01:00
l3mdev
lapb
llc	net/llc/llc_conn.c: fix 4 instances of -Wmissing-variable-declarations	2023-08-09 15:34:28 -07:00
mac80211	wireless-next patches for v6.6	2023-08-25 18:35:09 -07:00
mac802154	Core WPAN changes:	2023-06-24 15:41:46 -07:00
mctp	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
mpls	networking: Update to register_net_sysctl_sz	2023-08-15 15:26:18 -07:00
mptcp	mptcp: fix dangling connection hang-up	2023-09-18 12:47:56 +01:00
ncsi	ncsi: Propagate carrier gain/loss events to the NCSI controller	2023-09-18 07:06:05 +01:00
netfilter	netfilter: ipset: Fix race between IPSET_CMD_CREATE and IPSET_CMD_SWAP	2023-09-20 10:35:24 +02:00
netlabel	netlabel: Remove unused declaration netlbl_cipsov4_doi_free()	2023-08-02 12:28:22 -07:00
netlink	genetlink: add a family pointer to struct genl_info	2023-08-15 15:01:03 -07:00
netrom	netrom: Deny concurrent connect().	2023-08-28 06:58:46 +01:00
nfc	TTY/Serial driver changes for 6.6-rc1	2023-09-01 09:38:00 -07:00
nsh
openvswitch	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-18 12:44:56 -07:00
packet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-10 14:10:53 -07:00
phonet	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
psample
qrtr	net: qrtr: Handle IPCR control port format of older targets	2023-07-17 09:02:30 +01:00
rds	net: rds: Fix possible NULL-pointer dereference	2023-09-20 08:49:03 +01:00
rfkill
rose	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
rxrpc	Networking changes for 6.5.	2023-06-28 16:43:10 -07:00
sched	net: sched: sch_qfq: Fix UAF in qfq_dequeue()	2023-09-05 08:54:12 +02:00
sctp	Including fixes from netfilter and bpf.	2023-09-07 18:33:07 -07:00
smc	net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add	2023-09-10 19:31:42 +01:00
strparser
sunrpc	SUNRPC/TLS: Lock the lower_xprt during the tls handshake	2023-09-27 15:16:40 -04:00
switchdev	net: switchdev: Add a helper to replay objects on a bridge port	2023-07-21 08:54:03 +01:00
tipc	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
tls	net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()	2023-09-12 09:51:49 +02:00
unix	Including fixes from netfilter and bpf.	2023-09-07 18:33:07 -07:00
vmw_vsock	vsock: Remove unused function declarations	2023-07-31 14:41:08 -07:00
wireless	wifi: nl80211: Remove unused declaration nl80211_pmsr_dump_results()	2023-08-22 21:40:40 +02:00
x25	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
xdp	xsk: Fix xsk_diag use-after-free error during socket cleanup	2023-08-31 13:21:11 +02:00
xfrm	sysctl-6.6-rc1	2023-08-29 17:39:15 -07:00
compat.c
devres.c
Kconfig	bpf: Add fd-based tcx multi-prog infra with link support	2023-07-19 10:07:27 -07:00
Kconfig.debug
Makefile
socket.c	Including fixes from netfilter and bpf.	2023-09-07 18:33:07 -07:00
sysctl_net.c	sysctl: Add size to register_net_sysctl function	2023-08-15 15:26:17 -07:00