Cong Wang cef0845b6d l2tp: close all race conditions in l2tp_tunnel_register() ... [ Upstream commit 0b2c59720e ] The code in l2tp_tunnel_register() is racy in several ways: 1. It modifies the tunnel socket _after_ publishing it. 2. It calls setup_udp_tunnel_sock() on an existing socket without locking. 3. It changes sock lock class on fly, which triggers many syzbot reports. This patch amends all of them by moving socket initialization code before publishing and under sock lock. As suggested by Jakub, the l2tp lockdep class is not necessary as we can just switch to bh_lock_sock_nested(). Fixes: 37159ef2c1 ("l2tp: fix a lockdep splat") Fixes: 6b9f34239b ("l2tp: fix races in tunnel creation") Reported-by: syzbot+52866e24647f9a23403f@syzkaller.appspotmail.com Reported-by: syzbot+94cc2a66fc228b23f360@syzkaller.appspotmail.com Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Guillaume Nault <gnault@redhat.com> Cc: Jakub Sitnicki <jakub@cloudflare.com> Cc: Eric Dumazet <edumazet@google.com> Cc: Tom Parkin <tparkin@katalix.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com> Reviewed-by: Guillaume Nault <gnault@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-02-01 08:34:19 +01:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
l2tp_core.c	l2tp: close all race conditions in l2tp_tunnel_register()	2023-02-01 08:34:19 +01:00
l2tp_core.h	net/l2tp: convert tunnel rwlock_t to rcu	2021-11-29 12:11:25 +00:00
l2tp_debugfs.c	l2tp: l2tp_debugfs: fix Clang -Wformat warnings	2022-07-08 12:14:36 +01:00
l2tp_eth.c	l2tp: move from strlcpy with unused retval to strscpy	2022-08-22 17:59:46 -07:00
l2tp_ip.c	l2tp: use add READ_ONCE() to fetch sk->sk_bound_dev_if	2022-05-16 10:31:06 +01:00
l2tp_ip6.c	ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg	2022-06-08 10:56:43 -07:00
l2tp_netlink.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
l2tp_ppp.c	net: l2tp: fix clang -Wformat warning	2022-07-07 18:07:01 -07:00
Makefile	l2tp: add tracepoint infrastructure to core	2020-08-22 12:44:37 -07:00
trace.h	l2tp: add tracepoint definitions in trace.h	2020-08-22 12:44:37 -07:00