mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
![Uwe Kleine-König](/assets/img/avatar_default.png)
The driver core ignores the return value of struct device_driver::remove because there is only little that can be done. To simplify the quest to make this function return void, let struct sunxi_rsb_driver::remove return void, too. All users already unconditionally return 0, this commit makes this obvious and ensures future users don't behave differently. To simplify even further, make axp20x_device_remove() return void instead of returning 0 unconditionally, too. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Signed-off-by: Lee Jones <lee.jones@linaro.org>
114 lines
2.8 KiB
C
114 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* I2C driver for the X-Powers' Power Management ICs
|
|
*
|
|
* AXP20x typically comprises an adaptive USB-Compatible PWM charger, BUCK DC-DC
|
|
* converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature
|
|
* as well as configurable GPIOs.
|
|
*
|
|
* This driver supports the I2C variants.
|
|
*
|
|
* Copyright (C) 2014 Carlo Caione
|
|
*
|
|
* Author: Carlo Caione <carlo@caione.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/err.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mfd/axp20x.h>
|
|
#include <linux/of.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
|
|
static int axp20x_i2c_probe(struct i2c_client *i2c,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct axp20x_dev *axp20x;
|
|
int ret;
|
|
|
|
axp20x = devm_kzalloc(&i2c->dev, sizeof(*axp20x), GFP_KERNEL);
|
|
if (!axp20x)
|
|
return -ENOMEM;
|
|
|
|
axp20x->dev = &i2c->dev;
|
|
axp20x->irq = i2c->irq;
|
|
dev_set_drvdata(axp20x->dev, axp20x);
|
|
|
|
ret = axp20x_match_device(axp20x);
|
|
if (ret)
|
|
return ret;
|
|
|
|
axp20x->regmap = devm_regmap_init_i2c(i2c, axp20x->regmap_cfg);
|
|
if (IS_ERR(axp20x->regmap)) {
|
|
ret = PTR_ERR(axp20x->regmap);
|
|
dev_err(&i2c->dev, "regmap init failed: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return axp20x_device_probe(axp20x);
|
|
}
|
|
|
|
static int axp20x_i2c_remove(struct i2c_client *i2c)
|
|
{
|
|
struct axp20x_dev *axp20x = i2c_get_clientdata(i2c);
|
|
|
|
axp20x_device_remove(axp20x);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id axp20x_i2c_of_match[] = {
|
|
{ .compatible = "x-powers,axp152", .data = (void *)AXP152_ID },
|
|
{ .compatible = "x-powers,axp202", .data = (void *)AXP202_ID },
|
|
{ .compatible = "x-powers,axp209", .data = (void *)AXP209_ID },
|
|
{ .compatible = "x-powers,axp221", .data = (void *)AXP221_ID },
|
|
{ .compatible = "x-powers,axp223", .data = (void *)AXP223_ID },
|
|
{ .compatible = "x-powers,axp803", .data = (void *)AXP803_ID },
|
|
{ .compatible = "x-powers,axp806", .data = (void *)AXP806_ID },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match);
|
|
#endif
|
|
|
|
static const struct i2c_device_id axp20x_i2c_id[] = {
|
|
{ "axp152", 0 },
|
|
{ "axp202", 0 },
|
|
{ "axp209", 0 },
|
|
{ "axp221", 0 },
|
|
{ "axp223", 0 },
|
|
{ "axp803", 0 },
|
|
{ "axp806", 0 },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
|
|
{
|
|
.id = "INT33F4",
|
|
.driver_data = AXP288_ID,
|
|
},
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, axp20x_i2c_acpi_match);
|
|
#endif
|
|
|
|
static struct i2c_driver axp20x_i2c_driver = {
|
|
.driver = {
|
|
.name = "axp20x-i2c",
|
|
.of_match_table = of_match_ptr(axp20x_i2c_of_match),
|
|
.acpi_match_table = ACPI_PTR(axp20x_i2c_acpi_match),
|
|
},
|
|
.probe = axp20x_i2c_probe,
|
|
.remove = axp20x_i2c_remove,
|
|
.id_table = axp20x_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(axp20x_i2c_driver);
|
|
|
|
MODULE_DESCRIPTION("PMIC MFD I2C driver for AXP20X");
|
|
MODULE_AUTHOR("Carlo Caione <carlo@caione.org>");
|
|
MODULE_LICENSE("GPL");
|