Darrick J. Wong be78ff0e72 xfs: recheck reflink / dirty page status before freeing CoW reservations ... Eryu Guan reported seeing occasional hangs when running generic/269 with a new fsstress that supports clonerange/deduperange. The cause of this hang is an infinite loop when we convert the CoW fork extents from unwritten to real just prior to writing the pages out; the infinite loop happens because there's nothing in the CoW fork to convert, and so it spins forever. The fundamental issue here is that when we go to perform these CoW fork conversions, we're supposed to have an extent waiting for us, but the low space CoW reaper has snuck in and blown them away! There are four conditions that can dissuade the reaper from touching our file -- no reflink iflag; dirty page cache; writeback in progress; or directio in progress. We check the four conditions prior to taking the locks, but we neglect to recheck them once we have the locks, which is how we end up whacking the writeback that's in progress. Therefore, refactor the four checks into a helper function and call it once again once we have the locks to make sure we really want to reap the inode. While we're at it, add an ASSERT for this weird condition so that we'll fail noisily if we ever screw this up again. Reported-by: Eryu Guan <eguan@redhat.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Tested-by: Eryu Guan <eguan@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com>		2018-01-17 21:00:47 -08:00
..
xfs_ag_resv.c	xfs: move error injection tags into their own file	2017-11-01 15:03:16 -07:00
xfs_ag_resv.h	xfs: set up per-AG free space reservations	2016-09-19 10:30:52 +10:00
xfs_alloc.c	xfs: add scrub cross-referencing helpers for the free space btrees	2018-01-17 21:00:44 -08:00
xfs_alloc.h	xfs: add scrub cross-referencing helpers for the free space btrees	2018-01-17 21:00:44 -08:00
xfs_alloc_btree.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_alloc_btree.h
xfs_attr.c	xfs: cancel tx on xfs_defer_finish() error during xattr set/remove	2018-01-16 14:53:28 -08:00
xfs_attr_leaf.c	xfs: attr leaf verifier needs to check for obviously bad count	2018-01-17 21:00:46 -08:00
xfs_attr_leaf.h	xfs: create structure verifier function for shortform xattrs	2018-01-08 10:54:46 -08:00
xfs_attr_remote.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_attr_remote.h
xfs_attr_sf.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_bit.c	libxfs: Optimize the loop for xfs_bitmap_empty	2016-01-04 16:10:19 +11:00
xfs_bit.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_bmap.c	xfs: recheck reflink / dirty page status before freeing CoW reservations	2018-01-17 21:00:47 -08:00
xfs_bmap.h	xfs: simplify xfs_reflink_convert_cow	2017-11-06 11:53:40 -08:00
xfs_bmap_btree.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_bmap_btree.h	xfs: pass struct xfs_bmbt_irec to xfs_bmbt_validate_extent	2017-11-06 11:53:41 -08:00
xfs_btree.c	xfs: add scrub cross-referencing helpers for the free space btrees	2018-01-17 21:00:44 -08:00
xfs_btree.h	xfs: add scrub cross-referencing helpers for the free space btrees	2018-01-17 21:00:44 -08:00
xfs_cksum.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_da_btree.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_da_btree.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_da_format.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_da_format.h	xfs: refactor the geometry structure filling function	2018-01-08 10:54:48 -08:00
xfs_defer.c	xfs: add the ability to join a held buffer to a defer_ops	2017-12-14 09:17:35 -08:00
xfs_defer.h	xfs: add the ability to join a held buffer to a defer_ops	2017-12-14 09:17:35 -08:00
xfs_dir2.c	xfs: refactor the geometry structure filling function	2018-01-08 10:54:48 -08:00
xfs_dir2.h	xfs: directory scrubber must walk through data block to offset	2018-01-17 21:00:46 -08:00
xfs_dir2_block.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_dir2_data.c	xfs: directory scrubber must walk through data block to offset	2018-01-17 21:00:46 -08:00
xfs_dir2_leaf.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_dir2_node.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_dir2_priv.h	xfs: refactor short form directory structure verifier function	2018-01-08 10:54:46 -08:00
xfs_dir2_sf.c	xfs: directory scrubber must walk through data block to offset	2018-01-17 21:00:46 -08:00
xfs_dquot_buf.c	xfs: standardize quota verification function outputs	2018-01-08 10:54:47 -08:00
xfs_errortag.h	xfs: move error injection tags into their own file	2017-11-01 15:03:16 -07:00
xfs_format.h	xfs: remove u_int* type usage	2017-11-09 15:50:29 -08:00
xfs_fs.h	xfs: scrub quota information	2017-10-26 15:38:26 -07:00
xfs_ialloc.c	xfs: add scrub cross-referencing helpers for the inode btrees	2018-01-17 21:00:44 -08:00
xfs_ialloc.h	xfs: add scrub cross-referencing helpers for the inode btrees	2018-01-17 21:00:44 -08:00
xfs_ialloc_btree.c	xfs: account finobt blocks properly in perag reservation	2018-01-12 14:09:08 -08:00
xfs_ialloc_btree.h	xfs: use per-AG reservations for the finobt	2017-01-25 07:49:35 -08:00
xfs_iext_tree.c	xfs: move xfs_iext_insert tracepoint to report useful information	2017-12-14 09:20:11 -08:00
xfs_inode_buf.c	xfs: move inode fork verifiers to xfs_dinode_verify	2018-01-08 10:54:46 -08:00
xfs_inode_buf.h	xfs: have buffer verifier functions report failing address	2018-01-08 10:54:46 -08:00
xfs_inode_fork.c	xfs: btree format ifork loader should check for zero numrecs	2018-01-17 21:00:46 -08:00
xfs_inode_fork.h	xfs: provide a centralized method for verifying inline fork data	2018-01-08 10:54:47 -08:00
xfs_log_format.h	xfs: fix type usage	2017-11-16 12:06:45 -08:00
xfs_log_recover.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_log_rlimit.c	xfs: trace log reservations at mount time	2018-01-08 10:54:47 -08:00
xfs_quota_defs.h	xfs: standardize quota verification function outputs	2018-01-08 10:54:47 -08:00
xfs_refcount.c	xfs: add scrub cross-referencing helpers for the refcount btrees	2018-01-17 21:00:44 -08:00
xfs_refcount.h	xfs: add scrub cross-referencing helpers for the refcount btrees	2018-01-17 21:00:44 -08:00
xfs_refcount_btree.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_refcount_btree.h	xfs: use the actual AG length when reserving blocks	2017-01-03 18:39:33 -08:00
xfs_rmap.c	xfs: add scrub cross-referencing helpers for the rmap btrees	2018-01-17 21:00:44 -08:00
xfs_rmap.h	xfs: add scrub cross-referencing helpers for the rmap btrees	2018-01-17 21:00:44 -08:00
xfs_rmap_btree.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_rmap_btree.h	xfs: use the actual AG length when reserving blocks	2017-01-03 18:39:33 -08:00
xfs_rtbitmap.c	xfs: cross-reference the realtime bitmap	2018-01-17 21:00:46 -08:00
xfs_sb.c	xfs: fix check on struct_version for versions 4 or greater	2018-01-12 14:09:08 -08:00
xfs_sb.h	xfs: refactor the geometry structure filling function	2018-01-08 10:54:48 -08:00
xfs_shared.h	xfs: trace log reservations at mount time	2018-01-08 10:54:47 -08:00
xfs_symlink_remote.c	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_trans_resv.c	xfs: eliminate duplicate icreate tx reservation functions	2018-01-08 10:41:38 -08:00
xfs_trans_resv.h	xfs: increase log reservations for reflink	2016-10-05 16:26:29 -07:00
xfs_trans_space.h	xfs: reserve enough blocks to handle btree splits when remapping	2017-05-03 13:21:40 -07:00
xfs_types.h	xfs: move xfs_bmbt_irec and xfs_exntst_t to xfs_types.h	2017-11-06 11:53:41 -08:00