mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
![]() parport_pc_probe_port() creates the own 'parport_pc' device if the device argument is NULL. Then parport_pc_probe_port() doesn't initialize the dma_mask and coherent_dma_mask of the device and calls dma_alloc_coherent with it. dma_alloc_coherent fails because dma_alloc_coherent() doesn't accept the uninitialized dma_mask: http://lkml.org/lkml/2009/6/16/150 Long ago, X86_32 and X86_64 had the own dma_alloc_coherent implementations; X86_32 accepted a device having dma_mask that is not initialized however X86_64 didn't. When we merged them, we chose to prohibit a device having dma_mask that is not initialized. I think that it's good to require drivers to set up dma_mask (and coherent_dma_mask) properly if the drivers want DMA. Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Reported-by: Malcom Blaney <malcolm.blaney@maptek.com.au> Tested-by: Malcom Blaney <malcolm.blaney@maptek.com.au> Cc: stable@kernel.org Signed-off-by: Alan Cox <alan@linux.intel.com> Acked-by: Jeff Garzik <jgarzik@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
BUGS-parport | ||
ChangeLog | ||
daisy.c | ||
ieee1284.c | ||
ieee1284_ops.c | ||
Kconfig | ||
Makefile | ||
multiface.h | ||
parport_amiga.c | ||
parport_atari.c | ||
parport_ax88796.c | ||
parport_cs.c | ||
parport_gsc.c | ||
parport_gsc.h | ||
parport_ip32.c | ||
parport_mfc3.c | ||
parport_pc.c | ||
parport_serial.c | ||
parport_sunbpp.c | ||
probe.c | ||
procfs.c | ||
share.c | ||
TODO-parport |