linux-stable/include/linux/power
Hans de Goede c00bc80462 power: supply: bq27xxx: Fix poll_interval handling and races on remove
Before this patch bq27xxx_battery_teardown() was setting poll_interval = 0
to avoid bq27xxx_battery_update() requeuing the delayed_work item.

There are 2 problems with this:

1. If the driver is unbound through sysfs, rather then the module being
   rmmod-ed, this changes poll_interval unexpectedly

2. This is racy, after it being set poll_interval could be changed
   before bq27xxx_battery_update() checks it through
   /sys/module/bq27xxx_battery/parameters/poll_interval

Fix this by added a removed attribute to struct bq27xxx_device_info and
using that instead of setting poll_interval to 0.

There also is another poll_interval related race on remove(), writing
/sys/module/bq27xxx_battery/parameters/poll_interval will requeue
the delayed_work item for all devices on the bq27xxx_battery_devices
list and the device being removed was only removed from that list
after cancelling the delayed_work item.

Fix this by moving the removal from the bq27xxx_battery_devices list
to before cancelling the delayed_work item.

Fixes: 8cfaaa8118 ("bq27x00_battery: Fix OOPS caused by unregistring bq27x00 driver")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
2023-05-08 15:29:11 +02:00
..
bq27xxx_battery.h power: supply: bq27xxx: Fix poll_interval handling and races on remove 2023-05-08 15:29:11 +02:00
bq2415x_charger.h
bq24190_charger.h
bq24735-charger.h
bq25890_charger.h power: supply: bq25890: Add support for registering the Vbus boost converter as a regulator 2022-02-01 14:55:12 +01:00
charger-manager.h
gpio-charger.h
jz4740-battery.h
max17042_battery.h
sbs-battery.h
smartreflex.h ARM: omap2: smartreflex: remove on_init control 2023-01-09 17:00:54 +01:00
twl4030_madc_battery.h