Tang Junhui f07b6505f4 bcache: fix kcrashes with fio in RAID5 backend dev ... [ Upstream commit 60eb34ec55 ] Kernel crashed when run fio in a RAID5 backend bcache device, the call trace is bellow: [ 440.012034] kernel BUG at block/blk-ioc.c:146! [ 440.012696] invalid opcode: 0000 [#1] SMP NOPTI [ 440.026537] CPU: 2 PID: 2205 Comm: md127_raid5 Not tainted 4.15.0 #8 [ 440.027441] Hardware name: HP ProLiant MicroServer Gen8, BIOS J06 07/16 /2015 [ 440.028615] RIP: 0010:put_io_context+0x8b/0x90 [ 440.029246] RSP: 0018:ffffa8c882b43af8 EFLAGS: 00010246 [ 440.029990] RAX: 0000000000000000 RBX: ffffa8c88294fca0 RCX: 0000000000 0f4240 [ 440.031006] RDX: 0000000000000004 RSI: 0000000000000286 RDI: ffffa8c882 94fca0 [ 440.032030] RBP: ffffa8c882b43b10 R08: 0000000000000003 R09: ffff949cb8 0c1700 [ 440.033206] R10: 0000000000000104 R11: 000000000000b71c R12: 00000000000 01000 [ 440.034222] R13: 0000000000000000 R14: ffff949cad84db70 R15: ffff949cb11 bd1e0 [ 440.035239] FS: 0000000000000000(0000) GS:ffff949cba280000(0000) knlGS: 0000000000000000 [ 440.060190] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 440.084967] CR2: 00007ff0493ef000 CR3: 00000002f1e0a002 CR4: 00000000001 606e0 [ 440.110498] Call Trace: [ 440.135443] bio_disassociate_task+0x1b/0x60 [ 440.160355] bio_free+0x1b/0x60 [ 440.184666] bio_put+0x23/0x30 [ 440.208272] search_free+0x23/0x40 [bcache] [ 440.231448] cached_dev_write_complete+0x31/0x70 [bcache] [ 440.254468] closure_put+0xb6/0xd0 [bcache] [ 440.277087] request_endio+0x30/0x40 [bcache] [ 440.298703] bio_endio+0xa1/0x120 [ 440.319644] handle_stripe+0x418/0x2270 [raid456] [ 440.340614] ? load_balance+0x17b/0x9c0 [ 440.360506] handle_active_stripes.isra.58+0x387/0x5a0 [raid456] [ 440.380675] ? __release_stripe+0x15/0x20 [raid456] [ 440.400132] raid5d+0x3ed/0x5d0 [raid456] [ 440.419193] ? schedule+0x36/0x80 [ 440.437932] ? schedule_timeout+0x1d2/0x2f0 [ 440.456136] md_thread+0x122/0x150 [ 440.473687] ? wait_woken+0x80/0x80 [ 440.491411] kthread+0x102/0x140 [ 440.508636] ? find_pers+0x70/0x70 [ 440.524927] ? kthread_associate_blkcg+0xa0/0xa0 [ 440.541791] ret_from_fork+0x35/0x40 [ 440.558020] Code: c2 48 00 5b 41 5c 41 5d 5d c3 48 89 c6 4c 89 e7 e8 bb c2 48 00 48 8b 3d bc 36 4b 01 48 89 de e8 7c f7 e0 ff 5b 41 5c 41 5d 5d c3 <0f> 0b 0f 1f 00 0f 1f 44 00 00 55 48 8d 47 b8 48 89 e5 41 57 41 [ 440.610020] RIP: put_io_context+0x8b/0x90 RSP: ffffa8c882b43af8 [ 440.628575] ---[ end trace a1fd79d85643a73e ]-- All the crash issue happened when a bypass IO coming, in such scenario s->iop.bio is pointed to the s->orig_bio. In search_free(), it finishes the s->orig_bio by calling bio_complete(), and after that, s->iop.bio became invalid, then kernel would crash when calling bio_put(). Maybe its upper layer's faulty, since bio should not be freed before we calling bio_put(), but we'd better calling bio_put() first before calling bio_complete() to notify upper layer ending this bio. This patch moves bio_complete() under bio_put() to avoid kernel crash. [mlyle: fixed commit subject for character limits] Reported-by: Matthias Ferdinand <bcache@mfedv.net> Tested-by: Matthias Ferdinand <bcache@mfedv.net> Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn> Reviewed-by: Michael Lyle <mlyle@lyle.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-05-30 07:52:05 +02:00
..
bcache	bcache: fix kcrashes with fio in RAID5 backend dev	2018-05-30 07:52:05 +02:00
persistent-data	dm btree: fix serious bug in btree_split_beneath()	2018-01-23 19:58:18 +01:00
bitmap.c	md: free unused memory after bitmap resize	2017-12-17 15:08:00 +01:00
bitmap.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dm-bio-prison-v1.c	dm bio prison: use rb_entry() rather than container_of()	2017-06-19 11:03:50 -04:00
dm-bio-prison-v1.h	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
dm-bio-prison-v2.c	dm bio prison: use rb_entry() rather than container_of()	2017-06-19 11:03:50 -04:00
dm-bio-prison-v2.h	dm bio prison v2: new interface for the bio prison	2017-03-07 11:30:16 -05:00
dm-bio-record.h	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-bufio.c	dm bufio: avoid false-positive Wmaybe-uninitialized warning	2018-03-15 10:54:33 +01:00
dm-bufio.h	dm integrity: optimize writing dm-bufio buffers that are partially changed	2017-08-28 11:47:17 -04:00
dm-builtin.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dm-cache-background-tracker.c	dm cache: handle kmalloc failure allocating background_tracker struct	2017-05-17 09:44:53 -04:00
dm-cache-background-tracker.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-block-types.h	linux: drop __bitwise__ everywhere	2016-12-16 00:13:41 +02:00
dm-cache-metadata.c	dm cache metadata: fail operations if fail_io mode has been established	2017-05-05 14:40:13 -04:00
dm-cache-metadata.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-policy-internal.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-policy-smq.c	dm cache policy smq: don't do any writebacks unless IDLE	2017-05-14 21:54:33 -04:00
dm-cache-policy.c
dm-cache-policy.h	dm cache: significant rework to leverage dm-bio-prison-v2	2017-03-07 13:28:31 -05:00
dm-cache-target.c	dm: fix various targets to dm_register_target after module __init resources created	2017-12-20 10:10:21 +01:00
dm-core.h	dm: allocate struct mapped_device with kvzalloc	2017-11-30 08:40:43 +00:00
dm-crypt.c	dm crypt: limit the number of allocated pages	2018-04-24 09:36:31 +02:00
dm-delay.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-era-target.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-exception-store.c
dm-exception-store.h
dm-flakey.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-integrity.c	dm integrity: use kvfree for kvmalloc'd memory	2018-05-16 10:10:27 +02:00
dm-io.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-ioctl.c	dm ioctl: fix alignment of event number in the device list	2017-09-25 11:18:29 -04:00
dm-kcopyd.c	dm kcopyd: add sequential write feature	2017-06-19 11:03:51 -04:00
dm-linear.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c
dm-log-userspace-transfer.h
dm-log-writes.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-log.c	block,fs: use REQ_* flags directly	2016-11-01 09:43:26 -06:00
dm-mpath.c	dm mpath: return DM_MAPIO_REQUEUE on blk-mq rq allocation failure	2018-04-26 11:02:07 +02:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c
dm-raid.c	dm raid: fix raid set size revalidation	2018-03-19 08:42:54 +01:00
dm-raid1.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-region-hash.c	block: rename bio bi_rw to bi_opf	2016-08-07 14:41:02 -06:00
dm-round-robin.c	dm round robin: revert "use percpu 'repeat_count' and 'current_path'"	2017-02-17 00:54:09 -05:00
dm-rq.c	dm rq: do not update rq partially in each ending bio	2017-08-28 10:23:28 -04:00
dm-rq.h	dm rq: do not update rq partially in each ending bio	2017-08-28 10:23:28 -04:00
dm-service-time.c
dm-snap-persistent.c	dm: make flush bios explicitly sync	2017-05-31 10:50:23 -04:00
dm-snap-transient.c
dm-snap.c	dm: fix various targets to dm_register_target after module __init resources created	2017-12-20 10:10:21 +01:00
dm-stats.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dm-stats.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dm-stripe.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-switch.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-sysfs.c
dm-table.c	dm: discard support requires all targets in a table support discards	2017-11-30 08:40:43 +00:00
dm-target.c	dm: don't return errnos from ->map	2017-06-09 09:27:32 -06:00
dm-thin-metadata.c	dm thin metadata: THIN_MAX_CONCURRENT_LOCKS should be 6	2018-01-23 19:58:18 +01:00
dm-thin-metadata.h	dm thin: fix a race condition between discarding and provisioning a block	2016-07-20 12:43:35 -04:00
dm-thin.c	dm: fix various targets to dm_register_target after module __init resources created	2017-12-20 10:10:21 +01:00
dm-uevent.c
dm-uevent.h
dm-verity-fec.c	dm verity fec: fix GFP flags used with mempool_alloc()	2017-07-26 15:55:44 -04:00
dm-verity-fec.h	dm verity fec: limit error correction recursion	2017-03-16 09:37:31 -04:00
dm-verity-target.c	- Some request-based DM core and DM multipath fixes and cleanups	2017-09-14 13:43:16 -07:00
dm-verity.h	dm verity: switch to using asynchronous hash crypto API	2017-04-24 15:37:04 -04:00
dm-zero.c	dm: don't return errnos from ->map	2017-06-09 09:27:32 -06:00
dm-zoned-metadata.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
dm-zoned-reclaim.c	dm zoned: use GFP_NOIO in I/O path	2017-07-26 15:55:43 -04:00
dm-zoned-target.c	dm zoned: ignore last smaller runt zone	2017-11-30 08:40:42 +00:00
dm-zoned.h	dm zoned: drive-managed zoned block device target	2017-06-19 11:05:20 -04:00
dm.c	dm: correctly handle chained bios in dec_pending()	2018-02-22 15:42:29 +01:00
dm.h	dm: introduce enum dm_queue_mode to cleanup related code	2017-04-27 17:08:44 -04:00
faulty.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
Kconfig	dm zoned: drive-managed zoned block device target	2017-06-19 11:05:20 -04:00
linear.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
linear.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
md-cluster.c	md-cluster: fix potential lock issue in add_new_disk	2017-05-21 20:37:09 -07:00
md-cluster.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
md.c	md: fix a potential deadlock of raid5/raid10 reshape	2018-05-30 07:52:03 +02:00
md.h	md: fix md_write_start() deadlock w/o metadata devices	2018-05-30 07:51:57 +02:00
multipath.c	block: replace bi_bdev with a gendisk pointer and partitions index	2017-08-23 12:49:55 -06:00
multipath.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid0.c	Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md	2017-09-07 12:41:48 -07:00
raid0.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid1-10.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid1.c	md/raid1: fix NULL pointer dereference	2018-05-30 07:52:03 +02:00
raid1.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid5-cache.c	md/r5cache: move mddev_lock() out of r5c_journal_mode_set()	2017-12-14 09:52:59 +01:00
raid5-log.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid5-ppl.c	raid5-ppl: check recovery_offset when performing ppl recovery	2017-12-20 10:10:36 +01:00
raid5.c	md: fix a potential deadlock of raid5/raid10 reshape	2018-05-30 07:52:03 +02:00
raid5.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raid10.c	md: fix a potential deadlock of raid5/raid10 reshape	2018-05-30 07:52:03 +02:00
raid10.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00