Stefano Garzarella c070c1912a vhost-vdpa: fix an iotlb memory leak ... Before commit 3d56987938 ("vhost-vdpa: introduce asid based IOTLB") we called vhost_vdpa_iotlb_unmap(v, iotlb, 0ULL, 0ULL - 1) during release to free all the resources allocated when processing user IOTLB messages through vhost_vdpa_process_iotlb_update(). That commit changed the handling of IOTLB a bit, and we accidentally removed some code called during the release. We partially fixed this with commit 037d430556 ("vhost-vdpa: call vhost_vdpa_cleanup during the release") but a potential memory leak is still there as showed by kmemleak if the application does not send VHOST_IOTLB_INVALIDATE or crashes: unreferenced object 0xffff888007fbaa30 (size 16): comm "blkio-bench", pid 914, jiffies 4294993521 (age 885.500s) hex dump (first 16 bytes): 40 73 41 07 80 88 ff ff 00 00 00 00 00 00 00 00 @sA............. backtrace: [<0000000087736d2a>] kmem_cache_alloc_trace+0x142/0x1c0 [<0000000060740f50>] vhost_vdpa_process_iotlb_msg+0x68c/0x901 [vhost_vdpa] [<0000000083e8e205>] vhost_chr_write_iter+0xc0/0x4a0 [vhost] [<000000008f2f414a>] vhost_vdpa_chr_write_iter+0x18/0x20 [vhost_vdpa] [<00000000de1cd4a0>] vfs_write+0x216/0x4b0 [<00000000a2850200>] ksys_write+0x71/0xf0 [<00000000de8e720b>] __x64_sys_write+0x19/0x20 [<0000000018b12cbb>] do_syscall_64+0x3f/0x90 [<00000000986ec465>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Let's fix this calling vhost_vdpa_iotlb_unmap() on the whole range in vhost_vdpa_remove_as(). We move that call before vhost_dev_cleanup() since we need a valid v->vdev.mm in vhost_vdpa_pa_unmap(). vhost_iotlb_reset() call can be removed, since vhost_vdpa_iotlb_unmap() on the whole range removes all the entries. The kmemleak log reported was observed with a vDPA device that has `use_va` set to true (e.g. VDUSE). This patch has been tested with both types of devices. Fixes: 037d430556 ("vhost-vdpa: call vhost_vdpa_cleanup during the release") Fixes: 3d56987938 ("vhost-vdpa: introduce asid based IOTLB") Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20221109154213.146789-1-sgarzare@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>		2022-12-28 05:28:10 -05:00
..
iotlb.c	vhost_iotlb: split out IOTLB initialization	2022-05-31 12:44:28 -04:00
Kconfig	vhost_vdpa: implement IRQ offloading in vhost_vdpa	2020-08-05 11:08:42 -04:00
Makefile	vhost: introduce vDPA-based backend	2020-04-02 10:41:40 -04:00
net.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
scsi.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
test.c	vhost: rename vhost_work_dev_flush	2022-05-31 12:45:10 -04:00
test.h	tools/virtio: Add --reset	2020-06-22 12:34:21 -04:00
vdpa.c	vhost-vdpa: fix an iotlb memory leak	2022-12-28 05:28:10 -05:00
vhost.c	vhost: fix range used in translate_desc()	2022-12-28 05:28:10 -05:00
vhost.h	vhost: rename vhost_work_dev_flush	2022-05-31 12:45:10 -04:00
vringh.c	vringh: fix range used in iotlb_translate()	2022-12-28 05:28:10 -05:00
vsock.c	vhost/vsock: Fix error handling in vhost_vsock_init()	2022-12-28 05:28:10 -05:00