mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
d799769188
When ld detects unaligned relocations, it emits R_PPC64_UADDR64
relocations instead of R_PPC64_RELATIVE. Currently R_PPC64_UADDR64 are
detected by arch/powerpc/tools/relocs_check.sh and expected not to work.
Below is a simple chunk to trigger this behaviour (this disables
optimization for the demonstration purposes only, this also happens with
-O1/-O2 when CONFIG_PRINTK_INDEX=y, for example):
\#pragma GCC push_options
\#pragma GCC optimize ("O0")
struct entry {
const char *file;
int line;
} __attribute__((packed));
static const struct entry e1 = { .file = __FILE__, .line = __LINE__ };
static const struct entry e2 = { .file = __FILE__, .line = __LINE__ };
...
prom_printf("e1=%s %lx %lx\n", e1.file, (unsigned long) e1.file, mfmsr());
prom_printf("e2=%s %lx\n", e2.file, (unsigned long) e2.file);
\#pragma GCC pop_options
This adds support for UADDR64 for 64bit. This reuses __dynamic_symtab
from the 32bit code which supports more relocation types already.
Because RELACOUNT includes only R_PPC64_RELATIVE, this replaces it with
RELASZ which is the size of all relocation records.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220309061822.168173-1-aik@ozlabs.ru
57 lines
1.3 KiB
Bash
Executable file
57 lines
1.3 KiB
Bash
Executable file
#!/bin/sh
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
# Copyright © 2015 IBM Corporation
|
|
|
|
|
|
# This script checks the relocations of a vmlinux for "suspicious"
|
|
# relocations.
|
|
|
|
# based on relocs_check.pl
|
|
# Copyright © 2009 IBM Corporation
|
|
|
|
if [ $# -lt 3 ]; then
|
|
echo "$0 [path to objdump] [path to nm] [path to vmlinux]" 1>&2
|
|
exit 1
|
|
fi
|
|
|
|
# Have Kbuild supply the path to objdump and nm so we handle cross compilation.
|
|
objdump="$1"
|
|
nm="$2"
|
|
vmlinux="$3"
|
|
|
|
# Remove from the bad relocations those that match an undefined weak symbol
|
|
# which will result in an absolute relocation to 0.
|
|
# Weak unresolved symbols are of that form in nm output:
|
|
# " w _binary__btf_vmlinux_bin_end"
|
|
undef_weak_symbols=$($nm "$vmlinux" | awk '$1 ~ /w/ { print $2 }')
|
|
|
|
bad_relocs=$(
|
|
$objdump -R "$vmlinux" |
|
|
# Only look at relocation lines.
|
|
grep -E '\<R_' |
|
|
# These relocations are okay
|
|
# On PPC64:
|
|
# R_PPC64_RELATIVE, R_PPC64_NONE
|
|
# On PPC:
|
|
# R_PPC_RELATIVE, R_PPC_ADDR16_HI,
|
|
# R_PPC_ADDR16_HA,R_PPC_ADDR16_LO,
|
|
# R_PPC_NONE
|
|
grep -F -w -v 'R_PPC64_RELATIVE
|
|
R_PPC64_NONE
|
|
R_PPC64_UADDR64
|
|
R_PPC_ADDR16_LO
|
|
R_PPC_ADDR16_HI
|
|
R_PPC_ADDR16_HA
|
|
R_PPC_RELATIVE
|
|
R_PPC_NONE' |
|
|
([ "$undef_weak_symbols" ] && grep -F -w -v "$undef_weak_symbols" || cat)
|
|
)
|
|
|
|
if [ -z "$bad_relocs" ]; then
|
|
exit 0
|
|
fi
|
|
|
|
num_bad=$(echo "$bad_relocs" | wc -l)
|
|
echo "WARNING: $num_bad bad relocations"
|
|
echo "$bad_relocs"
|