mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Maarten Lankhorst](/assets/img/avatar_default.png)
We need to get rid of allocations in the cmd parser, because it needs to be called from a signaling context, first move all pinning to execbuf, where we already hold all locks. Allocate jump_whitelist in the execbuffer, and add annotations around intel_engine_cmd_parser(), to ensure we only call the command parser without allocating any memory, or taking any locks we're not supposed to. Because i915_gem_object_get_page() may also allocate memory, add a path to i915_gem_object_get_sg() that prevents memory allocations, and walk the sg list manually. It should be similarly fast. This has the added benefit of being able to catch all memory allocation errors before the point of no return, and return -ENOMEM safely to the execbuf submitter. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20210323155059.628690-4-maarten.lankhorst@linux.intel.com
34 lines
1.2 KiB
C
34 lines
1.2 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef __I915_MEMCPY_H__
|
|
#define __I915_MEMCPY_H__
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct drm_i915_private;
|
|
|
|
void i915_memcpy_init_early(struct drm_i915_private *i915);
|
|
|
|
bool i915_memcpy_from_wc(void *dst, const void *src, unsigned long len);
|
|
void i915_unaligned_memcpy_from_wc(void *dst, const void *src, unsigned long len);
|
|
|
|
/* The movntdqa instructions used for memcpy-from-wc require 16-byte alignment,
|
|
* as well as SSE4.1 support. i915_memcpy_from_wc() will report if it cannot
|
|
* perform the operation. To check beforehand, pass in the parameters to
|
|
* to i915_can_memcpy_from_wc() - since we only care about the low 4 bits,
|
|
* you only need to pass in the minor offsets, page-aligned pointers are
|
|
* always valid.
|
|
*
|
|
* For just checking for SSE4.1, in the foreknowledge that the future use
|
|
* will be correctly aligned, just use i915_has_memcpy_from_wc().
|
|
*/
|
|
#define i915_can_memcpy_from_wc(dst, src, len) \
|
|
i915_memcpy_from_wc((void *)((unsigned long)(dst) | (unsigned long)(src) | (len)), NULL, 0)
|
|
|
|
#define i915_has_memcpy_from_wc() \
|
|
i915_memcpy_from_wc(NULL, NULL, 0)
|
|
|
|
#endif /* __I915_MEMCPY_H__ */
|