mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-28 05:12:49 +00:00
Code Issues Releases Wiki Activity
linux-stable/fs/ntfs3
History
Zeng Heng c1f2638e31 fs/ntfs3: fix panic about slab-out-of-bounds caused by ntfs_list_ea() 
commit 8e7e27b2ee upstream.

Here is a BUG report about linux-6.1 from syzbot, but it still remains
within upstream:

BUG: KASAN: slab-out-of-bounds in ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
BUG: KASAN: slab-out-of-bounds in ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
Read of size 1 at addr ffff888021acaf3d by task syz-executor128/3632

Call Trace:
 kasan_report+0x139/0x170 mm/kasan/report.c:495
 ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
 ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
 vfs_listxattr fs/xattr.c:457 [inline]
 listxattr+0x293/0x2d0 fs/xattr.c:804
 path_listxattr fs/xattr.c:828 [inline]
 __do_sys_llistxattr fs/xattr.c:846 [inline]

Before derefering field members of `ea` in unpacked_ea_size(), we need to
check whether the EA_FULL struct is located in access validate range.

Similarly, when derefering `ea->name` field member, we need to check
whethe the ea->name is located in access validate range, too.

Fixes: be71b5cba2 ("fs/ntfs3: Add attrib operations")
Reported-by: syzbot+9fcea5ef6dc4dc72d334@syzkaller.appspotmail.com
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
[almaz.alexandrovich@paragon-software.com: took the ret variable out of the loop block]
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-10-25 12:03:05 +02:00
..
lib
attrib.c fs/ntfs3: Fix attr_punch_hole() null pointer derenference 2023-01-24 07:24:41 +01:00
attrlist.c fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_load_attr_list() 2023-08-11 12:08:23 +02:00
bitfunc.c
bitmap.c fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
debug.h
dir.c
file.c fs/ntfs3: don't hold ni_lock when calling truncate_setsize() 2023-01-12 12:02:28 +01:00
frecord.c fs/ntfs3: Enhance sanity check while generating attr_list 2023-08-23 17:52:25 +02:00
fslog.c fs/ntfs3: Fix slab-out-of-bounds read in hdr_delete_de() 2023-05-11 23:03:33 +09:00
fsntfs.c fs/ntfs3: Mark ntfs dirty when on-disk struct is corrupted 2023-08-23 17:52:26 +02:00
index.c fs/ntfs3: Fix possible null-pointer dereference in hdr_find_e() 2023-10-25 12:03:05 +02:00
inode.c fs/ntfs3: Check fields while reading 2023-07-23 13:49:27 +02:00
Kconfig
lznt.c
Makefile
namei.c fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
ntfs.h fs/ntfs3: Refactoring of various minor issues 2023-05-17 11:53:51 +02:00
ntfs_fs.h fs/ntfs3: Mark ntfs dirty when on-disk struct is corrupted 2023-08-23 17:52:26 +02:00
record.c fs/ntfs3: Mark ntfs dirty when on-disk struct is corrupted 2023-08-23 17:52:26 +02:00
run.c fs/ntfs3: Check fields while reading 2023-07-23 13:49:27 +02:00
super.c fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_fill_super() 2023-01-04 11:28:57 +01:00
upcase.c
xattr.c fs/ntfs3: fix panic about slab-out-of-bounds caused by ntfs_list_ea() 2023-10-25 12:03:05 +02:00